Many Errors After Do...While

[jae5086]

The following is my broken code for a program that inserts 2-25 numbers into an array and averages them. It worked perfectly before I added the first do...while statement (line 9 - line 17) that ensures the user submits the correct number.

import javax.swing.*;
public class Numbers
{
	public static void main(String args[])
	{
		double d, tot=0, av;
		int n, counter=0;
		do
		{
			String num = JOptionPane.showInputDialog("How many numbers would you like to enter?  Please choose 2 to 25 numbers.");
			n = Integer.parseInt(num);
			if ((n > 1) && (n < 26))
				double[] numbers = new double[n];
			else
				System.out.println("Please enter a number between 2 and 25.");
		}while ((n < 2) && (n > 25));
		do
		{
			String ans = JOptionPane.showInputDialog("Enter a number.");
			d = Double.parseDouble(ans);
			numbers[counter] = d;
			tot = tot + numbers[counter];
			counter++;
		}while (counter != n);
		av = tot/n;
		System.out.println("The average of these numbers is " + av);
	}
}

[Fubarable]

What errors? Which lines throw them?

[UJJAL DHAR]

you are getting error here

Double[] numbers= new Double[n];

why you are declaring the array here?
Try this

import javax.swing.*;
public class Numbers
{
	public static void main(String args[])
	{
		double d, tot=0, av;
		int n, counter=0;
                 double[] numbers ;
		do
		{
			String num = JOptionPane.showInputDialog("How many numbers would you like to enter?  Please choose 2 to 25 numbers.");
			n = Integer.parseInt(num);
			if ((n > 1) && (n < 26))
			  numbers = new double[n];
			else
				System.out.println("Please enter a number between 2 and 25.");
		}while ((n < 2) && (n > 25));
		do
		{
			String ans = JOptionPane.showInputDialog("Enter a number.");
			d = Double.parseDouble(ans);
			numbers[counter] = d;
			tot = tot + numbers[counter];
			counter++;
		}while (counter != n);
		av = tot/n;
		System.out.println("The average of these numbers is " + av);
	}
}

And before your 2nd loop you must initialize the array.For missing this you will get an error here

numbers[counter] = d;

[jae5086]

And before your 2nd loop you must initialize the array.For missing this you will get an error here

Wasn't that what "double[] numbers;" did? Obviously not because, like you said, that is where I got the error, but how do I initialize it and do I still do so at the beginning of the program or should I be doing so between the loops?

Edit: I realized my terminology was poor and that beginning statement is a declaration, not an initialization. However, I am still unsure how to initialize before the loop. I thought that was what the second loop was essentially doing.

[UJJAL DHAR]

nothing just try it

public static void main(String args[])
{
double d, tot=0, av;
int n, counter=0;
double[] numbers =null;

[jae5086]

"=null" worked like a charm! Might I inquire what that did to solve the problem exactly so I know in the future? Is it because there was no value specifically attached to the array from the beginning that lead to the error?

[UJJAL DHAR]

"=null" worked like a charm! Might I inquire what that did to solve the problem exactly so I know in the future? Is it because there was no value specifically attached to the array from the beginning that lead to the error?

Well let n<=1 OR n>=26,then in first loop

if ((n > 1) && (n < 26))
			  numbers = new double[n];

This will never be executed.

Then in 2nd loop what do you think about this line???

numbers[counter] = d;

Isn't here the array is not initialized? for this line only,you have to initialized it as null.Got it?

Kind regards