Help with program

getting incorrect output, all help would be useful...

INPUT: Hello
OUTPUT(NOW):H, He, Hel, Hell, Hello
OUTPUT (NEEDED): o, lo, llo, ello, Hello

Code till now:

public class Loop {

public static void main(String[] args) {

String word;
String output = "";
Scanner scan = new Scanner(System.in);

System.out.println("Enter a string: ");
word = scan.next();

int numbers = word.length();

for (int i = 0; i < numbers; i++)
{
output += word.substring(0, i + 1) + ",";
}
System.out.println(output+ "\n");

}

}

reverse your loop

Code:

---

for (int i=numbers-1; i>=0; i--)

---

that way you start from the last character, and go down to the first.

You used substring() incorrectly. You had it start from the beginning of "Hello" and you want it to start from the end of "Hello".

Code:

---

public class Loop {

    public static void main(String[] args) {
   
    String word;
    String output = "";
    Scanner scan = new Scanner(System.in);
   
    System.out.println("Enter a string: ");
    word = scan.next();
   
    int numbers = word.length();

for (int i = 1; i <= numbers; i++)
{
output += word.substring(numbers-i) + ",";
}
System.out.println(output+ "\n");

}
   
}

---

Do not spoon feed code solar. I feel like a broken record. Try to be more vague with your help so they think about it and solve it themselves. I do understand his mistakes was small but a vague statement can definitely be more helpful.

It is now giving me this:

Input: Hello
Output: o, lo, llo, ello,

It is not going on from "ello" to "hello"
don't know what's wrong. Please help.

Quote:

---

Originally Posted by Solarsonic

You used substring() incorrectly. You had it start from the beginning of "Hello" and you want it to start from the end of "Hello".

Code:

---

public class Loop {

    public static void main(String[] args) {
   
    String word;
    String output = "";
    Scanner scan = new Scanner(System.in);
   
    System.out.println("Enter a string: ");
    word = scan.next();
   
    int numbers = word.length();

for (int i = 1; i < numbers; i++)
{
output += word.substring(numbers-i) + ",";
}
System.out.println(output+ "\n");

}
   
}

---

---

if you need to iterate once more,
do this:
i <= numbers

Think about why it isn't working instead of just asking for the answer. How many times does this loop happen?

Code:

---

String  s = "Hello";
for(int i = 0; i < s.length(); i++){}

---

Quote:

---

Originally Posted by sunde887

Think about why it isn't working instead of just asking for the answer. How many times does this loop happen?

Code:

---

String  s = "Hello";
for(int i = 0; i < s.length(); i++){}

---

---

that doesn't change anything because he's already written this:

Code:

---

int numbers = word.length();

---

He just did the same as me, indirectly. It still helps him to think about it instead of continuously coming here asking for the answer.

If he doesn't take the time to really understand what the problem is, later assignments are only going to be more difficult.