graphics null pointer exception

[aizen92]

Hello,

Iam trying to make a program that displays 2 eyes, and according to the mouse movement to look up, down, left, or right
i am first drawing the eyes, here is my code

import java.awt.*;
import javax.swing.*;
import javax.swing.event.*;

public class EyeGUI
{
    private JFrame frame;

    private JPanel eyePanel;

    public EyeGUI ()
    {
        frame = new JFrame("The eyes have it");

        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        frame.setSize(new Dimension(280, 200));

        eyePanel = new JPanel ();
        eyePanel.setBackground(Color.GRAY);
        Graphics g = eyePanel.getGraphics();
        
        g.setColor(Color.BLACK);
        g.drawOval(40, 50, 100, 100);
        g.drawOval(140, 50, 100 ,100);
        
        frame.setVisible(true);
    }

    public static void main (String[] args)
    {
        new EyeGUI ();
    }
}

the thing im having is it is highlighting on the first g. statement, fromg.setColor(..) i removed it and then it highlighted over g.drawOval(...) with a null pointer exception

what could be my problem, did i miss to call a method i should have or what?

Thanks in advance

[JosAH]

Extend a JPanel and override its paintComponent(Graphics g) method; do all your drawing in that method. That way the EDT (Event Dispatch Thread) decides when your component needs to be drawn and it creates the correct Graphics object for you.

kind regards,

Jos

[aizen92]

Okay,
Thanks Jos for the help

[DarrylBurke]

And never use getGraphics() of a Component in client code.

db

[aizen92]

@Jos: should I like create a new class for constructing the shapes, and extend it JPanel and then create its constructor in my code?
If yes, in the class which extends JPanel i should only write the codes for the paintComponent, right?

@db: Lol, i just learnt my lesson now
Thnx for the help

[JosAH]

@Jos: should I like create a new class for constructing the shapes, and extend it JPanel and then create its constructor in my code?
If yes, in the class which extends JPanel i should only write the codes for the paintComponent, right?

Just extend a JPanel as follows:

public class EyePanel extends JPanel {

   // your constructors go here

   // override this method:
   public void paintComponent(Graphics g) {
      // draw the eye here
   }
}

... and instantiate an EyePanel where you're now instantiating an ordinary JPanel.

kind regards,

Jos

[aizen92]

I did as Jos said, and heres my code

import java.awt.*;
import java.awt.image.*;
import javax.swing.*;
import javax.swing.event.*;

public class EyeGUI extends JPanel
{
    private JFrame frame;

    private JPanel eyePanel;
    
    private Graphics g;

    public EyeGUI ()
    {
        frame = new JFrame("The eyes have it");

        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        frame.setSize(new Dimension(280, 200));

//         BufferedImage image = new BufferedImage (280, 200, BufferedImage.TYPE_INT_ARGB);
//         g = image.getGraphics();
//         g.setColor(Color.WHITE);
//         g.fillOval(25, 35, 115, 115);
//         g.fillOval(140, 35, 115, 115);
//         g.setColor(Color.BLACK);
//         g.drawOval(25, 35, 115, 115);
//         g.drawOval(140, 35, 115, 115);
//         g.setColor(Color.BLACK);
//         g.fillOval(70, 80, 20, 20);
//         g.fillOval(170, 80, 20, 20);
//         
//         JLabel lbl = new JLabel ();
//         lbl.setIcon(new ImageIcon(image));
//         
         eyePanel = new JPanel ();
//         eyePanel.add(lbl);
        Graphics g = eyePanel.getGraphics();
        paintComponent(g);
        frame.add(eyePanel);
        
        frame.pack();
        
        frame.setVisible(true);
    }
    
    public void paintComponent (Graphics g)
    {
        g.setColor(Color.WHITE);
         g.fillOval(25, 35, 115, 115);
         g.fillOval(140, 35, 115, 115);
         g.setColor(Color.BLACK);
         g.drawOval(25, 35, 115, 115);
         g.drawOval(140, 35, 115, 115);
    }

    public static void main (String[] args)
    {
        new EyeGUI ();
    }
}

but still im getting he null pointer error at the g.setColor(...) in the paintComponent method

[Fubarable]

You're still using getGraphics, what Darryl told you not to do! And you're calling paintComponent directly, something you should never do. Please read the graphics tutorials as they will show you how to do this correctly since your assumptions are incorrect (as all of ours are when we start), and you need to start from ground up to learn Swing graphics (we all do).

For e.g., please check out:

Painting in Swing
2D Graphics

Click on the links above for two good tutorials on this subject.

[aizen92]

ohhhh, i misread Jos example code, i though of it as my main gui class, i didnt notice whats wrong with it until now.
@Fubarable, i'll read them and then continue the project
Thnx