Suggestions return all

[mario_tim]

Hi,

I have RPC SuggestBox, but unfortunately it return me all data from server side instead of required. And also I wanted to convert returned result into array and fetch into labels inside ScrollPanel, what's problem?

[ozzyman]

we don't know the problem without looking at your code for the suggestbox.

as for converting returned result into an array, that also depends on the return Type of the suggestbox.

fetching into labels is easy,
myLabel.setText(returnResultArray[index]);

[mario_tim]

public class ItemSuggestionOracle extends SuggestOracle {
    public static final RPCSuggestAsync rpcService = RPCSuggest.App.getInstance();
    public boolean isDisplayStringHTML() {
           return true;
       }

       public void requestSuggestions(SuggestOracle.Request req,SuggestOracle.Callback callback) {
           rpcService.getQuote(req, new ItemSuggestCallback(req, callback));
       }

       class ItemSuggestCallback implements AsyncCallback {

           private SuggestOracle.Request req;
           private SuggestOracle.Callback callback;

           public ItemSuggestCallback(SuggestOracle.Request _req,
                   SuggestOracle.Callback _callback) {
               req = _req;
               callback = _callback;
           }

           public void onFailure(Throwable error) {
               callback.onSuggestionsReady(req, new SuggestOracle.Response());
           }

           public void onSuccess(Object retValue) {
               callback.onSuggestionsReady(req,
                       (SuggestOracle.Response) retValue);
           }
       }
}

public class ItemSuggestion implements IsSerializable, SuggestOracle.Suggestion {

      private String s;
      // Required for IsSerializable to work
      public ItemSuggestion() {
      }

      // Convenience method for creation of a suggestion
      public ItemSuggestion(String s) {
         this.s = s;
      }

      public String getDisplayString() {
          return s;
      }

      public String getReplacementString() {
          return s;
      }
   } // end inner class ItemSuggestion

public interface RPCSuggest extends RemoteService {
    SuggestOracle.Response getQuote(SuggestOracle.Request req);

and server side...

public class RPCSuggestImpl extends RemoteServiceServlet implements RPCSuggest {
     public SuggestOracle.Response getQuote(SuggestOracle.Request req) {
        SuggestOracle.Response resp = new SuggestOracle.Response();
        List<ItemSuggestion> suggestions=new ArrayList<ItemSuggestion>();
        for (int i=0;i<1000;i++)
        {
            Integer j=i;
            suggestions.add(new ItemSuggestion(j.toString()));
        }

        resp.setSuggestions(suggestions);
        return resp;
    }
}

[mario_tim]

we don't know the problem without looking at your code for the suggestbox.

as for converting returned result into an array, that also depends on the return Type of the suggestbox.

fetching into labels is easy,
myLabel.setText(returnResultArray[index]);

here I posted my code, so could you help me?

[ozzyman]

i'm surprised that you can't see why this would give you ALL data instead of the required data:

        List<ItemSuggestion> suggestions=new ArrayList<ItemSuggestion>();
        for (int i=0;i<1000;i++)
        {
            Integer j=i;
            suggestions.add(new ItemSuggestion(j.toString()));
        }

on the positive side, you're almost there. this is what your code says in English:

Make a new List to store our results //thats fine
Loop 1000 items {
    add new ItemSuggestion to our List //adding items unconditionally not good
}

But this is what it should say in English:

Make a new List to store our results
Loop 1000 items {
    if we find 'the right suggestion' or 'a match' {
        add it to our List
    }
}

[mario_tim]

i'm surprised that you can't see why this would give you ALL data instead of the required data:

        List<ItemSuggestion> suggestions=new ArrayList<ItemSuggestion>();
        for (int i=0;i<1000;i++)
        {
            Integer j=i;
            suggestions.add(new ItemSuggestion(j.toString()));
        }

on the positive side, you're almost there. this is what your code says in English:

Make a new List to store our results //thats fine
Loop 1000 items {
    add new ItemSuggestion to our List //adding items unconditionally not good
}

But this is what it should say in English:

Make a new List to store our results
Loop 1000 items {
    if we find 'the right suggestion' or 'a match' {
        add it to our List
    }
}

ok, I got advice very very useful, but sorry if my English not so correct, caused that is not my native, but what about parsing gettin results to arraylist, I know how use data from array list and paste it in labels, but there is problem for getting List<ItemSuggestions> instead of SuggestOracle.Response in server side

[ozzyman]

I am not so sure what you mean...

but there is problem for getting List<ItemSuggestions> instead of SuggestOracle.Response in server side

what do you want to do?

[mario_tim]

I want to get array list, for further paste information from it to label
but I get SuggestionList, which cannot be parsed, or I don't know how.