Problem with fillRect() function

[dreamstring]

Hi everyone,

I am new in java, and I am practicing with an example from a java book. I want to create a window with a black rectangle on the center. The following is my code. When I run it, I got only the window, but the rectangle is not shown. I typed the code exactly from the book; I don't know why I cannot get the correct result. Anyone can help me? Thank you!

import java.awt.*;
import javax.swing.*;

public class ColoredRectanglePractice {

public static void main(String[] args) {
ColoredRectangle rectangle = new ColoredRectangle();
rectangle.paint();
}

}

class ColoredRectangle{
private int width;
private int height;
private int x;
private int y;
private JFrame window;
private Color color;

// Default constructor
public ColoredRectangle()
{
width = 40;
height = 20;
x = 100;
y = 100;
color = Color.BLACK;

window = new JFrame("New Window");
window.setSize(500, 500);
window.setVisible(true);
window.setDefaultCloseOperation(JFrame.EXIT_ON_CLO SE);

}
public void paint()
{
Graphics g = window.getGraphics();
g.setColor(color);
g.fillRect(x, y, width, height);
}
}

[Junky]

I'd double check your code with the code in the book. I'm 99% sure that they would not include an example program if it didn't work.

[dreamstring]

Thank you for your reply, Junky. I am sure that my code is exactly the same as the code in the book. I am not sure if it could be the issue of the version of JDK or the OS... I am using Win7 and JDK 1.6.0_24

[Junky]

If you have the attitude that your code is perfect and could not possibly be wrong then you are not going to do very well in programming.

[dreamstring]

Thank you for your lesson, Junky. I will check the code with the book again.

[DarrylBurke]

Graphics g = window.getGraphics();

Scrap the book. Any book that advises to use getGraphics of a component deserves to be composted. Any method of attempting custom painting is a top level window is also deplorable.

Learn how to correctly perform custom painting here:
Lesson: Performing Custom Painting (The Java™ Tutorials > Creating a GUI With JFC/Swing)

db

[dreamstring]

Thank you, Darryl! This tutorial is really helpful! I guess I need to buy a better book :). This book is really misleading.