Character.isLetter problem

I am trying to work with converting integers to string for the purposes of ending loops. The code below is what I am working with. The idea is that the user can input deposits until the user enters a negative value or the letter "Q". At that point the total deposits are returned to the calling procedure. The code ran fine until I included the Character.isLetter('Q') in the if statement. As of now, this line always returns True and never gets to the else. Thank you for your help.

[ code]
import java.util.*;
public class Deposits {

public static int getDeposit(int ttlDep){
int value = 0;


System.out.println("Enter a negative number or Q when finished entering deposits");
Scanner input = new Scanner(System.in);



value = input.nextInt();
String aString = Integer.toString(value);


System.out.println("aString is: " + aString);

if ((value <= 0)||(Character.isLetter('Q')))
return ttlDep;
else
ttlDep = ttlDep + value;
return getDeposit(ttlDep);

}

public static void main(String[] args){
int finalDep = 0;
System.out.println("Enter your deposit below.");
int dep = getDeposit(finalDep);
System.out.println("Your deposit of $" + dep + " was received. Thank you");

}
}
[/code]

Quote:

---

As of now, this line always returns True and never gets to the else.

---

no wonder if you write it hard coded with constant character :)

|| (Character.isLetter('Q') --> is every time true, you don`t use the input !
->
|| (Character.isLetter('HERE THE ENTERED CHARACTER FROM THE USER!')

The text value aString was converted from int to string to store the character the user input. When I put that value in the Character.isLetter(aString), I get a InputMismatchException. Isn't that what you were suggesting? I also tried Character.isLetter('aString') and then isLetter is identified as the error.

Can you help a little bit more please?

you seem to have missed out an opening bracket after your IF statement...

Code:

---

if ((value <= 0)||(Character.isLetter('Q')))
return ttlDep;
else
ttlDep = ttlDep + value;
return getDeposit(ttlDep);

---

The 'else' part will not be run because the IF statement is closed after 'return ttlDep;'.

Code:

---

if ((value <= 0)||(Character.isLetter('Q'))) {
  return ttlDep;
} else {
  ttlDep = ttlDep + value;
  return getDeposit(ttlDep);
}

---

Quote:

---

Originally Posted by ozzyman

The 'else' part will not be run because the IF statement is closed after 'return ttlDep;'.

---

Actually the reason has already been posted above.

Quote:

---

Originally Posted by BillyB

The text value aString was converted from int to string to store the character the user input. When I put that value in the Character.isLetter(aString), I get a InputMismatchException.

---

The reason is because the isLetter method expects a char as the parameter but you are passing a String. You don't even need the isLetter method. Use the equals method of String.

Code:

---

if(input.equalsIgnoreCase("Q")) {
    user wants to quit.
} else {
    convert input to an int
}

---