Problem with while loop

[sassy1]

Can't get my while loop to work. If I move it up it works but not in the place its suppose to. Something to do with promting the numEntered?? Any ideas?


import java.util.*;
import javax.swing.*;

public class PhoneBook
{
public static void main(String[] args)
{
//int num;
String[] friendName = new String[20];
//String numString;
int[] numEntered = new int[20];
String entry = "", friendString = "";
String input = "", numString = "";
int x = 0;

int highestSub = friendName.length - 1;
Arrays.fill(friendName, "zzz");
friendName[x] = JOptionPane.showInputDialog(null, "Enter in the name of your friend or zzz to exit");
numString = JOptionPane.showInputDialog(null, "Enter the phone number of " + friendName[x]);
numEntered[x] = Integer.parseInt(numString);

while(!friendName[x].equals("zzz") && x < highestSub)
{
friendString = friendString + friendName[x] + "\n";
numString = numString + numEntered [x] + "\n";
++x;
if(x < highestSub)
friendName[x] = JOptionPane.showInputDialog(null, "Enter in the name of your friend or zzz to exit");
}

numEntered = x;
JOptionPane.showMessageDialog(null, "You entered in the names and phone numbers of " + numEntered + " friends: \n" + friendString);
//Arrays.sort(friendName, 0, numEntered); //change to sort by name
x = Arrays.binarySearch(friendName, entry);
if(x >= 0 && x < numEntered)
JOptionPane.showMessageDialog(null, "Your friend xx,xxx has the phone number xxx");//need to fix

}

}

[Bmorebob]

1. To get better help sooner, post a SSCCE (Short, Self Contained, Compilable and Executable) example that demonstrates the problem. Note that the code you posted is NOT a SSCCE on at least two accounts:
-- doesn't compile
-- lots of code unrelated to the stated problem

[Bmorebob]

...you never re-prompted the user for a new number, just their name (look at the if statement in the while loop)

here you go:

import java.util.*;
import javax.swing.*;

public class PhoneBook
{
	public static void main(String[] args)
	{
		int num;
		String[] friendName = new String[20];
		int[] numEntered = new int[20];
		String entry = "", friendString = "";
		String input = "", numString = "";
		int x = 0;
		int highestSub = friendName.length - 1;

		Arrays.fill(friendName, "zzz");
		friendName[x] = JOptionPane.showInputDialog(null, "Enter in the name of your friend or zzz to exit");
		numString = JOptionPane.showInputDialog(null, "Enter the phone number of " + friendName[x]);
		numEntered[x] = Integer.parseInt(numString);

		while(!friendName[x].equals("zzz") && x < highestSub)
		{
			friendString += friendName[x] + "\n";
			numString += numEntered [x] + "\n";
			x++;
			if(x < highestSub)
			{
				friendName[x] = JOptionPane.showInputDialog(null, "Enter in the name of your friend or zzz to exit");
				if (!friendName[x].equals("zzz"))
				{
					numString = JOptionPane.showInputDialog(null, "Enter the phone number of " + friendName[x]);
					numEntered[x] = Integer.parseInt(numString);
				}
			}
		}
		/*for(int i = 0; i < friendName.length; i++)     Debugging check
		{
			System.out.println(friendName[i]);
		}*/
		num = x;
		JOptionPane.showMessageDialog(null, "You entered in the names and phone numbers of " + num + " friends: \n" + friendString);

		Arrays.sort(friendName, 0, num);
		entry = JOptionPane.showInputDialog(null, "Whose number would you like to find?");
		x = Arrays.binarySearch(friendName, entry);
		if(x >= 0 && x < num)
		JOptionPane.showMessageDialog(null, "Your friend " + entry + " has the phone number " + numEntered[x]);
	}
}

[Bmorebob]

Also, instead of parallel arrays (which is fine) it might be easier to do a 2-D array instead.

[sassy1]

My 1st post, I apologize if it was not formatted correctly. I tried your suggestion but it never loops??

[Bmorebob]

What do you mean it never loops? What are you trying to have it loop?

[sassy1]

input window- I enter name
input window-I enter #
nothing else, errors about the # string & parse int

[Bmorebob]

copy and paste the code below into an empty java file...

import java.util.*;
import javax.swing.*;

public class PhoneBook
{
	public static void main(String[] args)
	{
		int num;
		String[] friendName = new String[20];
		int[] numEntered = new int[20];
		String entry = "", friendString = "";
		String input = "", numString = "";
		int x = 0;
		int highestSub = friendName.length - 1;

		Arrays.fill(friendName, "zzz");
		friendName[x] = JOptionPane.showInputDialog(null, "Enter in the name of your friend or zzz to exit");
		numString = JOptionPane.showInputDialog(null, "Enter the phone number of " + friendName[x]);
		numEntered[x] = Integer.parseInt(numString);

		while(!friendName[x].equals("zzz") && x < highestSub)
		{
			friendString += friendName[x] + "\n";
			numString += numEntered [x] + "\n";
			x++;
			if(x < highestSub)
			{
				friendName[x] = JOptionPane.showInputDialog(null, "Enter in the name of your friend or zzz to exit");
				if (!friendName[x].equals("zzz"))
				{
					numString = JOptionPane.showInputDialog(null, "Enter the phone number of " + friendName[x]);
					numEntered[x] = Integer.parseInt(numString);
				}
			}
		}
		num = x;
		JOptionPane.showMessageDialog(null, "You entered in the names and phone numbers of " + num + " friends: \n" + friendString);

		Arrays.sort(friendName, 0, num);
		entry = JOptionPane.showInputDialog(null, "Whose number would you like to find?");
		x = Arrays.binarySearch(friendName, entry);
		if(x >= 0 && x < num)
		JOptionPane.showMessageDialog(null, "Your friend " + entry + " has the phone number " + numEntered[x]);
	}
}

[sassy1]

Must be me I still get the following;


at java.lang.NumberFormatException.forInputString(Unk nown Source)
at java.lang.Integer.parseInt(Unknown Source)
at java.lang.Integer.parseInt(Unknown Source)
at PhoneBook.java.PhoneBook.main(PhoneBook.java:28)

[sassy1]

Thanks for all of your help, my problem seems to be that my JOptions Pane does not accept the dashes I try to put in the phone number. How do I do that?

[Bmorebob]

Ohh, well that's because dashes can't be read in as numerical values. The easiest way around it would be to tell the user to not include dashes when inputting the phone number. Or better yet, since you're not doing any operations with the phone number, why not keep them as strings? that would eliminate any requirements.

[DarrylBurke]

since you're not doing any operations with the phone number, why not keep them as strings?

Sound advice. Any numerical entities that are not subject to any kind of mathematics should always be stored and treated as Strings. This includes phone numbers, house numbers, social security numbers, employee ID numbers ...

db

[sassy1]

Keeping it as a string works, but the last loop does not. What do I need to change to get the last JOption pane to come up?