Picture not showing when create JAR file

[kmckinley820]

When I run the below code from the console or in Eclipse it run perfect with the "logo.jpg" showing in the center of my screen.
When I extract it into a JAR File and them try to run it. It seem like it can't find the picture. I can't figure out what I'm doing wrong.

class LogoFlashScreen {                
	String logo = "logo.jpg";	       
	Toolkit toolkit;
	int logoWidth;
	int logoHeight;
	int x;
	int y;	
	
	public void runFlashScreen() {
		JWindow flashWindow = new JWindow();
		LogoPanel logoPanel = new LogoPanel();
		flashWindow.add(logoPanel);

		getLogoSizeAndLocation();

		flashWindow.setSize(logoWidth, logoHeight);
		flashWindow.setLocation(x, y);
		flashWindow.setVisible(true);
		for (int i=0; i<50; i++) {
			try {
				Thread.sleep(20);
			}catch(Exception ex) { 
			}
		}
		flashWindow.setVisible(false);
	}
	
	public void getLogoSizeAndLocation() {
		logoWidth = new ImageIcon(logo).getIconWidth();
		logoHeight = new ImageIcon(logo).getIconHeight();

		toolkit = Toolkit.getDefaultToolkit();
		Dimension screenSize = toolkit.getScreenSize();
		x = (int) (screenSize.getWidth() - logoWidth)/2;
		y = (int) (screenSize.getHeight() - logoHeight)/2;		
	}

	@SuppressWarnings("serial")
	class LogoPanel extends JPanel {

		public void paintComponent(Graphics g) {
			Image image = new ImageIcon(logo).getImage();
			g.drawImage(image,0,0,this);
		}
	}
}

[pbrockway2]

When I run the below code from the console or in Eclipse it run perfect with the "logo.jpg" showing in the center of my screen.
When I extract it into a JAR File and them try to run it. It seem like it can't find the picture.

Actually that code lacks a main() method so what follows is, in part, guesswork.

The code repeatedly includes the expression "new ImageIcon(logo)" where logo is a String. According to the ImageIcon API docs this constructor "Creates an ImageIcon from the specified file. The image will be preloaded by using MediaTracker to monitor the loading state of the image. The specified String can be a file name or a file path".

I am guessing that the image is actually included as part of the jar archive. It is the reliance in your code on filenames that is the source of the problem. CLearly once you have an executable jar it can be moved to and run from any location at all. References to specific file locations that make sense in one context will not make sense in another.

The solution is to use a different constructor: ImageIcon(URL location) or ImageIcon(Image image) perhaps.

The Class method getResource() is useful for constructing a URL if the image is included in the jar file. And the ImageIO class provides ways of constructing an image from a URL.

-----

A different matter is the fact you are continually using this expression. It might be better to read the image and construct the icon once. (Just as the String logo is given a value just once and then reused.)

[kmckinley820]

The main() method is in another class that is part of this program.

I've made some of the changes you suggested:

I can't figure out how the use the Class method getResource. I just started coding with Java about three weeks ago, so i have alot to learn still.

class LogoFlashScreen {	
	
	ImageIcon logo = new ImageIcon("logo.jpg");

	Toolkit toolkit;
	int logoWidth;
	int logoHeight;
	int x;
	int y;	
	
	public void runFlashScreen() {
		
		JWindow flashWindow = new JWindow();
		LogoPanel logoPanel = new LogoPanel();
		flashWindow.add(logoPanel);

		getLogoSizeAndLocation();

		flashWindow.setSize(logoWidth, logoHeight);
		flashWindow.setLocation(x, y);
		flashWindow.setVisible(true);
		for (int i=0; i<50; i++) {
			try {
				Thread.sleep(60);
			}catch(Exception ex) { 
			}
		}
		flashWindow.setVisible(false);
	}
	
	public void getLogoSizeAndLocation() {
		logoWidth = logo.getIconWidth();
		logoHeight = logo.getIconHeight();
		
		toolkit = Toolkit.getDefaultToolkit();
		Dimension screenSize = toolkit.getScreenSize();
		x = (int) (screenSize.getWidth() - logoWidth)/2;
		y = (int) (screenSize.getHeight() - logoHeight)/2;		
	}

	@SuppressWarnings("serial")
	class LogoPanel extends JPanel {

		public void paintComponent(Graphics g) {
			Image image = logo.getImage();
			g.drawImage(image,0,0,this);
		}
	}
}

[kmckinley820]

I figured it out. Below is the final code.

Thanks for all the help!!!!

class LogoFlashScreen {	
	
	URL logoURL = this.getClass().getResource("/resource/logo.jpg");
	
	ImageIcon logo = new ImageIcon(logoURL);

	Toolkit toolkit;
	int logoWidth;
	int logoHeight;
	int x;
	int y;	
	
	public void runFlashScreen() {
		
		JWindow flashWindow = new JWindow();
		LogoPanel logoPanel = new LogoPanel();
		flashWindow.add(logoPanel);

		getLogoSizeAndLocation();

		flashWindow.setSize(logoWidth, logoHeight);
		flashWindow.setLocation(x, y);
		flashWindow.setVisible(true);
		
		try {
			Thread.sleep(2000);
		}catch(Exception ex) { 
		}
		
		flashWindow.setVisible(false);
	}

	public void getLogoSizeAndLocation() {
		logoWidth = logo.getIconWidth();
		logoHeight = logo.getIconHeight();
		
		toolkit = Toolkit.getDefaultToolkit();
		Dimension screenSize = toolkit.getScreenSize();
		x = (int) (screenSize.getWidth() - logoWidth)/2;
		y = (int) (screenSize.getHeight() - logoHeight)/2;		
	}

	@SuppressWarnings("serial")
	class LogoPanel extends JPanel {

		public void paintComponent(Graphics g) {
			Image image = logo.getImage();
			g.drawImage(image,0,0,this);
		}
	}
}

[pbrockway2]

URL logoURL = this.getClass().getResource("/resource/logo.jpg");

You're welcome. I'm glad you've got it figured out.