BankAccount, how to reject negative amounts? PLEASE HELP!

[armedrabbit]

This illustrates one of the important functions of methods. They should guarantee that the instance data of the object is always valid. In this case the methods (and constructor) prevent the balance from ever being negative. They also prevent reject invalid parameters.

You should test all the modified methods and constructors but you do not need to submit a Tester class


So this is what i have so far, can anyone help me with it?

/**
A bank account has a balance that can be changed by
deposits and withdrawals.
*/
public class BankAccount
{
public static void main(String[] args)
{
double balance;
int transaction;

if (balance < 0)
System.out.println("ERROR NEGATIVE AMOUNT");
else
/**
Constructs a bank account with a zero balance.
*/
public BankAccount()
{
balance = 0;
}

/**
Constructs a bank account with a given balance.
@param initialBalance the initial balance
*/
public BankAccount(double initialBalance)
{
balance = initialBalance;
}

/**
Deposits money into the bank account./**

Im not exactly sure if i have to make a tester class or not, because i do not know how to combine the classes.


/**
A class to test the BankAccount class.
*/
public class BankAccountTester
{
/**
Tests the methods of the BankAccount class.
@param args not used
*/
public static void main(String[] args)
{

BankAccount harrysChecking = new BankAccount();

harrysChecking.deposit(2000);
harrysChecking.withdraw(500);
System.out.println(harrysChecking.getBalance());

System.out.println("Expected: 1500");
harrysChecking.endOfMonth();
System.out.println(harrysChecking.getBalance());
System.out.println("Expected: 1498");
harrysChecking.deposit(1000);
harrysChecking.withdraw(500);
harrysChecking.endOfMonth();
System.out.println(harrysChecking.getBalance());
System.out.println("Expected: 1996");
}
}

[sunde887]

in the methods where you want to only accept a positive number just put an if clause to test that they are positive. If the argument is positive, continue as normal, if not print that the number needs to be positive and don't make any changes.

[armedrabbit]

in the methods where you want to only accept a positive number just put an if clause to test that they are positive. If the argument is positive, continue as normal, if not print that the number needs to be positive and don't make any changes.

can you give me an example? where do i put the if statement?

[Junky]

To be blunt, your code is a mess.

You have the BankAccount constructors and methods inside a main method. You also have 2 BankAccountTester classes, one inside BankAccount and one separate. Clean your code up and things might look better and be easier to see what needs to be done.

[armedrabbit]

sorry Junky, i accidently double pasted. but i'll try to fix it right now...

[armedrabbit]

Here's my updated program can you guys tell me if i did it right? :confused:


/**
A bank account has a balance that can be changed by
deposits and withdrawals.
*/
public class BankAccount
{

double balance;
int transaction;
/**
Constructs a bank account with a zero balance.
*/
public BankAccount()
{

if (balance < 0)
System.out.println("ERROR NEGATIVE AMOUNT");
}

/**
Constructs a bank account with a given balance.
@param initialBalance the initial balance
*/
public BankAccount(double initialBalance)
{
balance = initialBalance;
initialBalance = 0;
}

/**
Deposits money into the bank account.
@param amount the amount to deposit
*/
public void deposit(double amount)
{
double newBalance = balance + amount;
balance = newBalance;
transaction = transaction +1;
if (balance < 0)
System.out.println("ERROR NEGATIVE AMOUNT");

}


/**
Withdraws money from the bank account.
@param amount the amount to withdraw
*/
public void withdraw(double amount)
{
double newBalance = balance - amount;
balance = newBalance;
transaction = transaction +1;
if (balance < 0)
System.out.println("ERROR NEGATIVE AMOUNT");
}

/**
Gets the current balance of the bank account.
@return the current balance
*/
public double getBalance()
{
if (balance < 0)
System.out.println("ERROR NEGATIVE AMOUNT");
return balance;
}
/**
Charges monthly fee
*/
public void endOfMonth()
{
double newbalance = balance - transaction;
balance = newbalance;
transaction = 0;
}
}


-----------------------------------------------------------------------

/**
A class to test the BankAccount class.
*/
public class BankAccountTester
{
/**
Tests the methods of the BankAccount class.
@param args not used
*/
public static void main(String[] args)
{

BankAccount harrysChecking = new BankAccount();

harrysChecking.deposit(2000);
harrysChecking.withdraw(2100);
System.out.println(harrysChecking.getBalance());


harrysChecking.endOfMonth();
System.out.println(harrysChecking.getBalance());

harrysChecking.deposit(1000);
harrysChecking.withdraw(500);
harrysChecking.endOfMonth();
System.out.println(harrysChecking.getBalance());

}
}

[juhiswt]

import java.util.Scanner;
class BankAccount
{
public Scanner S=new Scanner(System.in);
public double balance,amnt,initialBalance;




/**
Constructs a bank account with a given balance.
@param initialBalance the initial balance
*/
void newBankAccount()
{
System.out.println("Enter The initail Balance");
double initialBalance=S.nextDouble();

if(initialBalance<0)
balance = 0;
else
balance=initialBalance;
}

/**
Deposits money into the bank account.*/
void deposit()
{
System.out.println("Enter The amount to be deposited");
double amnt=S.nextDouble();

if(amnt<0)
{
balance=balance;
System.out.println("This value can not be deposited");
}
else
balance=balance+amnt;
}

/** Withrawl money from bank account*/
void withdrawls()
{

System.out.println("Enter The amount to be withdrwaled");
double amnt=S.nextDouble();
if(amnt<0)
{
balance=balance;
System.out.println("This value can not be withdrawdled");
}
else
balance=balance-amnt;
}
void getBalance()
{
System.out.println("The Balance is:"+balance);
}
}



/**
A class to test the BankAccount class.
*/
public class BankAccountTester
{
/**
Tests the methods of the BankAccount class.
@param args not used
*/
public static void main(String[] args)
{

BankAccount h = new BankAccount();

Scanner S=new Scanner(System.in);
int ch;


do
{
System.out.println("1.To create a new account");
System.out.println("2.To deposit the amount in account");
System.out.println("3.To Withdrawal tha amount from account");
System.out.println("4.to get the current balance");
System.out.println("5.Exit");

System.out.println("Enter the choice");
ch=S.nextInt();
switch(ch)
{
case 1: h.newBankAccount();
break;
case 2:
h.deposit();
break;
case 3:
h.withdrawls();
break;
case 4: h.getBalance();
break;
case 5: System.exit(0);
break;
default:
System.out.println("Invalid");
}
}while(ch>1||ch<5);
}



}