Counting Words

[Shyamz1]

Hi guys, how are you all. I'm trying to create a program that reads the characters from standard input counting how many words that contains and reports the number on its standard output. I have managed to create a program that counts the characters but am having trouble working with words.

Here is my code so far: I'm sure there's an obvious mistake somewhere, i'm just a beginner.

import java.io.InputStreamReader;
import java.io.IOException;

// Program to read characters on standard input, counting
// how many words that contains and reports number on its
// standard output.

public class WordCount
{
  public static void main(String [] args)
  {
    // There are 65535 different character values (2bytes)
    // The array will already be set to zero in each element.
    
    int[] wordCount = new int[65535];
    
    // we will read the input as characters.
    InputStreamReader input = new InputStreamReader(System.in);
    
    // the number of words found so far.
    int allWordsCount = 0;
    
    try
    {
      int currentWord;
      while ((currentWord = input.read()) != -1)
      {
        allWordsCount++;
	wordCount[currentWord]++;
      }
    }
    
    catch (IOException exception)
    {
      System.err.println(exception);
    }
    
    finally
    {
      try { input.close(); }
      catch (IOException exception)
        { System.err.println("could not close input " + exception); }
    }
    
    System.out.println("the number of words read was " + allWordsCount);
    
  }
}

Any suggestions or assistance would be most appreciated :)

Kind regards

Shyam

[subith86]

What I understand from your question is that you want to count
1. number of characters
2. number of words.

The first one is already done in your code.

      int currentWord;
      while ((currentWord = input.read()) != -1)
      {
        allWordsCount++; [COLOR="YellowGreen"][B][I]//this is actually the count of characters eventhough you named it wrong[/I][/B][/COLOR]
	wordCount[currentWord]++;
      }

Now the number of words. Isn't it easier by counting number of SPACEs. No. of words = No. of spaces + 1 ;)

And what was this for

int[] wordCount = new int[65535];

Doesn't make any sense.

[Shyamz1]

So would i use a while loop for that too...

What can i set the variables to? e.g. I would need to create a No of spaces variable and a noOfWords. But how would i firstly count the number of spaces


Regards

Shyam

[Skiller]

Assuming words are separated by just a single space then most of the time the number of words is the number of spaces (the space character " ") + 1.

[Shyamz1]

How would you set a variable to a space character. noOfSpaces = " "; doesn't work. is there a special way.

Would you use the Character.isWhiteSpace(c)?

Regards

[subith86]

A little more matured way of counting words is shown below. Doesn't require any extra loop. Everything can be done in your own loop.

	    	boolean wasWhiteSpace = false;
	    	boolean isWhiteSpace = false;
	    	int wordCount=0;
	    	int charCount=0;
		int currentChar;
		while ((currentChar = input.read()) != -1) {
				[COLOR="YellowGreen"][I]//Counting chars[/I][/COLOR]
			charCount++;

				[COLOR="YellowGreen"][I]//Counting words[/I][/COLOR]
			isWhiteSpace = Character.isWhitespace((char)currentChar);
			if(isWhiteSpace && !wasWhiteSpace) wordCount++;
			wasWhiteSpace = isWhiteSpace;
		}

[Shyamz1]

I get an error saying that the input.read() must be declared or caught .....

import java.io.InputStreamReader;
import java.io.IOException;

// Program to read characters on standard input, counting
// how many words that contains and reports number on its
// standard output.

public class WordCount
{
  public static void main(String [] args)
  {
    // there are 65536 different character values (2 bytes)
    // This array will already be set to zero in each element.
    int[] characterCount = new int[65536];
    
    
    // we will read the input as characters.
    InputStreamReader input = new InputStreamReader(System.in);
    
    // the number of words found so far.
    int allCharactersCount = 0;
    
    try
    {
      int currentCharacter;
      while ((currentCharacter = input.read()) != -1)
      {
        allCharactersCount++;
	characterCount[currentCharacter]++;
      }
    }
    
   
    
    catch (IOException exception)
    {
      System.err.println(exception);
    }
    
    finally
    {
      try { input.close(); }
      catch (IOException exception)
        { System.err.println("could not close input " + exception); }
    }
    
    boolean wasWhiteSpace = false;
    boolean isWhiteSpace = false;
    int wordCount=0;
    int charCount=0;
    int currentChar;
    while ((currentChar = input.read()) != -1) 
    {
      //Counting chars
      charCount++;

     //Counting words
     isWhiteSpace = Character.isWhitespace((char)currentChar);
     if(isWhiteSpace && !wasWhiteSpace) 
     wordCount++;
     wasWhiteSpace = isWhiteSpace;
    }
    System.out.println("the number of words read was " + wordCount);
    
  }
}

This is the error i get.

javac WordCount.java
WordCount.java:52: unreported exception java.io.IOException; must be caught oreclared to be thrown
while ((currentChar = input.read()) != -1)

kind regards

Shyam

[subith86]

Oh dear Shyam, what did you do... !!! Use some common sense.
REPLACE your while loop with the one I provided. Not adding it at a later stage after try-catch.

[KevinWorkman]

Further evidence that spoonfeeding is not helping...

[Shyamz1]

thank you all so much. I appreciate your help.

:)

Kind regards

Shyam