finding average in 2d arrays

[the beginner]

im trying to find the average of the high temprature and return it..

import java.util.*;

public class Chap9Ex12p589
{
	static Scanner console  = new Scanner(System.in);
	
	public static void main(String[] args)
	{
		int[][] temperature = {{50,16},{47,-2},{65,35},{68,41},{73,50},
										{81,66},{93,73},{101,82},{90,75},
										{75,60},{67,53},{56,38}};
										
		printTemp(temperature);						
									
		avgHighTemp(temperature);							
	}//end main
	
	//method
	public static void printTemp(int[][] temp)
	{
		for (int high = 0; high < temp.length; high++)
		{
			for (int low = 0; low < temp[high].length; low++)
				System.out.printf("%7d", temp[high][low]);
				
			System.out.println();
		}
	}
	
	public static int avgHighTemp(int[][] temp)
	{
		int sum =0;
	 	double avg= 0;
		
		for (int high = 0; high < temp[0].length; high++)
		{
			sum = 0;
			for (int low = 0; low < temp.length; low++)
				sum += temp[high][low];

		}

                          avg = sum / temp.length
		System.out.println("The average of the high temperature is " + String.format("%.2f", avg));

		return avg;
	}
	
}//end class

[al_Marshy_1981]

Great stuff, and your question/problem is?

[the beginner]

in this method im trying to find the average of the high temperature. i compile it and getting an error

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 2
at Chap9Ex12p589.avgHighTemp(Chap9Ex12p589.java:43)
at Chap9Ex12p589.main(Chap9Ex12p589.java:18)

	public static int avgHighTemp(int[][] temp)
	{
		int sum =0;
	 	double avg= 0;
		
		for (int high = 0; high < temp[0].length; high++)
		{
			sum = 0;
			for (int low = 0; low < temp.length; low++)
				sum += temp[high][low]; [U]//this might be where my problem is[/U]

		}

                          avg = sum / temp.length
		System.out.println("The average of the high temperature is " +  avg);

		return avg;
	}

[al_Marshy_1981]

That certainly is a problem, not your only one though. How many columns does your 2d array have? Why are you getting a number 2 with the ArrayOutOfBounds exception?. Try to answer these questions.

int[][] temperature = {{50,16},{47,-2},{65,35},{68,41},{73,50},
{81,66},{93,73},{101,82},{90,75},{75,60},{67,53},{56,38}};

for (int high = 0; high < temp[0].length; high++)
		{
			sum = 0;
			for (int low = 0;[COLOR="DarkOrange"] low < temp.length[/COLOR]; low++)
				sum += temp[high][low]; //this might be where my problem is

		}

[/CODE]

[the beginner]

there is one inside the main and the avghightemp method.

i have 12 rows and 2 columns. first column is the high temp and the second is low temp...

[al_Marshy_1981]

What value is temp.length?

[Junky]

i have 12 rows and 2 columns.

But you are iterating over the array columns first and then rows. Perhaps if you renamed the high and low variables as row and column it might by more evident what your problem is.

[the beginner]

i changed that to 12 :) i forgot to changed it when i posted it.

[Junky]

Changed what to 12? Did you solve your problem?

[the beginner]

[code]
public static int avgHighTemp(int[][] temp)
{
int sum;
int avg= 0;

for (int col = 0; col < temp[0].length; col++)
{
sum = 0;
for (int row = 0; row < temp.length; row++)
sum += temp[row][col];

avg = sum / temp.length;
}


return avg;
}

[\code]

thanks for the help al_Marshy_1981 and junky

[al_Marshy_1981]

That method will not give you an average

[the beginner]

it didn't give me a right num :)

[Junky]

So work out why it doesn't. Try adding a bunch of print statements at various points so you can see what values your variables have. Hopefully one (or more) of them will jump out at you and you say "Why is it X when it should be Y?"

[the beginner]

i printed out my sum and it prints both of sum of my columns.. the avg pickin up the last sum which is my low temp(2nd col) instead the first col that was why i have the wrong avg..

thanks.. ill work on it

[the beginner]

	public static int avgHighTemp(int[][] temp)
	{
		int sum = 0;
	 	int avg= 0;
		
		for (int col = 0; col < temp[0].length; col++)
		{
			sum = 0;
			for (int row = 0; row < temp.length; row++)
					sum += temp[row][0];
					
					System.out.println(sum);
		}
		
		avg = sum / temp.length;
		return avg;
	}

now im getting the right output

     50     16
     47     -2
     65     35
     68     41
     73     50
     81     66
     93     73
    101     82
     90     75
     75     60
     67     53
     56     38
866
866      [U]//IT WAS 587 THE SUM OF MY 2ND COLUMN[/U]
The average of the high temperature is 72

sum += temp[row][0];

can u tell me why the [0] has zero instead of [col] ??? i just didnt get it, if u dont mind... it's ok if u dont feel like it...

thankz :)

[al_Marshy_1981]

Because highest temperatures were stored in column 1 of your array, but array access starts its count from 0. So 0 = column 1. The way you accessed the array was unconventional though.

[Junky]

sum += temp[row][0];

This still does not produce the correct answer. All you code does now is tally the first column row number of times.

Oops!

Misunderstood. I thought you were trying to average all the temperatures. If all you want is the high temps in the left column then you don't need nested loops. A single loop is all you need.

[the beginner]

@al: thanks and how can i make it simple?

@junky: it did give me the right answer and all i need to sum up is the first col

my code is not that professional... that is why im here for additional lecture :)

[the beginner]

and i appreciate y'all