How to combine Buttons and threads

[jnms]

I want to make an app with two buttons. With the start button I want to start something (System.out.println(" " + i); print a lot of numbers ) and with the stop button I want to be able to stop it
I made the following script. But the print100.interrupt(); does not stop the thread.

What am I doing wrong?

package testactionevent;

import javax.swing.*;
import java.awt.*;
import java.awt.event.*;

/**
 *
 * @author
 */
public class TestActionEvent extends JFrame implements ActionListener{
    private JButton jbtStart = new JButton("Start");
    private JButton jbtStop = new JButton("Stop");

public TestActionEvent(){
    setTitle("TestActionEvent");

    getContentPane().setLayout(new FlowLayout());
    getContentPane().add(jbtStart);
    getContentPane().add(jbtStop);

    jbtStart.addActionListener(this);
    jbtStop.addActionListener(this);
}
    /**
     * @param args the command line arguments
     */
    public static void main(String[] args) {
        TestActionEvent frame = new TestActionEvent();
        frame.setTitle("Two buttons");
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        frame.setSize(100, 100);
        frame.setVisible(true);
    

}

    public void actionPerformed(ActionEvent e){
        if (e.getSource() == jbtStart){
            Thread print100 = new Thread(new SiThread(10000));
            print100.start();
            print100.interrupt();
        }
        else if (e.getSource() == jbtStop){
            print100.interrupt();
        }
    }
}
    
class SiThread implements Runnable {
    private int lastNum;
    public SiThread(int n){
        lastNum = n;
    }

    public void run() {
        for (int i = 0; i <= lastNum; i++) {
            System.out.println(" " + i);
    }
}
}

[al_Marshy_1981]

public void actionPerformed(ActionEvent e){
      if (e.getSource() == jbtStart){
          Thread print100 = new Thread(new SiThread(10000));
          print100.start();
          print100.interrupt();
      }
      else if (e.getSource() == jbtStop){
         print100.interrupt();
       }
}

That else if has no idea about print100 as it is local to the if statement above it.
Also you are not testing the thread for an interruption in void run()

Have a read here:
Interrupts (The Java™ Tutorials > Essential Classes > Concurrency)

[jnms]

After reading your link for concurrency, I changed the class like this.
But I don't understand the local print100. Can I change that to a non local? If so how and where?

class SiThread implements Runnable {
    private int lastNum;
    public SiThread(int n){
        lastNum = n;
    }

    public void run() {
        for (int i = 0; i <= lastNum; i++) {
            System.out.println(" " + i);
              if (Thread.interrupted()) {
        return;
    }
    }
}
}

[jnms]

I changed it to. But this does not stop the thread.
Please advise.:confused:

 public void actionPerformed(ActionEvent e){
        Thread print100 = new Thread(new SiThread(10000));
        if (e.getSource() == jbtStart){
           
            print100.start();
        }
        else if (e.getSource() == jbtStop){

            print100.interrupt();
        }
    }

[jnms]

I think this does the trick. I moved the "Thread print100 = new Thread(new SiThread());"

/*
 * To change this template, choose Tools | Templates
 * and open the template in the editor.
 */

package testactionevent;

import javax.swing.*;
import java.awt.*;
import java.awt.event.*;

/**
 *
 * @author
 */
public class TestActionEvent extends JFrame implements ActionListener{
    private JButton jbtStart = new JButton("Start");
    private JButton jbtStop = new JButton("Stop");
    Thread print100 = new Thread(new SiThread());

public TestActionEvent(){

    setTitle("TestActionEvent");

    getContentPane().setLayout(new FlowLayout());
    getContentPane().add(jbtStart);
    getContentPane().add(jbtStop);

    jbtStart.addActionListener(this);
    jbtStop.addActionListener(this);
}
    /**
     * @param args the command line arguments
     */
    public static void main(String[] args) {

        TestActionEvent frame = new TestActionEvent();
        frame.setTitle("Two buttons");
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        frame.setSize(100, 100);
        frame.setVisible(true);
}

    public void actionPerformed(ActionEvent e){
        
        if (e.getSource() == jbtStart){
           
            print100.start();
        }
        else if (e.getSource() == jbtStop){

            print100.interrupt();
        }
    }
}
    
class SiThread implements Runnable {
    public void run() {
        boolean lopend = false;
        int num =0;
        System.out.println(" " + num);
        while (lopend == false){
            num = num +1;
            System.out.println(" " + num);
            if (Thread.interrupted()) {
                return;
            }
        }
    }
}

[jnms]

I am sorry. The script can start and stop, but I get an error when I try to restart it again.
Any suggestions?

[al_Marshy_1981]

Yeah, post the EXACT error

[jnms]

Think it's solved.
:)

/*
 * To change this template, choose Tools | Templates
 * and open the template in the editor.
 */

package testactionevent;

import javax.swing.*;
import java.awt.*;
import java.awt.event.*;

/**
 *
 * @author
 */
public class TestActionEvent extends JFrame implements ActionListener{
    private JButton jbtStart = new JButton("Start");
    private JButton jbtStop = new JButton("Stop");
    SiThread draadje;

public TestActionEvent(){
    draadje = new SiThread();
    setTitle("TestActionEvent");

    getContentPane().setLayout(new FlowLayout());
    getContentPane().add(jbtStart);
    getContentPane().add(jbtStop);

    jbtStart.addActionListener(this);
    jbtStop.addActionListener(this);
}
    /**
     * @param args the command line arguments
     */
    public static void main(String[] args) {
        

        TestActionEvent frame = new TestActionEvent();
        frame.setTitle("Two buttons");
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        frame.setSize(100, 100);
        frame.setVisible(true);
}

    public void actionPerformed(ActionEvent e){

        if (e.getSource() == jbtStart){

            Thread thread = new Thread(draadje);
            thread.start();
        }
        else if (e.getSource() == jbtStop){
            draadje.stop();
        }
    }
}

class SiThread implements Runnable {
    int i = 0;
    boolean lopend = false;

    public void run() {
        lopend = true;
        while (lopend){
            try {
                Thread.sleep(10);
            } catch (InterruptedException ex){
                ex.printStackTrace();
            }
           i++;
           System.out.println(i);
        }
    }

    public void stop(){
        lopend = false;
    }
}