Issue with deployment script when if statement/filter not valid

[pi4r0n]

Hello everyone

Can I ask you for you assistance please. Before I start let me give you a brief description what I am doing.

I am working on deployment script which will:

1. Scan my folder (see below) for a list of folders and store it in ArrayList,
   String buildsLocation = "\\\\10.10.10.10\\Development\\1.0\\v0\\alpha" ;
   
   
   Folder example=
   old
   410
   411
   415
   420
   
   
2. then it will get the myListOfDirectoryArray ArrayList index and scan each folder to check whether the build is valid (must have minimum these 2, see exe64IsThere and exe32IsThere ) and save it to a validBuildsList ArrayList
   
   String exe64IsThere = ("Build 1.0.0." + availableBuilds + "(Win-x64)"); e.g,
   String exe32IsThere = ("Build 1.0.0." + availableBuilds + "(Win-x32)");
   
   
   Folder example:-
   Valid folder: 415 with 2 files (Build 1.0.0.415 (Win-x64) and Build 1.0.0.415 (Win-x32))
   Not valid: 420 with 1 file Build 1.0.0.415 (Win-x64) only
   
   
3. when when build is valid (got these 2 files from above) then return string if not it should go back and check the latest valid build / folder which is valid
   

The problem I have got is that the script works fine if there are these 2 files, but as soon as there is only 1 file lets say 64 I got NullPointException -1 :(

Can someone advice what I am doing wrong please ??

package deplaysqlmarinamasterscriptv2;

import java.io.*;
import java.util.*;

/**
 *
 * @author arek.jarosiewicz
 */
public class Build {

    /**
     * This will scan myserver for a the latest build
     * @return build number (latestBuildNumber)
     */
    public static String getLatestBuildNumber() {

        String buildsLocation = "\\\\10.10.10.10\\Development\\1.0\\v0\\alpha";
        
        File dir = new File(buildsLocation);
        File listDir[] = dir.listFiles();

        String latestBuildNumber = "";
        String availableBuilds = "";

        ArrayList<String> myListOfDirectoryArray = new ArrayList<String>();
        ArrayList<String> validBuildsList = new ArrayList<String>();

        for (int i = 0; i < listDir.length; i++) {

            if (listDir[i].isDirectory()) {

                availableBuilds = listDir[i].getName();

                if (!(availableBuilds.equals("old"))) {

                    myListOfDirectoryArray.add(availableBuilds);

                    File subFolder = new File(buildsLocation + "\\" + availableBuilds);
                    File filesList[] = subFolder.listFiles();

                    for (int k =0; k < filesList.length; k++)
                    {
                        String strFile = filesList[k].getName();
                        String exe64IsThere = ("Build 1.0.0." + availableBuilds + "(Win-x64)");
                        String exe32IsThere = ("Build 1.0.0." + availableBuilds + "(Win-x32)");

                        if (strFile.contains(exe64IsThere) || strFile.contains(exe32IsThere))
                        {
                            validBuildsList.add(availableBuilds);
                        }
                    }
                }
            }
        }
        Collections.sort(validBuildsList);

        latestBuildNumber = validBuildsList.get(validBuildsList.size() - 1);
        return latestBuildNumber;
    }
}

[pbrockway2]

as there is only 1 file lets say 64 I got NullPointException -1

Please copy and post the entire stack trace. It will refer to some line number in Build.java and it is a good idea to say which line (of the code you posted) corresponds to that number.

[pi4r0n]

Here you go pbrockway2. I think its refernig to this line latestBuildNumber = validBuildsList.get(validBuildsList.size() - 1);

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: -1
        at java.util.ArrayList.get(ArrayList.java:324)
        at deplaysqlmarinamasterscriptv2.Build.getLatestBuildNumber(Build.java:58)
        at deplaysqlmarinamasterscriptv2.Main.main(Main.java:23)
Java Result: 1

[al_Marshy_1981]

It would appear that validBuildsList.size() is equal to 0 when you reach that line, ArrayIndexOutOfBoundsException: -1 is the exception;

validBuildsList.size()-1 = -1 , when validBuildsList.size() = 0.

[pi4r0n]

Thanks al_Marshy_1981 for your tip I managed to fix it on the end.

The problem I had was that I trying to check whether strFile.contains(exe64IsThere) where exe64IsThere was declared as String and contains returns boolean :)

    public static String getLatestMarinaBuildNumber() {

        String buildsLocation = "\\\\10.10.10.10\\Development\\1.0\\v0\\alpha";
        //String buildsLocation = "C:/Alpha";

        File dir = new File(buildsLocation);
        File listDir[] = dir.listFiles();

        String latestBuildNumber = "";
        String availableBuilds = "";

        ArrayList<String> myListOfDirectoryArray = new ArrayList<String>();
        ArrayList<String> listOfFilesArray = new ArrayList<String>();
        ArrayList<String> validBuildsList = new ArrayList<String>();


		for (int i = 0; i < listDir.length; i++) {

            if (listDir[i].isDirectory()) {

                if (!(availableBuilds.equals("old"))) {
                    availableBuilds = listDir[i].getName();

                    File subFolder = new File(buildsLocation + "\\" + availableBuilds);
                    File[] filesList = subFolder.listFiles();

                    for (int k = 0; k < filesList.length; k++) {
                        listOfFilesArray.add(filesList[k].getName());
                    }

                    boolean found64bit = listOfFilesArray.contains("Build 1.0.0." + availableBuilds + " (Win-x64).exe");
                    boolean found32bit = listOfFilesArray.contains("Build 1.0.0." + availableBuilds + " (Win-x86).exe");

                    if (found64bit && found32bit) {
                        myListOfDirectoryArray.add(availableBuilds);
                    } else {
                        myListOfDirectoryArray.remove(availableBuilds);
                    }
                }
            }
            Collections.sort(validBuildsList);
                       
        }

        latestBuildNumber = myListOfDirectoryArray.get(myListOfDirectoryArray.size() - 1);

        return latestBuildNumber;
    }

Cheers

pi4r0n