Java method that check brackets in String are matched?

[neonz]

How to write balancedBracketsByCounting(String s), as follows, that takes a string as an input and checks whether the brackets "[", "]", "(", and ")" in the string are matched correctly?

balancedBracketsByCounting("[x][[xy]]") would return True.
balancedBracketsByCounting("[[x[y]]") would return False.

Do we need to use Stack and Queue in our program?

Please assist, thanks.

[Tolls]

Count them?

[JosAH]

Count them?

Just counting them won't work if several types of brackets need to be checked, e.g. [({)}] is an incorrect pattern although the count of those brackets shows everything is fine; a simple stack is needed.

kind regards,

Jos

[Tolls]

Oh.
Different ones in the same string.
I was going by the OPs example...counting would work well enough there.
:)

[JosAH]

Oh.
Different ones in the same string.
I was going by the OPs example...counting would work well enough there.
:)

Yep, counting works fine for the special case of one type of parentheses but I, of course, generalized the whole thing to several types of brackets again ;-)

kind regards,

Jos

[Ruuhkis]

boolean brackets(String string, char start, char end){
boolean check = false;
boolean isBalance = true;
for(char x: string.toCharArray()){
if(x == start && !check){
check = true;
}else if(x == start && check){
isBalance = false;
}else if(x == end && !check){
isBalance = false;
}else if(x == end && check){
check = false;
}
}
return isBalance;
}

and for usage

brackets("(thisisTest)", '(', ')');

[JosAH]

and for usage

... try this:

brackets("((thisisTest))", '(', ')');

That algorithm doesn't work.

kind regards,

Jos

[Tolls]

A spoonfeed that doesn't work?
Who'd have thought it, eh?
:)

[JosAH]

A spoonfeed that doesn't work?
Who'd have thought it, eh?
:)

Nothing surprises me anymore here ;-)

kind regards,

Jos

[neonz]

Count them?

Sorry to have confuse you with the method name, the main idea/ goal is to test if the brackets that is found in the String are matched correctly.

[neonz]

Just counting them won't work if several types of brackets need to be checked, e.g. [({)}] is an incorrect pattern although the count of those brackets shows everything is fine; a simple stack is needed.

kind regards,

Jos

Thanks Josah for enlightenment ...

Does this work?

=========================================

import java.util.*;

public class balancedBraces
{
public boolean balancedBracesMethod (String s)
{
int myLength = s.length();
Stack st = new Stack();
char d;

for (int i=0;i<s.length();i++)
{
char c = s.charAt(i);
if (c == '(')
{
st.push(new Character(c));
}
else if (c == '[')
{
st.push(new Character(c));
}
else if (c == ')')
{
if (st.empty() == true)
{
return false;
}
else if (st.empty() == false)
{
d = (Character) st.pop();
if (d != '(')
{
return false;
}
}
}
else if (c == ']')
{
if (st.empty() == true)
{
return false;
}
else if (st.empty() == false)
{
d = (Character) st.pop();
if (d != '[')
{
return false;
}
}
}
}

return true;
}
}

[Tolls]

Use code tags for starters.

Also wouldn't it be easier for you to actually run this with some test code than ask us to read through it and try and spot mistakes?

I will say that:

if (st.empty() == true)
{
...
}
else if (st.empty() == false)
{
...
}

should be:

if (st.empty())
{
...
}
else
{
...
}

Comparing a boolean to true or false is is unecessary,

[neonz]

Use code tags for starters.

Also wouldn't it be easier for you to actually run this with some test code than ask us to read through it and try and spot mistakes?

I will say that:

if (st.empty() == true)
{
...
}
else if (st.empty() == false)
{
...
}

should be:

if (st.empty())
{
...
}
else
{
...
}

Comparing a boolean to true or false is is unecessary,

True, point taken ... If (condition in loop is true), then the If loop will work.

[neonz]

public static void main (String args [])
{
String s = "( [ ] )";
boolean result = balancedBracesMethod (s);
System.out.print(result);
}

Have done this test with String s used.
Program seems to be working fine.

)([] return false
[()()] return true
[)()(] return false
()][ return false

Result return are expected.

[KevinWorkman]

Crossposted: balancedBracketsByCounting (String s) that checks brackets are matched in the String.

[neonz]

Crossposted: balancedBracketsByCounting (String s) that checks brackets are matched in the String.

Sorry, was trying to get fast response and resolve the problem.

Another testing done. This time round is smooth testing. All the way test by entering new figure instead of hard-coding ...

public static void main (String args [])
{
while(true)
{
BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
System.out.println("Enter test data: ");
try
{
String input = reader.readLine();
boolean result = balancedBracesMethod (input);
System.out.println(result);
}
catch (IOException e)
{
System.out.println("An unexpected error occured.");
}
}
}

Hope I can get feed back on improving the program code, and make improvement.

[neonz]

Latest program:

[highlight=Java]
import java.util.*;
import java.io.*;

public class balancedBraces
{
public static boolean balancedBracesMethod (String s)
{
int myLength = s.length();
Stack st = new Stack();
char d;

for (int i=0;i<s.length();i++)
{
char c = s.charAt(i);

if (c == '(')
{
st.push(new Character(c));
}
else if (c == '[')
{
st.push(new Character(c));
}
else if (c == '{')
{
st.push(new Character(c));
}

else if (c == ')')
{
if (st.empty())
{
return false;
}
else
{
d = (Character) st.pop();
if (d != '(')
{
return false;
}
}
}
else if (c == ']')
{
if (st.empty())
{
return false;
}
else
{
d = (Character) st.pop();
if (d != '[')
{
return false;
}
}
}
else if (c == '}')
{
if (st.empty())
{
return false;
}
else
{
d = (Character) st.pop();
if (d != '{')
{
return false;
}
}
}
}

if (st.empty()) return true;
else return false;
}

public static void main (String args [])
{
boolean test = true;
while(test)
{
BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
System.out.println("Enter test data: ");
try
{
String input = reader.readLine();
boolean result = balancedBracesMethod (input);
System.out.println(result);
}
catch (IOException e)
{
System.out.println("An unexpected error occured.");
}
}
}
}
[/highlight]

Please help to comment and check if there any problem.

Cross-posted: balancedBracketsByCounting (String s) that checks brackets are matched in the String.

[JosAH]

Latest program:

[highlight=Java]
[ ... ]
Cross-posted: balancedBracketsByCounting (String s) that checks brackets are matched in the String.

I can see that; the highlight tag is a valid tag in the other forum ;-)

kind regards,

Jos

[neonz]

Hi JosAH and KevinWorkman,

Any problem with my above mini-java program?

I have been fine-tuning it, to the last version alry.

Any other way to code the java program such that it is shorter or more efficient?

Please assist, thanks.

So far no one really got back to me on the java program, if there is any error any where, please do tell me.

Thank.

[neonz]

Hope someone will take a look and help comment to see if everything work fine.
Thanks, been a few days already and no one commented or reply.

Thanks for all comment and reply.