Error: ArrayIndexOutOfBoundsException. Where is the problem?

[ArticRoot]

Hi

I get the following error when running my program (JTS):

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 13
at NewProj.main(NewProj.java:53)

I really can't figure out how to solve this. I've tried a hundred different aproaches. Would really appriciate som help.

import com.vividsolutions.jts.geom.*;
public class NewProj {
    public static void main(String[] args){
	
	Coordinate[] coordinatesToLine = new Coordinate[] {
	    new Coordinate(12, 2),
	    new Coordinate(12, 13),
	    new Coordinate(12, 19), 
	    new Coordinate(19, 19), 
	    new Coordinate(20, 20),
	    new Coordinate(25, 25),
	    new Coordinate(27, 18)
	};
	
	LineString FirstLine = new GeometryFactory().createLineString(coordinatesToLine);
	
	Point pointOne, pointTwo;
	double dist;
	int newLineLength = FirstLine.getNumPoints();
	double newCoorX, newCoorY;
	Coordinate newCoor;
	int points2Add;
	
	
	for (int counter=1; counter <= FirstLine.getNumPoints()-1;counter++){
	    pointOne = FirstLine.getPointN(counter-1);
	    pointTwo = FirstLine.getPointN(counter);
	    dist = pointOne.distance(pointTwo);
	   	newLineLength = newLineLength + (int)(dist / 5);
	   	}
		
	Coordinate[] newCoordinates = new Coordinate[newLineLength];
	newCoordinates[0] = FirstLine.getCoordinateN(0);
	
	int newLineCounter=1;
	for (int counter=1; counter <= FirstLine.getNumPoints()-1;counter++){
	    pointOne = FirstLine.getPointN(counter-1);
	    pointTwo = FirstLine.getPointN(counter);
	    dist = pointOne.distance(pointTwo);
	   	newLineLength = newLineLength + (int)(dist / 5);
	  
	   	for (int x=1; x <= newLineLength; x++){
		dist = pointOne.distance(pointTwo);
		points2Add = (int)(dist / 5);
		 if ( points2Add > 0 ){
			 for ( int i=1 ; i <= points2Add ; i++ ){
				 newCoorX = pointOne.getX() + ((double)i / ( (double)points2Add + 1)) * (pointTwo.getX() - pointOne.getX());
				 newCoorY = pointOne.getY() + ((double)i / ( (double)points2Add + 1)) * (pointTwo.getY() - pointOne.getY());
				 newCoor = new Coordinate(Math.round(newCoorX), Math.round(newCoorY));
				 newCoordinates[newLineCounter] = newCoor;
				 newLineCounter++;
			 }
		 }
		 
	}
	     newCoordinates[newLineCounter] = FirstLine.getCoordinateN(counter);
		 newLineCounter++;
			     
	}
	  LineString SecondLine = new GeometryFactory().createLineString(newCoordinates);
	 
	 System.out.println("oldline " +  FirstLine);
	 System.out.println("newline " +  SecondLine);
    }
}

[Petr]

This is exception to say that you out of bounds in arrays.
for example you tried get element with index the more then size array.
for example

String[] mass = new String[3];
//do something with array
String value = mass[4]; // thwor example java.lang.ArrayIndexOutOfBoundsException

PS. Forum it is not debug tool. You need to ask special questions.

[ArticRoot]

Thank's for your reply Petr.

I understand the meaning of the exception, but I don't see what in my code that is wrong...

[Petr]

Where Is found this line 13 in your code?

[ArticRoot]

Where Is found this line 13 in your code?

I don't understand what you mean?

The error at line 53:

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 13
at NewProj.main(NewProj.java:53)

is:

newCoordinates[newLineCounter] = newCoor;

[Petr]

Well it is very difficult find mistake in your code. Can you post full code, which I can run.

[ArticRoot]

Yeah, I know:)

Full code:

import com.vividsolutions.jts.geom.*;
public class NewProj {
    public static void main(String[] args){
	
	Coordinate[] coordinatesToLine = new Coordinate[] {
	    new Coordinate(12, 2),
	    new Coordinate(12, 13),
	    new Coordinate(12, 19), 
	    new Coordinate(19, 19), 
	    new Coordinate(20, 20),
	    new Coordinate(25, 25),
	    new Coordinate(27, 18)
	};
	
	LineString FirstLine = new GeometryFactory().createLineString(coordinatesToLine);
	
	Point pointOne, pointTwo;
	double dist;
	int newLineLength = FirstLine.getNumPoints();
	double newCoorX, newCoorY;
	Coordinate newCoor;
	int points2Add;
	
	
	for (int counter=1; counter <= FirstLine.getNumPoints()-1;counter++){
	    pointOne = FirstLine.getPointN(counter-1);
	    pointTwo = FirstLine.getPointN(counter);
	    dist = pointOne.distance(pointTwo);
	   	newLineLength = newLineLength + (int)(dist / 5);
	   	}
		
	Coordinate[] newCoordinates = new Coordinate[newLineLength];
	newCoordinates[0] = FirstLine.getCoordinateN(0);
	
	int newLineCounter=1;
	for (int counter=1; counter <= FirstLine.getNumPoints()-1;counter++){
	    pointOne = FirstLine.getPointN(counter-1);
	    pointTwo = FirstLine.getPointN(counter);
	    dist = pointOne.distance(pointTwo);
	   	newLineLength = newLineLength + (int)(dist / 5);
	  
	   	for (int x=1; x <= newLineLength; x++){
		dist = pointOne.distance(pointTwo);
		points2Add = (int)(dist / 5);
		 if ( points2Add > 0 ){
			 for ( int i=1 ; i <= points2Add ; i++ ){
				 newCoorX = pointOne.getX() + ((double)i / ( (double)points2Add + 1)) * (pointTwo.getX() - pointOne.getX());
				 newCoorY = pointOne.getY() + ((double)i / ( (double)points2Add + 1)) * (pointTwo.getY() - pointOne.getY());
				 newCoor = new Coordinate(Math.round(newCoorX), Math.round(newCoorY));
				 newCoordinates[newLineCounter] = newCoor;
				 newLineCounter++;
			 }
		 }
		 
	}
	     newCoordinates[newLineCounter] = FirstLine.getCoordinateN(counter);
		 newLineCounter++;
			     
	}
	  LineString SecondLine = new GeometryFactory().createLineString(newCoordinates);
	 
	 System.out.println("oldline " +  FirstLine);
	 System.out.println("newline " +  SecondLine);
    }
}

[Petr]

It is not full code. What is that Coordinate, LineString, Point. Where Can i find this classes?

[ArticRoot]

Sorry about that Petr.

I'm using Java Topology Suit (JTS). See these links for the classes:
Coordinate
Point
LineString

All geom* objects:
com.vividsolutions.jts.geom

[goldest]

for (int x=1; x <= newLineLength; x++){ [COLOR="Magenta"]//newLineLength = 15[/COLOR]
dist = pointOne.distance(pointTwo); [COLOR="Magenta"]//dist = 11.0[/COLOR]
points2Add = (int)(dist / 5);
 if ( points2Add > 0 ){ [COLOR="Magenta"]//points2Add = 2[/COLOR]
.......
newLineCounter++;

The piece of code above is a bit weird. See comments... The loop tries to iterate 15 times, inside which your if statement always increases the newLineCounter twice. And later on you are trying to access the array index based on the same newLineCounter.

Your original array is defined for 13 elements max,

Coordinate[] newCoordinates = new Coordinate[newLineLength]; [COLOR="Magenta"]//newLineLength = 13[/COLOR]

Your newLineCounter is exceeding that limit. Try to put some print statements on your own to see what's exactly happening.

Goldest

[ArticRoot]

Goldest & Petr: Thanks for your efforts. Really appriciate it.
If anyone, for any reason, is interested in the solution, here it goes:

import com.vividsolutions.jts.geom.*;
public class NewProj {
    public static void main(String[] args){
	Coordinate[] coordinatesToLine = new Coordinate[] {
	    new Coordinate(12, 2),
	    new Coordinate(12, 13),
	    new Coordinate(12, 19), 
	    new Coordinate(19, 19), 
	    new Coordinate(20, 20),
	    new Coordinate(25, 25),
	    new Coordinate(27, 18)
	};
	
	LineString FirstLine = new GeometryFactory().createLineString(coordinatesToLine);
	Point pointOne, pointTwo;
	double dist;
	int newLineLength = FirstLine.getNumPoints();
	double newCoorX, newCoorY;
	Coordinate newCoor;
	int points2Add;
	
	for (int counter=1; counter <= FirstLine.getNumPoints()-1;counter++){
	    pointOne = FirstLine.getPointN(counter-1);
	    pointTwo = FirstLine.getPointN(counter);
	    dist = pointOne.distance(pointTwo);
	    newLineLength = newLineLength + (int)(dist / 5);//here new number of points are added
	    }
		
	
	 Coordinate[] newCoordinates = new Coordinate[newLineLength];
	 newCoordinates[0] = FirstLine.getCoordinateN(0);
	
	 
	 int newLineCounter=1;
	 for (int counter=1 ; counter <= FirstLine.getNumPoints()-1 ; counter++){
		    pointOne = FirstLine.getPointN(counter-1);
		    pointTwo = FirstLine.getPointN(counter);
		    dist = pointOne.distance(pointTwo);
		    points2Add = (int)(dist / 5);
		    if ( points2Add > 0 ){
		    	for ( int i=1 ; i <= points2Add ; i++ ){
		    		newCoorX = pointOne.getX() + ((double)i / ( (double)points2Add + 1)) * (pointTwo.getX() - pointOne.getX());
		    		newCoorY = pointOne.getY() + ((double)i / ( (double)points2Add + 1)) * (pointTwo.getY() - pointOne.getY());
		    		newCoor = new Coordinate(Math.round(newCoorX), Math.round(newCoorY));
		    		newCoordinates[newLineCounter] = newCoor;
		    		newLineCounter++;
		    	}
		    }
		    newCoordinates[newLineCounter] = FirstLine.getCoordinateN(counter);
		    newLineCounter++;
	 }
	  
	LineString SecondLine = new GeometryFactory().createLineString(newCoordinates);
	 	
	System.out.println("oldline " +  FirstLine);
	System.out.println("newline " +  SecondLine);

    }
}

[goldest]

Good to know that you reached to the solution. Cheers :)

Goldest