Whats wrong with this tiny method?

[N00Bie]

I am getting a null pointer exception with this:

	 private int getRadioValue() {
		 boolean b;
		 b = 	radio1.isSelected();
		 
		   if(b==true)
	            return 1;
	        else
	            return 2;
		}

I can post the entire program if you want, its about 220 lines...

[toadaly]

'radio1' is null.

[Fubarable]

It should be obvious that radio1 is null. Now trace back in your program to see why.

[N00Bie]

Thanks!
Was calling it in the constructor before I created it...

It should be obvious...

< 10th day of Java, nothing is obvious... total newb :)

[Fubarable]

Thanks!
Was calling it in the constructor before I created it...


< 10th day of Java, nothing is obvious... total newb :)

It will become obvious then. It was the only reference variable in the code above so it must be the one causing the problem. But next time, you should be able to know which line causes the error and then you will know in a second which variable is null.

[gcalvin]

You weren't asking about this, but consider this alternative code:

	 private int getRadioValue() {
		if (radio1.isSelected())
			return 1;
		else
			return 2;
	}

And since you're just getting started, get in the habit of doing this:

	 private int getRadioValue() {
		if (radio1.isSelected()) [COLOR="Blue"]{[/COLOR]
			return 1;
		[COLOR="Blue"]}[/COLOR] else [COLOR="Blue"]{[/COLOR]
			return 2;
		[COLOR="Blue"]}[/COLOR]
	}

Those extra braces will save you some tear-your-hair-out frustration someday, when you add an extra line of code and can't figure out why it breaks everything.

-Gary-

[N00Bie]

Fubarable, ok - but the errors still confuse me as they dont say wahts wrong in plain English. Will get used to it with expereince I guess.

gcalvin,
Good advise! I'm coming from PHP and I usually do that...just took a shortcut today ;)