help with loop. yes no

[glina126]

[RESOLVED!] :) thank you!!


Hey! I'm new to the forum but i recently started learning Java. If anyone could point me in the right direction here i would appreciate it!

// asks user to enter yes, if user does not input yes program loops 
// wile loop style

import java.util.Scanner;

public class Test1

{
	public static void main(String[] args)
	
	{
		String repeat;
		
		Scanner keyboard = new Scanner(System.in);
		
		System.out.println("Enter Yes to continue");
			repeat = keyboard.nextLine();
		
		while (repeat != 'Yes')
		{
			System.out.println("Enter Yes continue");
			repeat = keyboard.nextLine();
		}
		
	}
}

what am i doing wrong? :confused:

[pbrockway2]

Don't use != to compare Strings (or any other objects) use equals() or !equals().

equals() is a method declared for class Object but other classes define their own version to mean what makes sense for them. In the case of String there is an equals() that means "is made up of the same characters in the same order".

[pbrockway2]

Oh and you can't use single quotes for String literals.

So,

while (!repeat.equals("Yes"))
    {
        // etc

[glina126]

thanks so much!!!!!!!!!! i like the quick help and great responses! :D thanks!!!

[pbrockway2]

You're welcome.

(and welcome to the forum!) Just a tip: if you compile (and you should compile often...) and get a message you can't understand, post the entire compiler message. This would have alerted me to the single quotes. Likewise, *describe* the problem ie say what the undesired program behaviour is. ("doesn't stop when I enter Yes").

Programmers are very literal minded and like to be given the facts. (even the obvious ones). But there is another reason for being precise and specific: I find with the mistakes that I make that I am often closer to figuring out an answer when I have asked *myself* a precise and specific question. Being able to frame such questions (and doing so is neither easy nor natural) is a good problem solving technique.

(this rant/musing is not directed at you specifically - it just occured to me when I reread your original post and I thought would express it for the benefit - or otherwise - of all ;)

Again, welcome.