Help with a Method

I need a boolean method that returns true if string represents an integer
Here is my code..I can get this to work

Code:

---

public class ASD {
        public static void main(String args[]) {
                isInteger("230987");
        }
       
       
        public static boolean isInteger(String source) {
                char c;
                for (int x = 0; x < source.length(); x++) {
                        c = source.charAt(x);
                if (c == 0 || c == 1 || c == 2 || c == 3 || c == 4 || c == 5 || c == 6 || c == 7 || c == 8 || c == 9) {
                        return true;
                } else {
                        return false;
                        }
                }
               
        }
}

---

what am I doing wrong here??

In future "it doesn't work" provides zero information. Supply more details such as errors or actual beahviour/ desired behaviour.

Code:

---

c == 0

---

You are comparing the character c to an integer value 0 and not the character value 0.

By the way your logic is flawed. If the String to be checked was "9A" your code would return true.

i forgot the single quotations to denote a character, thanks..

the error im getting is that nothing is returned..it says i need to add a return statement or change the method to void..at this point i just want the program to run and work out the logic later..

What happens if the your code never enters the for loop? What gets returned?

Code:

---

public static boolean isInteger(String source) {
    char c;
    for (....) { // loop never enters

    }
    // we get here
}

---

As long as you resolve the logic error correctly, this problem will also go away.

Code:

---

public static boolean isInteger(String source) {
                char c;
                for (int x = 0; x < source.length(); x++) {
                        c = source.charAt(x);
                        if (c == '0' || c == '1' || c == '2' || c == '3' || c == '4' || c == '5' || c == '6' || c == '7' || c == '8' || c == '9') {
                                return true;
                        } else {
                                return false;

---

I tried doing that and get the same result..do I need another method for the for loop? and use an if statement in isInteger alone?

You tried doing what?

You reposted code has only fixed the comparison to a character. The logic is still wrong as you code will only ever check the first character in the String. If it is a digit return true, ignoring all the other characters in the String. Let me post 2 questions and see if they stimulate your thought process.

When do you know that the String IS NOT a number?
When do you know that the String IS a number?

The order I asked those questions is very important.

You can do this in a fairly tricky way with very little logic using Integer.parseInt.

Sunde,
im not suppose to use that..im just limited to using boolean methods loops etc..this is what we covered in class so far..
Junky
if im string is "23k9" the first loop would assignment c '2' then the if statement checks if its and return true i see what you mean by that Junky...
so do i put the return statement outside the loop?

If you answer my two questions above, where you place the return statement(s) will become more obvious.

I know this is easy but I am completely lost as to what to do...Ive been working on this problem for hours and cant figure it out..

Have you answered my 2 questions.

Post your answers here.

I know that the string is not a number when there is a character other than a digit while going through the loop

String is a number when the whole string is comprised of digits while going through the loop

Exactly.

As you loop over the String and you get to a non-digit chacter what should you do?
When you get to the end of the String and haven't encountered a non-digit character what will the loop do? What should you do?

Quote:

---

Originally Posted by Junky

Exactly.

As you loop over the String and you get to a non-digit chacter what should you do?
When you get to the end of the String and haven't encountered a non-digit character what will the loop do? What should you do?

---

If i get to a non digit character, i should return false..but how do i compare each index to a non character? i would assume
if (c != non character) {
return false;

how do I express that into code? there are many non digit chars $*$&#($hjkdsf how do i account for all of those?

Code:

---

if(c < '0' || c > '9')
if( ! Character.isDigit(c))

---

ok so i came up with this code

Code:

---

public class ASDFSA {
        public static void main(String args[]) {
                isInteger("01");
        }
       
       
        public static boolean isInteger(String source) {
                char c;
                for (int x = 0; x < source.length(); x++) {
                        c = source.charAt(x);
                        if (c < '0' || c > '9') {
                                return false;
                        } else {
                                return true;
                        }
                }
        }
}

---

ok i revise it to your way..its much more shorter and simple..

when I run the program it throws this error in eclipse

Exception in thread "main" java.lang.Error: Unresolved compilation problem:

at BenKim1.ASDFSA.main(ASDFSA.java:4)

it is telling me that I need to add a return statement...

When you get to the end of the String and haven't encountered a non-digit character what will the loop do? What should you do?

When you get to the end of the String and haven't encountered a non-digit character what will the loop do? What should you do?

When you get to the end of the String and haven't encountered a non-digit character what will the loop do? What should you do?

How many times do I have to ask?

you would return true if i have not encountered a non digit character

Yeah, so why are you trying to return true before you get to the end?