How would I code this

[iCon09]

Instructions are as follows:

The user must enter either "4", "5", "9", or "11". If any other number is entered, the program will print out "Invalid choice." and will terminate with no further output.

I may be going about this incorrectly, but I have tried a few different options and have found them all to fail in some way.

if (userInput != "4" && userInput != "5" && userInput != "9" && userInput != "11") {
					   System.out.println("Invalid Choice. ");
				}
			
					else {
						System.out.println("Which sport has "+userInput+" players? ");
					}

if (userInput == "4" || userInput == "5" || userInput == "9" || userInput == "11") {
					System.out.println("Which sport has "+userInput+" players? ");
				}
					else {
						System.out.println("Invalid Choice. ");
					
					}

if (userInput == "4") {
					System.out.println("Which sport has "+userInput+" players? ");
				}
				if (userInput == "5") {
					System.out.println("Which sport has "+userInput+" players? ");
				}
				if (userInput == "9") {
					System.out.println("Which sport has "+userInput+" players? ");
				}
				if (userInput == "11") {
					System.out.println("Which sport has "+userInput+" players? ");
				}
					else if (userInput != "4" && userInput != "5" && userInput != "9" && userInput != "11") {
						   System.out.println("Invalid Choice. ");
						
					
					}

if (userInput.equals("4")) {
					System.out.println("Which sport has "+userInput+" players? ");
				}
				if (userInput.equals("5")) {
					System.out.println("Which sport has "+userInput+" players? ");
				}
				if (userInput.equals("9")) {
					System.out.println("Which sport has "+userInput+" players? ");
				}
				if (userInput.equals("11")) {
					System.out.println("Which sport has "+userInput+" players? ");
				}
				if (userInput != "4" || userInput != "5" || userInput != "9" || userInput != "11") {
					System.out.println("Invalid Choice. ");
				
				}

None of these have worked correctly. I can paste my entire code if necessary. What I want to happen is if the input is 4,5,9, or 11, the program outputs the "Which sport has.." line, and if it is any other number it outputs "Invalid Choice." However, when I run the code with a valid number (4) in the console it will print "Which sport has 4 players?" but also directly under it, it will still print "invalid choice."


Any help is appreciated.

[Junky]

When comparing Objects (Strings are objects) 99.99999% of the time you do not want to use == but use the equals method instead. That is why the first three atempts do not work. What about your fourth attemp? That uses the equals method. Provide more information about what "doesn't work" means.

[Junky]

Ahhh, I just realised that after using the equals methods several times you revert back to using == in the last if statement.

[yellowledbet]

I think your logic is off in atleast a couple of the examples but I would imagine the real problem you are having is that you are comparing Object references and not Strings. Look up the String CompareTo(), Equals(), and Compare(). Java: ==, .equals(), compareTo(), and compare()

[iCon09]

Ahhh, I just realised that after using the equals methods several times you revert back to using == in the last if statement.

Yeah at first instead of the string userInput I just assigned the number as int n, then when it didn't work tried to change it to a string.


When you say revert back, where are you referring to? When I do "!="?

Is there a way to code "not equal to" in the equals method and not using "!="?

[iCon09]

I think your logic is off in atleast a couple of the examples but I would imagine the real problem you are having is that you are comparing Object references and not Strings. Look up the String CompareTo(), Equals(), and Compare(). Java: ==, .equals(), compareTo(), and compare()

Thanks, taking a look at the site now.

[iCon09]

Gonna try to add some more information. I have concluded the last one is my best best so far. So I am using it. I don't think the error is with the != but I could be wrong. The entire program was working as required except I missed the instruction that if 4,5,9, or 11 wasn't input, it had to say invalid choice.

The problem is, after I input 4 it will say "What sport has 4 players?" but also in the next line say "invalid choice". I don't want the invalid choice to come up when a valid number of players is entered.

[yellowledbet]

Gonna try to add some more information. I have concluded the last one is my best best so far. So I am using it. I don't think the error is with the != but I could be wrong. The entire program was working as required except I missed the instruction that if 4,5,9, or 11 wasn't input, it had to say invalid choice.

The problem is, after I input 4 it will say "What sport has 4 players?" but also in the next line say "invalid choice". I don't want the invalid choice to come up when a valid number of players is entered.

//This is your first example

I have not tested this code but I think the logic should look like this

if (userInput.equals("4") || userInput.equals("5") || userInput.equals("9")  || userInput.equals("11") {
                           System.out.println("Which sport has "+userInput+" players? ");
					  
				}
			
					else {
						 System.out.println("Invalid Choice. ");
					}

I think the logic you are looking for is

If input = somevalue OR
input = someOtherValue
THEN do this
ELSE bad input

[goldest]

In your first post, 4th approach you are using ONLY if statements. Then you are using == / != to compare Strings in the last if statement. That shouldn't be the preferred way when you are comparing objects. Always use equals() for better results.

Is there a way to code "not equal to" in the equals method and not using "!="?

The same thing which I said above. Use else statements,

if(x.equals("x")){
       //Equal to logic
      } else {
       //Not equal to logic
     }

See the approach yellowledbet has shown above.

Goldest

[iCon09]

Thanks guys, gonna try these after I'm done eating.

[Junky]

When you say revert back, where are you referring to? When I do "!="?

What I meant was that you were using the equals method in the first few if statements then in the last you went back to using == or !=, as already explained this is wrong.

If you want to use not equals method then the syntax is:

if ( ! str1.equals(str2)) {

}

[iCon09]

It worked guys, thanks. I repped you all, hope it helps.

[pbrockway2]

if (userInput != "4" || userInput != "5" || userInput != "9" || userInput != "11") {
    System.out.println("Invalid Choice. ");
}

Not that you need it now, but you will at some point: what you meant there was

if (!userInput.equals("4") [b]&&[/b] !userInput.equals("5") [b]&&[/b] !userInput.equals("9") [b]&&[/b] !userInput.equals("11")) {
    System.out.println("Invalid Choice. ");
}

Confusingly we say "not a or b" when we mean "not a and also not b".