Please help with simple program.. Very simple.

[jonytek]

Hi can someone help me. I want this program to return a double value but all i am getting is 0 returned??? Thanks...

public class Parcel {
	private double weight;
	private char destination;
	double total;
	
	
	
	public Parcel(double weight, char destination){
		this.weight = weight;
		this.destination = destination;
	}
	public double getWeight(){
		return this.weight;
	}
	public char getDest(){
		return this.destination;
	}
	public void getCost(){
		double cost = 1.0;
		
		
		if(this.destination == 'S'){
			if (this.weight < 1.0){
				cost = 4.65;
			}
			else if (this.weight >= 1 && this.weight < 2){
				cost = 4.65;
			}
			else if (this.weight >= 2){
				cost = 4.65;
			}
			
		}
			else if(this.destination == 'M' || this.destination == 'B'){
				if (this.weight < 1.0){
					cost = 6.55;
				}
				else if (this.weight >= 1 && this.weight < 2){
					cost = 7.0;
				}
				else if (this.weight >= 2){
					cost = 7.45;
				}
			}
					else if(this.destination == 'A'){
						if (this.weight < 1.0){
							cost = 6.8;
						}
						else if (this.weight >= 1 && this.weight < 2){
							cost = 7.5;
						}
						else if (this.weight >= 2){
							cost = 8.2;
						}
					}
					else if(this.destination == 'P'){
							if (this.weight < 1.0){
								cost = 8.1;
							}
							else if (this.weight >= 1 && this.weight < 2){
								cost = 10.10;
							}
							else if (this.weight >= 2){
								cost = 12.10;
							}
					}
					else if(this.destination == 'H'){
								if (this.weight < 1.0){
									cost = 7.65;
								}
								else if (this.weight >= 1 && this.weight < 2){
									cost = 9.2;
								}
								else if (this.weight >= 2){
									cost = 10.75;
								}
							this.total = cost;	
					}
		
		}
	public double getTotal(){
		return this.total;
	}
		
}

Tester

public class ParcelTest {
	public static void main(String[] args){
		Parcel p1 = new Parcel (0.8, 'S');
		p1.getCost();
		System.out.println(p1.total);
		System.out.println(p1.getTotal());
		
		Parcel p2 = new Parcel (0.8, 'D');
		p2.getTotal();
		System.out.println(p2.total);
		System.out.println(p2.getTotal());
		
		Parcel p3 = new Parcel (0.8, 'P');
		p3.getTotal();
		System.out.println(p3.total);
		System.out.println(p3.getTotal());
		
		Parcel p4 = new Parcel (0.8, 'A');
		p4.getTotal();
		System.out.println(p4.total);
		System.out.println(p4.getTotal());

		
	}
}

[Junky]

You indentation makes it very hard to read your code.

else if(this.destination == 'H'){
    // code
    this.total = cost;
}

It would seem that the only time you actual assign a value to total is when the destination is 'H'.

[jonytek]

Oh ok. Yer 'H' does return a value. Why is that?

[Junky]

Because of where you placed the total = ... statement. As I said your indentation is hard to read. If you used a better style it would easier to spot your mistake and where the line of code should be instead.

[jonytek]

Does this make it easier? Sorry but im new to this.

public class Parcel {
	private double weight;
	private char destination;
	double total;
	
	
	
	public Parcel(double weight, char destination){
		this.weight = weight;
		this.destination = destination;
	}
	public double getWeight(){
		return this.weight;
	}
	public char getDest(){
		return this.destination;
	}
	public void getCost(){
		double cost = 1.0;
		
		
		if(this.destination == 'S'){
			if (this.weight < 1.0){
				cost = 4.65;
			}
			else if (this.weight >= 1 && this.weight < 2){
				cost = 4.65;
			}
			else if (this.weight >= 2){
				cost = 4.65;
			}
			
		}
		else if(this.destination == 'M' || this.destination == 'B'){
				if (this.weight < 1.0){
					cost = 6.55;
				}
				else if (this.weight >= 1 && this.weight < 2){
					cost = 7.0;
				}
				else if (this.weight >= 2){
					cost = 7.45;
				}
			}
		else if(this.destination == 'A'){
						if (this.weight < 1.0){
							cost = 6.8;
						}
						else if (this.weight >= 1 && this.weight < 2){
							cost = 7.5;
						}
						else if (this.weight >= 2){
							cost = 8.2;
						}
					}
		else if(this.destination == 'P'){
							if (this.weight < 1.0){
								cost = 8.1;
							}
							else if (this.weight >= 1 && this.weight < 2){
								cost = 10.10;
							}
							else if (this.weight >= 2){
								cost = 12.10;
							}
								
					}
		
		else if(this.destination == 'H'){
								if (this.weight < 1.0){
									cost = 7.65;
								}
								else if (this.weight >= 1 && this.weight < 2){
									cost = 9.2;
								}
								else if (this.weight >= 2){
									cost = 10.75;
								}
		this.total = cost;	
					}
		
		}
	public double getTotal(){
		return this.total;
	}
		
}

[Junky]

Gawd no, that's worse.

Anyway I told you what the problem is, you only set total when destination is 'H' but you want total to be set regardless of what the destination is. Surely it should be simple to figure out where that line of code should be instead of where you have it.

[Junky]

Another point (nitpick)

if (this.weight < 1.0){
    cost = 4.65;
} else if (this.weight >= 1 && this.weight < 2){
    cost = 4.65;
} else if (this.weight >= 2){
    cost = 4.65;
}

What is the point of that if statement?

[jonytek]

Another point (nitpick)
Code:
if (this.weight < 1.0){
cost = 4.65;
} else if (this.weight >= 1 && this.weight < 2){
cost = 4.65;
} else if (this.weight >= 2){
cost = 4.65;
}
What is the point of that if statement?

Lol. Ok thanks for the help..... Really appreciate it.