Missing Return statement =[

[avirunes]

hey i get the following compile error, and im not sure what to do to fix it.

src\server\models\players\Playerassistant.java:167 2: missing return statement
}
^

this is the code.

public String getSkillName(int skillId) {
switch (skillId) {
case 0:
return "Attack";
case 1:
return "Defence";
case 2:
return "Strength";
case 3:
return "Hitpoints";
case 4:
return "Ranged";
case 5:
return "Prayer";
case 6:
return "Magic";
case 7:
return "Cooking";
case 8:
return "Woodcutting";
case 9:
return "Fletching";
case 10:
return "Fishing";
case 11:
return "Firemaking";
case 12:
return "Crafting";
case 13:
return "Smithing";
case 14:
return "Mining";
case 15:
return "Herblore";
case 16:
return "Agility";
case 17:
return "Theiving";
case 18:
return "Slayer";
case 19:
return "Runecrafting";

}
}


line 1672 is the first bracket.

Thanks, any help appreciated.

[pbrockway2]

The compiler demands that the method returns a String for any value that skillId might have.

If it is your intent that skillId only have values 0-19 then you could return some bogus value or, better, throw an exception. The best thing would be to use something other than int as the type of skillId: this is what enums are for.

[milovan]

Try to use break; in your code

[milovan]

And finaly

[avirunes]

if i put a number, i get imcompatible types, found: int, if i put a name i get cannot find symbol xxxx variable :S

[JosAH]

And finaly

That would be a very silly solution; the OPs example is equivalent to this code:

String foo(int i) {
   switch (i) {
      case 1: return "one";
      case 2: return "two";
      case 3: return "three";
   }
}

Even if everybody swears that method foo only will be called with a parameter 1, 2 or 3 the compiler won't believe them because (obviously) method foo doesn't return a String value for any parameter value not in the range 1, 2 or 3. Even more, this code:

String foo(int i) {
   if (i < 1 || i > 3) return "huh?";
   switch (i) {
      case 1: return "one";
      case 2: return "two";
      case 3: return "three";
   }
}

... doesn't make the compiler shut its mouth, i.e. it still thinks that at the end of the method no String value is returned. The compiler doesn't interpret the code, nor can't it understand the semantics, the intention, of the code. Basically, when the compiler whines about "no return value" it is right and rearrange your code.

kind regards,

Jos

[milovan]

Basic usage:

public String getSkillName(int skillId) {

    String s = ""; // or some default value

    switch (skillId) {

        case 0:
            s = "Attack";
            break;
        case 1:
            s = "Defence";
            break;
        ...

        case 19:
            s = "Runecrafting";
            break;
    }
    return s;
}