what is wrong with my code

[amrmb09]

hi, in the following code i try to compare two objects from type string
in other words , i try to implement a class that simulate (.equals)

public class Amr {

  private String word;
  
    public Amr(String str) 
        {
            setString(str);
        }
        
    private void setString (String str)
    {
        this.word = str;
    }
    
    public boolean IsPloyndrome(Amr string)
        {
          if ( this.getString().equals(string.getString()) )
               return true;
          else 
               return false;
        }
    
    public  Amr getString()
        {
          Amr obj = new Amr(word);
          return obj;
        }
}

main method:

  public class Polyndrom
{
    public static void main (String[] args)
    {
        Amr h = new Amr("hi");
        Amr b = new Amr("hi");
        
        if ( h.IsPloyndrome(b) )
            System.out.println ("equals");
            else System.out.println ("not equals");
    }
}

[sunde887]

You don't need a setter in the constructor, it has access to the private instance variables.

getString also takes no argument, but uses an argument which isn't declared anywhere.

Getters and Setters both also have access to private class variables

in the comparison method you can also access the string field directly.

so

getString() 

should look like

public String getString(){
  return word;
}

[Junky]

Why is your getString method returning a new Amr object? Since it does then your if statement becomes if Amr object equals Amr object. You don't have an equals method in your Amr class so it will use the equals method it inherits form object and 99.99999999% of the time it will not do what you want.

So to cut a long story short, why doesn't your getString method just return word?

[amrmb09]

many thanks for u all

my getString doesnt return (word)
beacuse i want to return an object

i want to simulate the logic behind ".equals method"

[sunde887]

The way you are trying to do it requires you to override .equals() method. The getter should not work like that, try having it just return a string, then override .equals() which takes a Amr object as the argument and returns boolean, then you can compare the items however you want.

[Junky]

many thanks for u all

my getString doesnt return (word)
beacuse i want to return an object

I have several issues.

The method is called getString but it returns an Amr and not a String.

You say you want to return an object, well String is an object.

To compare two Amr objects you call the getString method which creates a new Amr object each time it is called. You call it twice (once for each Amr object) and end up with 4 Amr objects just to compare if they contain the same String. A whole lot of nonsense. You code can be simplified to:

public boolean IsPloyndrome(Amr string)
    return word.equals(string.word);
}

[amrmb09]

ohh, thank you so much
i dont know why i have not though that simple
anyway, i will apply this code and study it well

many thanks for u all

[amrmb09]

I have implement it may be with slight differnt way but i works

public class Amr 
{
	private String word;

			  public Amr(String text)
			    {
				    this.word = text;
			    }
			  public String getText()
				{
					return word;
				}
  
			  public boolean isEqual(Amr text)
				{

			  		return this.word.equals(text.getText());  		    
				}
  
			  public static boolean Ispoly(String str)
                {
    	          int cnt=0,cnt2=0;
    	
    	            if ( str.length()%2 == 0 )
    		            {
		                    for (int i=0;i<str.length()/2;i++)
    		     	             if  (str.charAt(i) == str.charAt( ((str.length()-1)-i) ) )
    			                          cnt++;
    	       
    	                         if ( cnt==str.length()/2 )     	        
    		                              return true;
    		                     else  
    		                              return false; 
    	                }//end if
    	
    	            else
    	    	        {    
		                    for (int i=0;i<(str.length()-1)/2;i++)
		    		   	         if  (str.charAt(i) == str.charAt( ((str.length()-1)-i) ) )
			    			              cnt2++;
    	
    	                         if ( cnt2==(str.length()-1)/2 )     	        
    		                               return true;
    		                     else  
    		                     	       return false; 
    	                }//end else   
           
                 }// end ispoly
    
}// end Class Amr

Main:

public class Polyndrom
{
	public static void main (String[] args)
	{
		if ( Amr.Ispoly("abcddcba") )
			 System.out.println ("polyndrom");
			    else 
			   	     System.out.println ("not polyndrom");
			   	     
	    Amr o1=new Amr("asd");
	    Amr o2=new Amr("asd");
	    
	    if (o1.isEqual(o2))
	    System.out.println ("equal strings");
	        else   System.out.println ("not equal strings");
	}
}