Why am i runnin out of memory... ?

[calle]

Im trying to figure out why i get the out of memory error when running.
The addFriend method works fine, but when i add the addFriendBack and run the program and activate the addFriend method my program crashes.

public boolean addFriend(String name, String friendName) {
	Person gainFriend = getPerson(name);
	Person newFriend = getPerson(friendName);
	if (gainFriend == null || newFriend == null) { //Checking if both ppl exists
	    System.out.println("One or both of the names is not registered");
	    return false;
	}
	Friend friendCheck = gainFriend.firstFriend; //Adds friend here if one was friendless 
	if (friendCheck == null) {
	    gainFriend.firstFriend = new Friend(null, newFriend);
	    gainFriend.firstFriend.personObject = newFriend;
	    System.out.println(friendName+" was succesfully added to "+name+"'s friends");
	    addFriendBack(gainFriend, newFriend);
	    return true;
	} else {
	    while (friendCheck != null) {
		if (friendCheck.personObject.equals(newFriend)) {
		    System.out.println(name+" is already friends with "+friendName);
		    return false;
		} else {
		    if (friendCheck.nextFriend == null) { //Adding new friend at the end of the chain
			friendCheck.nextFriend = new Friend(null, newFriend);
			friendCheck.nextFriend.personObject = newFriend;
			System.out.println(friendName+" was succesfully added to "+name+"'s friends");
			addFriendBack(gainFriend, newFriend);
			return true;
		    }
		} 
		friendCheck = friendCheck.nextFriend;
	    }
	}
	return false; // ================DO OVER
    }

public void addFriendBack(Person gainFriend, Person newFriend) {
 	Friend friendCheck = newFriend.firstFriend; //Adds friend here if one was friendless 
	if (friendCheck == null) {
	    newFriend.firstFriend = new Friend(null, newFriend);
	    newFriend.firstFriend.personObject = newFriend;
	} else {
	    while (friendCheck != null) {
		if (friendCheck.nextFriend == null) { //Adding new friend at the end of the chain
		    friendCheck.nextFriend = new Friend(null, newFriend);
		    friendCheck.nextFriend.personObject = newFriend;
		}
		friendCheck = friendCheck.nextFriend;
	    }
	}
    }

Any help is good :)
Cheers!



The two methods is inside the Person
Heres the code for the classes/objects im referring to in the above code:

class Person {
    
    String name;
    String number;
    Person next;
    Friend firstFriend;
    private int numberOfFriends;
    
    Person(String name, String number) {
	this.name = name;
	this.number = number;
    }

The Person class got several methods, so only posted the varables from that one.

class Friend {
    Friend nextFriend;
    Person personObject;
    
    Friend (Friend nextFriend, Person personObject) {
	this.nextFriend = nextFriend;
	this.personObject = personObject;

[Zepher]

It looks to me like in your while statement:

while (friendCheck != null) {
if (friendCheck.nextFriend == null) { //Adding new friend at the end of the chain
friendCheck.nextFriend = new Friend(null, newFriend);
friendCheck.nextFriend.personObject = newFriend;
}

you will loop infinitely because friendCheck (the object) will never be null because it was initialized at the beginning of your method. Because of this, you continue adding friends until you run out of memory.

Double check the intent of this while loop and I think you will find a solution that fits your needs.

Good Luck.

[calle]

Cheers!

Thank you for making me notice the infinite loop!

I think the reason for me not seeing it was that in the "main" addFriend method im using the same while sentence, but im able to break out of it coz of the return statements. So I dont know if this is the right way to correct it but i just made the addFriendBack method boolean aswell, so i could break out of the loops with return.

public boolean addFriendBack(Person gainFriend, Person newFriend) {
 	Friend friendCheck = newFriend.firstFriend;  
	if (friendCheck == null) {
	    newFriend.firstFriend = new Friend(null, gainFriend); //Adds friend here if one was friendless
	    System.out.println("DWADAWDAWD"); //REMOVE REMOVE REMOVE
	    return true;
	} else {
	    while (friendCheck != null) {
		if (friendCheck.nextFriend == null) { //Adding new friend at the end of the chain
		    friendCheck.nextFriend = new Friend(null, gainFriend);
		    System.out.println("HMM!"); //REMOVE REMOVE REMOVE
		    return true;
		} 

		friendCheck = friendCheck.nextFriend;  // THINK THINK THINK	
	    }
	}
	return false;
    }
}