Boolean setter Method

[JonoHart]

Hi first timer here

I want to create a setter method for a boolean instance I have declared.
I want it to change the value to false if it is already true and vice versa

The compiler is giving me some syntax errors when I write it though

Here is my method

/**
* Setter method for lastGiven
*/
public boolean setLastGiven()
if (getLastGiven == false);
{
return lastGiven = true;
}
else
{
return lastGiven = false


lastGiven is the instance variable I have declared as follows

private boolean lastGiven;

I have also initialised it as follows

this.lastGiven = false;

Hope you can help

[Junky]

Why are you returning a value from a setter method?

bool = ! bool;

[Fubarable]

setters shouldn't return anything, making your code and your goals confusing. If you want to create a setter for a boolean, have it return void and pass a boolean parameter into it that is used to set the variable. It sounds like you don't want to create a setter method but rather want to toggle the boolean field, and if so, I'd perhaps call the method toggleLastGiven(), but would also have it return void since the goal of the method is not to return a result but to change an object's state. To toggle a boolean, simply do this:

  myBoolean = !myBoolean;

Also, please read my link on use of code tags here. Also, if your code causes errors or exceptions, you're going to want to post the actual error message.

Luck.

[JonoHart]

Ok thanks thats beginning to make sense now, sort of.

I've changed to this

/**
* Setter method for lastGiven
*/
public void setLastGiven()
{
lastGiven = !lastGiven;
}

(I'm just going look at your Links for posting sorry if it's not the best yet)

Think I was getting confused.

Thanks for your help

Jon

[Fubarable]

Again, that's not a setter method and should not be called setLastGiven. A setter method takes the parameter and sets the field based on the parameter. This method toggles a boolean and its name should reflect that it does this. Again, please read my link on use of code tags here. Your posted code is very difficult to read without tags.

[goldest]

Hey JonoHart,

Go through this link first which explains about accessors and mutators methods of java. How to use them and why to use them. Here is the link : Java Accessors and Mutators.

Hope that helps,

Goldest

[JonoHart]

Ok got it, changed the code again and tested as working.

   public void setLastGiven(boolean lastGiven)
   {
      this.lastGiven = lastGiven;
   }

Thanks for all your help

Jon

[JosAH]

Ok got it, changed the code again and tested as working.

   public void setLastGiven(boolean lastGiven)
   {
      this.lastGiven = lastGiven;
   }

If you really want to flip the value of that boolean member, why not just do this?

public void toggleLastGiven() {
   lastGiven= !lastGiven;
}

kind regards,

Jos

[Fubarable]

If you really want to flip the value of that boolean member, why not just do this?

public void toggleLastGiven() {
   lastGiven= !lastGiven;
}

Yes, Jos is stating what I am clumsily trying to tell you, but in a much clearer way. Please heed his advice.