Database connection

[oaklander]

I created my first Java class that inserts and updates an Oracle 9i database. I am running single insert and single update statements.
The below is what I have been using and was wondering if it is efficient or anyway to improve it:

Code:

public class DbWork
{

    private Connection connection = new ConnectionMgr().getConnection();
    private PreparedStatement stat;

     public void cityInserter(FormBean city) throws SQLException  {
        stat = connection.prepareStatement("Insert into City (street, school) values (?,?)");
        stat.setString(1, city.getStreet());
        stat.setString(2, city.getSchool());
        stat.executeUpdate();
    }

    public void cityUpdater(FormBean city) throws SQLException  {
        stat = con.prepareStatement("update Person set PersonId = ? where name LIKE ? ");
        stat.setInt(1, city.getPersonId());
        stat.setString(2, city.getName());
        stat.executeUpdate():
    }


   public void dbMethod(FormBean city)
   {
        try 
       {
               cityInserter(city);
               cityUpdater(city);
       }
       catch(SQLException ex)
       {
              System.out.println(ex);
       }
       finally
       {
             connection.close();
       }

}

[ShoeNinja]

Looks just like something that I wrote for to update some DB2 tables. It was my first time connecting to databases with Java so I'm not sure how much weight my thoughts carry.

[oaklander]

I hope we are doing it correctly because I am concerned about efficiency and I read that I shouldnt keep the Connection and PreparedStatement as an instance variable. Also what are consequences to making the connection happen at construction time and making 'connection' and 'stat' instance variables?