help!comparing input with sql data.

[10e5x]

i am doing logging in.i want to check user input password with the password stored by the username.how to i do so?i tried this but keep return success = true

public static boolean loginUser(String inUserName, String inPwd){
boolean success = false;
ResultSet rs=null;
DBController db = new DBController();

db.setUp("userDatabase");

String dbQuery = "SELECT Pwd FROM USER WHERE USERNAME ='" + inUserName + "' ";
rs =db.readRequest(dbQuery);
try{
if ((rs.next()) || (inPwd==rs.getString("Pwd"))){
success = true;
}
}
catch (Exception e){
e.printStackTrace();
}
return success;
}

[JavaHater]

		try{
			if ((rs.next()) || (inPwd==rs.getString("Pwd"))){
				success = true;
			}
		}

try using equals()

inPwd.equals("Pwd");

of course, i am assuming you are really checking against the string "Pwd".

[10e5x]

yes i am. however i use ur suggestion then it always return true.it does not care if my pwd is right or wrong

[JavaHater]

yes i am. however i use ur suggestion then it always return true.it does not care if my pwd is right or wrong

why are you using "||" then? This means "or" , so if rs.next() is always evaluated (ie, there is return value from database query), then your "inPwd.equals("Pwd") will not be evaluated.

[10e5x]

meaning i use &&?cuz i want to check if username is in my database not if not it will not even check if that username's password is equals to the input pwd.anyway, thanks for being so helpful,but i am really stucked for long

[JavaHater]

meaning i use &&?cuz i want to check if username is in my database not if not it will not even check if that username's password is equals to the input pwd.anyway, thanks for being so helpful,but i am really stucked for long

why not you just get the string out from the database first , then do the compare? I don't have a database to test, but here's the steps you can do

Query the database, and return just the password string ( ie, remove the "|| (inPwd==rs.getString("Pwd"))" line
check password string against inPwd

[10e5x]

i believe u mean this?if i remove rs.next(), there will be a error: Invalid cursor states and login in is unsuccessful even though i pass in the correct password.

public static boolean loginUser(String inUserName, String inPwd){
boolean success = false;
ResultSet rs=null;
DBController db = new DBController();

db.setUp("userDatabase");

String dbQuery = "SELECT Pwd FROM USER WHERE USERNAME ='" + inUserName + "' ";
rs =db.readRequest(dbQuery);
try{
if (inPwd==rs.getString("Pwd")){

success = true;

}
}
catch (Exception e){
e.printStackTrace();
}
return success;
}

[10e5x]

help help.

[JavaHater]

i believe u mean this?if i remove rs.next(), there will be a error: Invalid cursor states and login in is unsuccessful even though i pass in the correct password.

public static boolean loginUser(String inUserName, String inPwd){
boolean success = false;
ResultSet rs=null;
DBController db = new DBController();

db.setUp("userDatabase");

String dbQuery = "SELECT Pwd FROM USER WHERE USERNAME ='" + inUserName + "' ";
rs =db.readRequest(dbQuery);
try{
if (inPwd==rs.getString("Pwd")){

success = true;

}
}
catch (Exception e){
e.printStackTrace();
}
return success;
}

no, do it step by step. Make sure you get back something back first from your database query. Then, do the comparison.

[10e5x]

i did. my rs.next() works. but once it compares it doesnt. i think i am too not good at it.what do u mean by step by step.meaning i break down which one?if able to, can u kindly show me the codes?

[JavaHater]

i did. my rs.next() works. but once it compares it doesnt. i think i am too not good at it.what do u mean by step by step.meaning i break down which one?if able to, can u kindly show me the codes?

so rs.next() works, but what is the result? Can you show the result of the query?

[10e5x]

result of the qeury is "12345" when i key in inUserName = 10e5x

[JavaHater]

result of the qeury is "12345" when i key in inUserName = 10e5x

ok, now show the code where you do the comparison , as well as the code where you get the database result.

[10e5x]

if (inPwd==rs.getString("Pwd")){

success = true;

}

keep return false and got the error invalid cursor even i enter in the correct password to 10e5x

[JavaHater]

if (inPwd==rs.getString("Pwd")){

success = true;

}

keep return false and got the error invalid cursor even i enter in the correct password to 10e5x

when you print out rs.getString("Pwd"), its 12345 right?

then you should be able to use inPwd.equals( rs.getString("Pwd") );

[10e5x]

i solved.really thank you so much.u helped alot

[10e5x]

SELECT * FROM USER WHERE Email = 'guox@gmail.com' ;
this sql statement return me every columns but with no value. how come?

[JavaHater]

why don't you show all your code and how you fetch them ?

[10e5x]

public static boolean forgetUser(String inEmail, String inDob){
boolean success = false;
ResultSet rs=null;
DBController db = new DBController();

db.setUp("userDatabase");

String dbQuery = "SELECT * FROM USER WHERE EMAIL ='" + inEmail + "' ";
rs =db.readRequest(dbQuery);
try{
if (rs.next()){
if((inEmail.equals( rs.getString("Pwd") )) || (inDob.equals(rs.getString("Dob"))))

success = true;

}
}
catch (Exception e){
e.printStackTrace();
}
return success;
}


the result give me back blank table with all column name

[JavaHater]

this is just a function. you are only returning true or false. I don't see any code that displays your result.