Why is my array of images not showing up?

My program is supposed to come up and show 4 images, and then the user inputs which image they think doesn't belong. Depending on what they answer it simply replies "Right" or "Wrong"
The only problem that i am having is that the pictures are not coming up. Here is my code:

Code:

---

import java.awt.*;
import java.awt.event.*;

import javax.swing.*;

public class yea extends JFrame implements ActionListener{
  ImageIcon[] ball = new ImageIcon[5];
  Timer clock;
  int frame;
  Container p = this.getContentPane();
     
 
    JLabel lblOutput = new JLabel("");
        JTextField txtInput = new JTextField("Answer here: first, second, third, or fourth");
       
 
        public static void main(String args[]){
          new yea();
  } // end main
 
  public yea(){
          super("Animate Images");
          //load up the images
          ball[1] = new ImageIcon("1.gif");
          ball[2] = new ImageIcon("2.gif");
          ball[3] = new ImageIcon("3.gif");
          ball[4] = new ImageIcon("4.gif");
         
          clock = new Timer(1000, this);
         
         
          this.setVisible(true);
          this.setDefaultCloseOperation(this.EXIT_ON_CLOSE);
          p.setLayout(new BorderLayout());
               
          this.init();
          this.setVisible(true);
      this.pack();
      this.setSize(1270,1000);
          clock.start();
  } // end constructor
 
  public void paint(Graphics g) {
          super.paint(g);
          g.drawImage(ball[frame].getImage(),300, 300, null);
       
  } // end paint
  public void init(){
          Panel pNorth = new Panel();
                pNorth.setLayout(new FlowLayout());
               
                pNorth.add(new JLabel("Which Picture doesn't belong? first,second,third, or fourth?"));

                Panel pSouth = new Panel();
                pSouth.setLayout(new FlowLayout());
                pSouth.add(lblOutput);
                pSouth.add(txtInput);
               
               
                p.add(pNorth, BorderLayout.NORTH);
                p.add(pSouth, BorderLayout.SOUTH);
         
  }
 
  public void actionPerformed(ActionEvent e){
         
          frame++;
          if (frame > 4){
            frame += 1;
           
  String input = txtInput.getText();
                if (input.equals("first")){
                        lblOutput.setText("yes!");
                }
                        if(input.equals("second")) {
                                lblOutput.setText("No!");
                }
              if(input.equals("third")) {
                                lblOutput.setText("No!");
                }
                  if(input.equals("fourth")){
                                lblOutput.setText("No!");
                       
                }
                       
           
          }
  }
}

---

Maybe it is the hour but I cannot see what you have implementing ActionListener

is this what you mean?

Code:

---

[COLOR="Red"]public class yea extends JFrame implements ActionListener{[/COLOR]
  ImageIcon[] ball = new ImageIcon[5];
  Timer clock;
  int frame;
  Container p = this.getContentPane();
     
 
    JLabel lblOutput = new JLabel("");
        JTextField txtInput = new JTextField("Answer here: first, second, third, or fourth");
       
 
        public static void main(String args[]){
          new yea();
  } // end main
 
  public yea(){
          super("Animate Images");
          //load up the images
          ball[1] = new ImageIcon("1.gif");
          ball[2] = new ImageIcon("2.gif");
          ball[3] = new ImageIcon("3.gif");
          ball[4] = new ImageIcon("4.gif");
         
          clock = new Timer(1000, this);
         
         
          this.setVisible(true);
          this.setDefaultCloseOperation(this.EXIT_ON_CLOSE);
          p.setLayout(new BorderLayout());
               
          this.init();
          this.setVisible(true);
      this.pack();
      this.setSize(1270,1000);
          clock.start();
  } // end constructor
 
  public void paint(Graphics g) {
          super.paint(g);
          g.drawImage(ball[frame].getImage(),300, 300, null);
       
  } // end paint
  public void init(){
          Panel pNorth = new Panel();
                pNorth.setLayout(new FlowLayout());
               
                pNorth.add(new JLabel("Which Picture doesn't belong? first,second,third, or fourth?"));

                Panel pSouth = new Panel();
                pSouth.setLayout(new FlowLayout());
                pSouth.add(lblOutput);
                pSouth.add(txtInput);
               
               
                p.add(pNorth, BorderLayout.NORTH);
                p.add(pSouth, BorderLayout.SOUTH);
         
  }
 
  public void actionPerformed(ActionEvent e){
         
          frame++;
          if (frame > 4){
            frame += 1;
           
  String input = txtInput.getText();
                if (input.equals("first")){
                        lblOutput.setText("yes!");
                }
                        if(input.equals("second")) {
                                lblOutput.setText("No!");
                }
              if(input.equals("third")) {
                                lblOutput.setText("No!");
                }
                  if(input.equals("fourth")){
                                lblOutput.setText("No!");
                       
                }
                       
           
          }
  }
}

---

Yes but what in your program is going to make that actionPerformed method execute?

also it does look like the integer frame is not initialised to anything but then you are using it to access an array element which *might* most likely will cause a null pointer exception

I am not sure! :confused:

i would assume it goes in here somwhere

Code:

---

public void actionPerformed(ActionEvent e){
         
          frame++;
          if (frame > 4){
            frame += 1;
           
  String input = txtInput.getText();
                if (input.equals("first")){
                        lblOutput.setText("yes!");
                }
                        if(input.equals("second")) {
                                lblOutput.setText("No!");
                }
              if(input.equals("third")) {
                                lblOutput.setText("No!");
                }
                  if(input.equals("fourth")){
                                lblOutput.setText("No!");
                       
                }

---

could i put a new panel in the CENTER, and have the array of images show up on there, or is that even necessary?

You could add an actionlistener to JTextField but you actionPerformed method would need more logic, here is an article, still not sure about that frame integer not being initialised to a value where it is declared

How to Use Text Fields (The Java™ Tutorials > Creating a GUI With JFC/Swing > Using Swing Components)

To get an image up originally I would try setting your integer frame equal to 1 where it is declared

i changed it to
int frame = 1;
and yes, now my 1st image shows up! but its isnt going through them. I suppose that link is has a solution?

*I suppose that link has the solution?

Yup you are implementing ActionListener but no components e.g. JButton, JTextField are using it.... look at the link...I would use a JButton for simplicity

here is the reason you were gettin no image originally

Code:

---

int frame; // not initialised

---

an array of imageicons, array access begins at 0 not 1 (for future reference)

Code:

---

ball[1] = new ImageIcon("1.gif");
 ball[2] = new ImageIcon("2.gif");
 ball[3] = new ImageIcon("3.gif");
 ball[4] = new ImageIcon("4.gif");

---

accessing the element of ball at index frame, but frame is not initialised (e.g. is not 0,1,2,3 or any number etc )

Code:

---

g.drawImage(ball[frame].getImage(),300, 300, null);

---

im not putting the link and JButton together. Do i need to add a JButton so that when i click it, it causes the images to cycle?

Yeah I think that would be the simplest way, say two JButtons one for next one for previous image

Code:

---

JButton next=new JButton("next");
next.addActionListener(this);
JButton prev=new JButton("Previous");
prev.addActionListener(this);

public void actionPerformed(ActionEvent e){
    if(e.getSource().equals(next)){
        frame++;
        repaint();
    }
    else if(e.getSource().equals(prev)){
        frame--;
        repaint();
    }
}

---

I think that should be pretty close to what you want...do look up the code though, dont follow blind.

oh okay, i got it. Thank you, I appreciate the help!

:)

No problem, come back if you have any more problems

im gonna be working on it tomorrow and adding some more stuff, so i def. will if i do! thanks!!!

I have highlighted my new code in red. I basically just added what was needed for a new array. What i want do do, is if the person guesses the right image, then the next array of images show up. Can i do this with this current setup?

Code:

---

import java.awt.*;
import java.awt.event.*;

import javax.swing.*;

public class yea extends JFrame implements ActionListener{
  ImageIcon[] ball = new ImageIcon[5];
  [COLOR="Red"]ImageIcon[] color = new ImageIcon[5];[/COLOR]
 
  int frame = 0;
  [COLOR="red"]int frame2 = 0;[/COLOR]
  Container p = this.getContentPane();
  JButton next=new JButton("next");
 
  JButton prev=new JButton("Previous");
 
 
    JLabel lblOutput = new JLabel("");
        JTextField txtInput = new JTextField("Answer here: first, second, third, or fourth");
       
 
        public static void main(String args[]){
          new yea();
  } // end main
 
  public yea(){
          super("Animate Images");
          //load up the images
          ball[0] = new ImageIcon("1.gif");
          ball[1] = new ImageIcon("2.gif");
          ball[2] = new ImageIcon("3.gif");
          ball[3] = new ImageIcon("4.gif");
         
          [COLOR="red"]color[0] = new ImageIcon("11.gif");
          color[1] = new ImageIcon("12.gif");
          color[2] = new ImageIcon("13.gif");
          color[3] = new ImageIcon("14.gif");[/COLOR]
         
         
         
          next.addActionListener(this);
          prev.addActionListener(this);
          this.setVisible(true);
          this.setDefaultCloseOperation(this.EXIT_ON_CLOSE);
          p.setLayout(new BorderLayout());
               
          this.init();
          this.setVisible(true);
      this.pack();
      this.setSize(1270,1000);
         
  } // end constructor
 
  public void paint(Graphics g) {
          super.paint(g);
          g.drawImage(ball[frame].getImage(),300, 300, null);
          [COLOR="red"]g.drawImage(color[frame2].getImage(),300, 300, null);[/COLOR]
       
  } // end paint
  public void init(){
          Panel pNorth = new Panel();
                pNorth.setLayout(new FlowLayout());
               
                pNorth.add(new JLabel("Which Picture doesn't belong? first,second,third, or fourth?"));

                Panel pSouth = new Panel();
                pSouth.setLayout(new FlowLayout());
                pSouth.add(lblOutput);
                pSouth.add(txtInput);
                pSouth.add(next);
                pSouth.add(prev);
                p.add(pNorth, BorderLayout.NORTH);
                p.add(pSouth, BorderLayout.SOUTH);
         
  }
 
  public void actionPerformed(ActionEvent e){
         
          if(e.getSource().equals(prev)){
                frame--;
                repaint();
            }
            else if(e.getSource().equals(next)){
                frame++;
                repaint();
           
  String input = txtInput.getText();
                if (input.equals("first")){
                        lblOutput.setText("yes!");
                }
                        if(input.equals("second")) {
                                lblOutput.setText("No!");
                }
              if(input.equals("third")) {
                                lblOutput.setText("No!");
                }
                  if(input.equals("fourth")){
                                lblOutput.setText("No!");
                       
                }
                       
           
          }
  }
}

---

have you run this code? does it do what you want?