Help with 'while' loop

[ls7897]

Hey all, I'm new to these forums and new to java. I've just started my first year at university, and need a little help with a 'while' loop.

I'll show you what I've wrote below, and hopefully someone may be able to tell me where I've gone wrong with the 'while' loop.

import java.util.Scanner;
import java.io.File;

class test{
	public static void main (String args[])throws Exception{
		File myFile = new File("alice.txt");  
		Scanner fileScan = new Scanner(myFile);  
	
		String[] line = new String[20];

           while (fileScan.hasNext()) {
           line = fileScan.nextLine();
           array[count] = line;
           count++;
           }
                for (String num : line){
	        System.out.println(num);
                }

fileScan.close();

	}
}

The

 while (fileScan.hasNext()) {
           line = fileScan.nextLine();
           array[count] = line;
           count++;
           }

is incorrect.. any help appreciated! :)

[Fubarable]

One issue is that your hasNext should match your next. You're checking hasNext() and then calling nextLine and the two don't match. In other words, if you are checking for next int, then you should use hasNextInt and inside the loop call nextInt. Same for hasNextDouble/nextDouble, hasNextLine/nextLine, and hasNext/next.

I suggest you check hasNextLine() and inside the loop use nextLine.

[venerik]

Hi,

Have you tried to compile this class? If you did the error messages should already have given some ideas of what is wrong with your code.

• line is declared an array so if you want to store one line in the array you have to provide an index: line[count] = filescan.nextLine();
• array has not been declared but you have no longer need for it either.
• count has not been declared and remember to initialise it after declaration.

There is a functional errors in your code as well which the compiler cannot tell you. Have a good look at the Scanner methods you use. They do not match.

I hope this helps,
Good luck!

Oh well, Fubarable made a comment about the scanner methods already...

[ls7897]

Am I any closer?

import java.util.Scanner;
import java.io.File;

class test{
	public static void main (String args[])throws Exception{
		File myFile = new File("alice.txt");  
		Scanner fileScan = new Scanner(myFile);  
	
		String[] line = new String[20];

 while (fileScan.hasNextLine()) {
           line[count] = fileScan.nextLine();
           count++;
           }
           while (count <= 20);
for (String num : line){
	System.out.println(num);
}
fileScan.close();
	}
}

My head is starting to hurt now... :p

Errors I'm getting are

test.java:12: cannot find symbol
symbol  : variable count
location: class test
           line[count] = fileScan. nextLine();
                ^
test.java:13: cannot find symbol
symbol  : variable count
location: class test
           count++;
           ^
test.java:15: cannot find symbol
symbol  : variable count
location: class test
           while (count <= 20);
                  ^

[venerik]

Re-read my previous reply (especially the third bullet :))

[ls7897]

I have no idea how declare and initialise the count..... :confused:
I started Java about 3 weeks ago and am learning very slowly... :p

[ls7897]

Ok, I know i'm being a pain, but I think this is what you mean...

import java.util.Scanner;
import java.io.File;

class test{
	public static void main (String args[])throws Exception{
		File myFile = new File("alice.txt");  
		Scanner fileScan = new Scanner(myFile);  
	
		String[] line = new String[20];
		int count = 0;
 while (fileScan.hasNextLine()) {
           line[count] = fileScan. nextLine();
           count++;
           }

for (String num : line){
	System.out.println(num);
}
fileScan.close();
	}
}

It compiles, but I get error...

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 20
	at test.main(test.java:12)

[mine0926]

String[] line = new String[20];

I think the line of the file that you load is greater than the lenght of your array.

[venerik]

Sorry for causing any pain... while I was writing my first reply I considered to warn you for this but somehow I didn't.

The error occurs because the program tries to access the array element with index 20. The size of your array is 20 meaning the highest accessible index is 19 (the index starts with 0).

I leave it up to you to come up with a solution to prevent this error...

Success!
Erik.

[ls7897]

Ok, I've added while (count<=19);

BUT

it compiles fine, when I run it, nothing happens, terminal just goes blank.....?

I know I'm being a pain, but I really appreciate it!

[Fubarable]

1) we don't know the context of your current problem. Where did you add this line of code?
2) Before coming here with every error immediately as it occurs, you will want to learn debugging techniques to help you learn to fix it yourself. For instance you'll probably want to sprinkle your code with println statements so you can see what is happening at each step of your code.

[ls7897]

import java.util.Scanner;
import java.io.File;

class test{
	public static void main (String args[])throws Exception{
	File myFile = new File("alice.txt");  
	Scanner fileScan = new Scanner(myFile);  
	
	String[] line = new String[20];
	int count = 1;
 
 	while (fileScan.hasNextLine()) {
    line[count] = fileScan. nextLine();
    count++;
    while (count<=5);
	}
	for (String num : line){
	System.out.println(num);
	}
fileScan.close();
	}
}

This is the source code. It compiles, but when I run it, the cursor just blinks and nothing happens...

[Fubarable]

This line makes no sense:

 while (count<=5);

It is equivalent to this bit of code:

while (count <= 5) {
  ;
}

Since count does not change in this loop, it will loop for ever. Get rid of that line.

[ls7897]

This line makes no sense:

 while (count<=5);

It is equivalent to this bit of code:

while (count <= 5) {
  ;
}

Since count does not change in this loop, it will loop for ever. Get rid of that line.

I changed the code to what you said, but I cannot delete it as there is over 20 lines in the text document it is reading and if I get rid of while
(count <= 5) {
;
}
then it will not compile as there's more lines then the array... ?

[Fubarable]

I changed the code to what you said,

Changed it how?

but I cannot delete it as there is over 20 lines in the text document it is reading and if I get rid of while
(count <= 5) {
;
}
then it will not compile as there's more lines then the array... ?

But that line serves no useful purpose other than to cause an infinite loop. Surely that's not what you want there is it?

[Fubarable]

Also, please please fix your code's indentation. It is very difficult to read with its current random indents.

[ls7897]

Changed it how?



But that line serves no useful purpose other than to cause an infinite loop. Surely that's not what you want there is it?

Ok, so I delete that line all together and change the array to 609 (because there is 609 lines in the text document).
How do I print just 20 lines?

[Fubarable]

Also, I wonder if Java is looking for your alice.txt file where you think it is.

To find out where Java is looking, put a debug System.out.println statement in your code (see I told you they'd be handy!), something like this:

      File myFile = new File("alice.txt");
      System.out.println(myFile.getAbsolutePath()); // [color="red"]add this line![/color]

[Fubarable]

Ok, so I delete that line all together and change the array to 609 (because there is 609 lines in the text document).
How do I print just 20 lines?

What's the standard way to loop 20 times?

[ls7897]

Edit

Let me try work that one out. :p