tetris type game--- boundary help

[ftrengnr]

i am working on a tetris type game and i have the game board drawn and i have a peice that falls and will go left and right however i cannot figure out how to do the boundaries. how to tell it not to exceed the width or fall below the bottom of the board. i have tried several ideas to no avail. then methods for boundaries are at the bottom of the BlocktrisGame class.... here is what i have so far...

import java.awt.Color;
import java.awt.event.KeyEvent;


public class BlocktrisGame
{
	private int x;
	private int y;
	private int width;
	private int height;
	public static final int BLOCK_SIZE = 25;
	
	public BlocktrisGame( int width, int height )
	{
		this.width = width;
		this.height = height;
	}
	
	//TODO write rest of BlocktrisGame methods (e.g. init, getX, setX, etc. etc.)
	
	//set x method
	public void setX(int x){
		this.x = x;
	} 
	
	//get x method
	public int getX(){
		return x;
	}
	
	//set y method
	public void setY(int y){
		this.y = y;
	}
	
	//gt y method
	public int getY(){
		return y;
	}
	
	//get height method
	public int getHeight(){
		return height;
	}
	
	//get width method
	public int getWidth(){
		return width;
	}
	
	//init method
	protected void init(Draw d){
		d.setColor(Color.green);
		d.drawRectangle(5, 5, width * BLOCK_SIZE + 2, height * BLOCK_SIZE + 2);
	}
	
	public void drawActivePeice(Draw d){
	
		d.fillRectangle(6 + x * BLOCK_SIZE, 6 + y * BLOCK_SIZE, BLOCK_SIZE - 2, BLOCK_SIZE - 2);
		d.draw();
	}
	
	public boolean isActivePeiceFallen(){
		boolean isFallen = false;
		if(this.y <= height){
			isFallen = true;
		}
		return isFallen;
	}
	
	public boolean isActivePieceOutOfBounds(){
		boolean isOutOfBounds = true;
		if(this.x < width){
			isOutOfBounds=false;
		}
		return isOutOfBounds;
	}

	
	public static void main( String[] args )
	{
		Draw d = new Draw( "Blocktris", 400, 410 );
		d.setColor( Color.white );
		
		
		//start the timer
		d.startAnimation( 300 );
		
		BlocktrisGame game = new BlocktrisGame( 10, 16 );
		game.init( d );
		d.draw();
		
		for( int event : d.getEventIterable() ) {
			if( event == KeyEvent.VK_LEFT ) {
				//move block to the left
				//TODO erase the block
				d.setColor(Color.black);
				game.drawActivePeice(d);
				game.setX( game.getX() - 1 );
				if( game.isActivePieceOutOfBounds() ) {
					game.setX( game.getX() + 1 );
					
				}
				//TODO draw the block
				d.setColor(Color.white);
				game.drawActivePeice(d);
				
			}
			else if( event == KeyEvent.VK_RIGHT ) {
				//TODO move block to the right
				d.setColor(Color.black);
				game.drawActivePeice(d);
				game.setX(game.getX() + 1);
				if( game.isActivePieceOutOfBounds()){
					game.setX(game.getX() + 1);
				}
			
			}
			else if( event == Draw.TIMER_EVENT ) {
				//make the block fall down
				//TODO erase the old block
				d.setColor(Color.black);
				game.drawActivePeice(d);
				game.setY( game.getY() + 1 );
				if( game.isActivePieceOutOfBounds() ) {
					game.setY( game.getY() - 1 );
					//TODO draw the current block
					d.setColor(Color.white);
					game.drawActivePeice(d);
					//TODO start a new block at the top,
					//means we need to set X and Y
					game.setX(0);
					game.setY(0);
					
				}
				//TODO draw the block
				d.setColor(Color.white);
				game.drawActivePeice(d);
			}
			
		}
		d.draw();
	}
}

Moderator Edit: Code tags added

[ftrengnr]

do not know y everything aligned left it was all indented before i posted it .... sorry

[venerik]

Adding code tags around the code keeps the indenting in tact.

Erik

[Fubarable]

You've got 3 previous threads where you've gotten helpful replies but never bothered to reply back or thank those that helped you. Since we'll never know if you read any of the stuff we post, why should we respond?

[ftrengnr]

i am sorry i am new to this... if this even gets to you... i am unaware of how to respond to helping people

[ftrengnr]

test... is this how i respond to a person

[ftrengnr]

ok guess not.... if someone could tell me how to respond back to a poster that would be great... didnt mean to offend neone

[Fubarable]

I've added code tags to your code to help make it readable. To learn how to do this yourself, please see the link in my signature.

To check for boundary issues, you'll need to know the size of your piece, then check to see if when you move the piece it has crossed any boundaries -- usually done with if blocks. The position of most graphic objects in most graphics systems is the upper left corner, so this number can be use to check for left and top boundary violations. The right side will require that you check the x position plus the piece width compared to the right boundary and the bottom check will require that you check the y position plus the height compared to the bottom boundary.

Your current graphics library doesn't look like one I'm familiar with, so I cannot say with 100% confidence that these recommendations will apply to you. If you need more help, you may need to supply more code.

One suggestion that I know does apply is that you're often better off separating out the logic issues from the GUI issues by creating a non-GUI model that has all the game logic, and then using this model to guide the drawing of the graphics. If you divide and conquer, you can simplify your problems and make the easier to solve.

Oh, and to reply you simply reply in the thread that the question was asked as you are doing now.

Luck!

[ftrengnr]

thank you for your input (is this the proper way to do this?).... once i was able to talk it out w/ someone that knew what i was saying i actually figured out all but one problem on my own (i happen to be proud of that fact)... but ur advice would have tipped me into the right direction.. thank you again for your post it was helpful!

[ftrengnr]

how do i mark this as solved now?

[Singing Boyo]

Top of the thread, theres a menu called 'Thread Tools'. Should be a mark as solved button in that menu.

[ftrengnr]

tnx for the info