Check if a string contains characters entered in a array

I would determine if a string entered by the user contains only characters in the table lettresAleatoires. If a letter is different, it rejects what he wrote and asked to enter another string. Here's what I wrote until now, the code in the method verifierSiValide () is missing and this is the method I want to audit.

Code:

---

  private final static char[] lettresAleatoires =
    {
        'R', 'B', 'O', 'V', 'J', 'F', 'I', 'N'
    };
 
  private static void demanderCombinaison() throws IOException
    {
        do
        {
            System.out.println("Entrez votre combinaison pour l'essai " + essai
                    + " <enter> pour arrêter");
            CombinaisonEntree = r.readLine();
        } while (CombinaisonEntree.length() != 4);
    }
 
    private static void verifierSiValide()
    {
    }

---

In verifierSiValide you could go through every character in the entered line and check whether it is present in lettresAleatoires.

I don't think lettresAleatoires should be an array of chars. You could use a String in stead.

Cheers,
Erik

Quote:

---

Originally Posted by venerik

I
I don't think lettresAleatoires should be an array of chars. You could use a String in stead.

---

Why not use an array?


To the original poster, should the method verifierSiValide return void, or would it be better to return a boolean so you could use it's result elsewhere in your program?

Quote:

---

Originally Posted by Fubarable

Why not use an array?

---

It is not necessary to use an array of course but using a String and indexOf(characterToValidate) on that string makes neat code.

Erik

Quote:

---

Originally Posted by Fubarable

Why not use an array?

---

Because arrays are so Fortranesque and are soo old fashioned and impose 'mechical' step by step solutions. Regular expressions and Strings allow for a one line decision method instead of all those silly loops.

kind regards,

Jos