Problem in storing Socket class object in ArrayList array

[Anoop]

:rolleyes: M new to java... So i want to know the problem in my code..
Im trying to create a public chat server. but facing an error when i compile it.
Error is:-
ERROR is:-
Note: done.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

Code:-

import java.io.*;
import java.net.*;
import java.util.*;

class MyServer
{
ServerSocket sskt;
Socket s;
ArrayList al=new ArrayList();

public MyServer()
{
try
{
sskt=new ServerSocket(10);

System.out.println("\n\nServer Started");

while(true)
{
s=sskt.accept();
System.out.println("\n\n\t"+s);
al.add(s);

Runnable r=new Mythread(s,al);
Thread t=new Thread(r);
t.start();
}
}catch(Exception e){System.out.println(e);}

}//myServer

public static void main(String s1[])
{
new MyServer();
}

}//myserver

class Mythread implements Runnable
{
ArrayList al;
Socket s;



Mythread(Socket s,ArrayList al)
{
this.al=al;
this.s=s;
}
public void run()
{
try
{
DataInputStream din=new DataInputStream(s.getInputStream());
String str;
do
{
str=din.readUTF();
if(!str.equals("stop"))
telleveryone(str);

else
{
DataOutputStream dout=new DataOutputStream(s.getOutputStream());
dout.writeUTF(str);
dout.flush();
}
}while(!str.equals("stop"));
}catch(Exception e)
{System.out.println(e);}
}//run

public void telleveryone(String str)throws IOException
{
Iterator i=al.iterator();
while(i.hasNext())
{
try
{
Socket s=(Socket)i.next();
DataOutputStream dout=new DataOutputStream(s.getOutputStream());
dout.writeUTF(str);
dout.flush();
}
catch(Exception e)
{System.out.println(e);}
}//while
}//telleveryone
}//mythread



So please tell me what should I do to solve this error:o

[eRaaaa]

That is no error, thats only a note

So please tell me what should I do to solve this error:o

Use generics. Replace each ArrayList with ArrayList<Socket> (or List<Socket) and change Iterator to Iterator<Socket>.

Hf

[JosAH]

You're using old fashioned collections, the ones that store and retrieve Objects and nothing else; you should use generic collections, e.g. if you want to store objects of type T in a collection you have to tell the to the compiler: List<Socket>= new ArrayList<Socket>() creates a List that can store objects of type Socket. Read all about it in the 'generics' section(s) of the tutorials.

kind regards,

Jos

edit: darn, too slow again ;-)