Finding maximum number at index position

[Shyamz1]

Hi, I've created a program and it seems to find the maximum value when a number of command line arguments are entered but i cannot get it to also print the index of which value it is:

for (int i=0; i < args.length; i++)
{
double aValue = Double.parseDouble(args[i]);

if (aValue > max)
{
max = aValue;
largestIndex = i;

}

largestIndex = i;

}

//System.out.println(max + largestIndex);

[Zack]

That's because you're adding them numerically.

System.out.println(2 + 5); // prints 7
System.out.println(2 + "" + 5); // prints 25
System.out.println(2 + " and " + 5); // prints 2 and 5

[Shyamz1]

No i've just put it like that jsut to test, but the actual print output is:

System.out.println("The maximum value is " + max + " which is on index " + largestIndex);

I'm presuming it still wouldnt make a difference.

I keep getting the error that largestIndex might not be initialized.

[JosAH]

... and that second 'largestIndex = i;' should go.

kind regards,

Jos

[Shyamz1]

what about that. Where would it go? I do need that dont i, because then the value wont be assigned to largestIndex because i is in the loop.

[al_Marshy_1981]

initialise largestIndex to 0 before the loop

[Shyamz1]

It works, but it outputs the wrong index value..

[JosAH]

what about that. Where would it go? I do need that dont i, because then the value wont be assigned to largestIndex because i is in the loop.

It should go to the bit bucket because you don't need it nor do you want it. If you want to find the largest number in an array keep track of the index of the largest number so far. You can set the index at, say, -1 if you haven't found any number yet. Otherwise compare a current number with array[index] where index is the index of the largest number in the array so far and update it if necessary. In code it translates to this:

int maxIndex(double[] array) {
   int index= -1;
   if (array != null)
      for (int i= 0; i < array.length; i++)
         if (index == -1 || array[i] > array[index])
            index= i;
   return index;
}

kind regards,

Jos

[Shyamz1]

I have yet learnt about array. I've only learnt about args so far.

[JosAH]

I have yet learnt about array. I've only learnt about args so far.

Which is also an array ... an array of String to be exact ;-)

kind regards,

Jos