problem regarding FileReader

[mukeshpaliwal]

my program is compiled and executed but output is getting different.
instead of reading file it is reading file infinetly.plz help me.not understanding hw to solve dis problem .
i m submmiting my program here.






import java.io.*;
class filedemos
{
public static void main(String args[])
{
try
{
FileReader fr=new FileReader(args[0]);
try
{
FileWriter fw=new FileWriter(args[1]);
try
{
char b[]=new char[128];
String line=String.valueOf(fr.read(b));

while(!line.equals(1))
{
fw.write(b,0,line.length());
line=String.valueOf(fr.read(b));
}
}
finally
{
fw.close();
}
}
finally
{
fr.close();
}
}
catch(IOException e)
{
e.printStackTrace();
}
}
}

[Zack]

Posting your code in [code] tags helps preserve formatting to make things easier to read:

import java.io.*;
class filedemos 
{
	public static void main(String args[]) 
	{
		try
		{
			FileReader fr=new FileReader(args[0]);
			try
			{
				FileWriter fw=new FileWriter(args[1]);
				try
				{
					char b[]=new char[128];
					String line=String.valueOf(fr.read(b));

					while(!line.equals(1))
					{
						fw.write(b,0,line.length());
						line=String.valueOf(fr.read(b));
					}
				}
				finally
				{
					fw.close();
				}
			}
			finally
			{
				fr.close();
			}
		}
		catch(IOException e)
		{
			e.printStackTrace();
		}
	}
}

As for the issue, what are the contents of the file you are reading?

[Norm]

it is reading file infinetly

What code do you have to stop the program from looping forever? When will the condition be false to let the code exit the loop?
Try debugging you program by printing out the contents of line inside of the while loop.

NOTE TO ALL: Here is an example of autoboxing that is confusing the OP and others about how the code is compiling. The int in the equals is being changed to an Integer object. Compile it in an older version of the compiler and you get:

Value for argument 1 cannot be converted from 'int' in call to 'boolean String.equals(Object)'

[mukeshpaliwal]

actually the problem is my program is reading the file and also writing it to new .txt file file but output i m getting is different
i will give u one example:if my file named d.txt contain data like "i am very good person".now i want to write this file into another file. during runtime i have specified name of two file like:java filedemos d.txt f.txt.but what output i m getting is as follow:when i check file f.txt it contains "i m very good person" writing repeatedly means writing content infinitely in f.txt.it is not finishing its process.output is as follow:

"i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person""i m very good person"............going infinitely not stopping...dis is the problem..

[Norm]

Did you read my post about the loop in your program?

[mukeshpaliwal]

i just debugged my program as u said but havent understud wat is happening.
program just copied first 3 letter of file to b read.and on compiler it is giving true.
so please make me explain in detail or sort out the problem yourself

[masijade]

Aside from the fact that read returns -1 and not 1, the number inside that equals should be

"-1"

and not just

-1

. When it is just a plain number then it is an int and not a String. That int automatically gets autobxed into an Integer since it is being used in a place where an Object is needed. Also, since the equals method signature excepts all object types and not just Strings an Integer is valid in that position. But, since an Integer is not a String that equals method will always return false. So the expression always returns true because of the ! at the beginning.

[Norm]

sort out the problem yourself

Its not my problem.

Did you read my post about the loop in your program?