Printable View
So I'm lost on how to do my linear search with an input search file. I've sorted it and got everything else done fine, just can't grasp how this search is supposed to look and where I'm supposed to even start with it.
I have 43 countries that I am to search for hits or no hits based on the country code and I have to say how many probes were used in finding the matches. The input search file has these 10 searchkeys:
CH
In
ZZ
LA
LA
PH
MO
OO
OM
ye
I can post code if need be. Thanks in advance :)
Um... without code, how can we guess what you're doing wrong?Quote:
Originally Posted by Metastar
I haven't done any code for the search because I'm not sure how to start it. I'll post what I have though. I attempted to put the searchkeys into an array but I don't think it's right :/
Code:public class Main
{
/**
* @param args the command line arguments
*/
public static void main(String[] args) throws java.io.IOException
{
FileInputStream fis1= new FileInputStream("AsiaCountries.Fall2010.txt");
BufferedReader br1= new BufferedReader(new InputStreamReader(fis1));
String inline;
int index = 0, index2 = 0;
String[] searchKey = new String[11];
Country[] myCountries;
myCountries = new Country[43];
Sort mySort = new Sort();
Country[][] myCountries2 = new Country [4][];
myCountries2[0] = new Country [6];
myCountries2[1] = new Country [7];
myCountries2[2] = new Country [10];
myCountries2[3] = new Country [11];
while ((inline = br1.readLine()) != null)
{
myCountries[index] = new Country(inline);
index++;
} // end while
System.out.println("Country Name Country Capital " +
" Country Region Name Region # "
+ "Country Abbreviation ");
System.out.println("~~~~~~~~~~~~ ~~~~~~~~~~~~~~~ "
+ "~~~~~~~~~~~~~~~~~~~ ~~~~~~~~ "
+ "~~~~~~~~~~~~~~~~~~~~");
//Formatted printout of myStates array
for(int count=0; count < index; count++)
{
System.out.println(myCountries[count]);
}//end for
mySort.bubbleSort(myCountries);
System.out.println("Sorted Array by Country Name\nCountry Name "
+ " Country Capital " + " Country Region Name "
+" Region # " + "Country Abbreviation ");
System.out.println("~~~~~~~~~~~~ ~~~~~~~~~~~~~~~ "
+ "~~~~~~~~~~~~~~~~~~~ ~~~~~~~~ "
+ "~~~~~~~~~~~~~~~~~~~~");
for(int count=0; count < index; count++)
{
System.out.println(myCountries[count]);
}//end for
FileInputStream fis2= new FileInputStream("Search.Fall2010.txt");
BufferedReader br2= new BufferedReader(new InputStreamReader(fis2));
while ((inline = br2.readLine()) != null)
{
searchKey[index2] = new String (inline);
index2++;
} // end while
System.out.println(index2);
System.out.println(searchKey[index2]);
}//end main()
}//end Main
Code:public class Country
{
private String countryName, countryCapital, countryRegion, countryAbbrev;
private int countryRegionNum;
public static int countryObjCounter;
public Country(String countryInput)
{
countryName = countryInput.substring(0,17).trim();
countryCapital = countryInput.substring(21,40).trim();
countryRegion = countryInput.substring(44,55).trim();
countryRegionNum = Integer.parseInt(countryInput.substring(63,65).trim());
countryAbbrev = countryInput.substring(66,68).trim();
countryObjCounter++;
}//end parseData Constructor()
public String getCountryName()
{
return countryName;
}//end getCountryName()
public String getCountryCapital()
{
return countryCapital;
}//end getCountryCapital()
public String getCountryRegion()
{
return countryRegion;
}//end getCountryRegion()
public int getCountryRegionNum()
{
return countryRegionNum;
}//end getCountryRegionNum()
public String getCountryAbbrev()
{
return countryAbbrev;
}//end getCountryAbbrev()
public String toString()
{
return String.format("%-23s %-30s %-24s %-16d %-4s\n",
countryName, countryCapital,countryRegion, countryRegionNum,
countryAbbrev);
}//end toString()
}
Code:public class Sort
{
public void bubbleSort(Country[] myCountries)
{
int out, in;
for (out=myCountries.length - 1; out>1; out--)
for (in=0; in<out; in++)
if( myCountries[in].getCountryName().compareTo
(myCountries[in+1].getCountryName())>0 )
swap (in, in+1, myCountries);
}//end bubbleSort()
private void swap(int one, int two, Country[] myCountries)
{
Country temp = myCountries[one];
myCountries[one] = myCountries[two];
myCountries[two] = temp;
}//end swap()
}//end Sort
What do you want to search, a file? How is your file structure? And what are you looking for?
I didn't get that.
I have 2 files I'm using, the first has 43 countries in it with the country name, capital, region(1,2,3, or 4), and country abbreviation. The second has 10 2 character country codes that have some matching the 43 country codes and some not. Also some are all caps, some are 1 cap and a lowercase, and some are all lowercase(have them above).
I want to do a linear search with the second file searching for matches or no matches to the 10 searchkeys in the second file in comparison to the 43 two character country codes in the first file. I have all 43 countries parsed by the attributes said above(name, capital, etc.) in an array. Later on I am going to put them into a jagged array by country region(that's why I have the 2d array up top but not used anywhere in main yet).
Linear search means use a simple for loop.
Would it be a nested for to go through 2 arrays? Or is that way off?
That's way off. I usually use nested for loops for a 2-dimensional array, not two one-dimensional arrays. Best thing for you to do: just give it a try with a for loop. You've got nothing to lose by making an attempt.Quote:
Originally Posted by Metastar
That's true, I'll give it another go.
I now have this
But I still have errors and it's driving me nuts.Code:public String linearSearch(Country[] myCountries, int first1, int last1,
String searchKey)
{
for(int i = 0; i < myCountries.length; i++)
{
boolean success;
success = linearSearch(myCountries, int first2, int last2, String input[i]);
System.out.println("Success: " + success + " " + myCountries[j].getCountryCode());
}//end for
}//end linearSearch
Please copy-and-paste the exact error messages received (do not trim or crop them at all).Quote:
Originally Posted by Metastar
I cant post the error msg here because its in a seperate class other than my main so i cant run it. it just says:
unexpected type
'.class' expected
';' expected
';' expected
';' expected
not a statement
unexpected type
required: value
found: class
I've gotta take a break from it for tonight I'm just making it alot harder than it is and I've been working on this same small program for about 7 hours today. If you can think of anything please let me know and I'll check it out in the morning. Thanks in advance :)
The error is probably originating from this line:
There's 6 problems:Code:linearSearch(myCountries, int first2, int last2, String input[i]);
1) first2 isn't a variable
2) last2 isn't a variable
3) You're trying to declare first2 as an int variable as a parameter (existing parameters should be passed, not declared in a function call)
4) Same issue with last2
5) Same with input[i]
6) input isn't a variable
Perhaps some of this (such as 1, 2, and 6) are solved in code that you didn't paste.
When posting code or errors, they have to include line numbers so we know what part of the code you're talking about. Otherwise it's just guesswork, which can waste our time and yours.
Taking the night away was what I needed hah. Figured it out pretty easily this morning after taking a look at your post Zack. I hadn't left any code out, everything you saw on the thread was all I had. Wasn't realizing what I had put in as the parameters and that I had put input for my searchkey array. Thanks for the help :)
And I'll be sure to include line numbers in future threads :)