while and proper conditions for if

[Saletra]

Hello all:)

I'm trying to write script which change var depending on other var value:

while(true){
[B]if(kasa1.klienci.size()>= 5 && kasa2.czynne == false){[/B]
kasa2.czynne = true;
System.out.println("!!!!!!!!!!!Otwieram kase 2");
continue;
}
[B]else if(kasa2.klienci.size()== 0 && kasa2.czynne== true){ //when kasa2.klienci.size()== 0 i want this for once[/B]
kasa2.czynne = false;
System.out.println("!!!!!!!!!!!!Zamykam kase 2");
continue;
}

This is working with help from Thread. If kasa1.klienci.size() is more than 5 it's changing kasa2.czynne to true. Var kasa2.klienci.size() is default 0 but it's increasing with other Thread and then reach 0 again. When it happens I want to set kasa2.czynne to false and get info.

/edit: works good for e.g. with else if(kasa2.klienci.size()== 0 && kasa2.czynne== true && kasa1.klienci.size()== 0) but it's not exactly what I want.

[Norm]

Try debugging the code by adding println() to show the values of all the variables.
Then you can see how they are changing and then figure out how to modify your code to have it do what you want.


Can you write what you want to do in pseudo code?

[Saletra]

endless loop:
check if kasa1.klienci.size() is more than 5 -> kasa2.czynne = true;
check if kasa2.klienci.size()== 0 ("no other clients in cashbox") -> kasa2.czynne = false;

problem is that kasa2.klienci.size() default is 0, and then clients are comming to kasa2 (via Threads), finally kasa2.klienci.size() is 0 again and has to be closed.

[Norm]

All I can recommend is what I say before that you try to debug your code by:

Try debugging the code by adding println() to show the values of all the variables.
Then you can see how they are changing and then figure out how to modify your code to have it do what you want.
For example, add this before the start of the if:
System.out.println('k1k.size=" + kasa1.klienci.size() + ", kasa2.czynne=" + kasa2.czynne + " , k2k.size=" + kasa2.klienci.size());

[Saletra]

Thanks.

The thing is that I know exactly what values I have. Problem is that if sections are repeated and repeated becouse they haven't got proper conds for end repeating.

Now I have:

if(kasa1.klienci.size()>= 5 && kasa2.czynne == false){
kasa2.czynne = true;
System.out.println("!!!!!!!!!!!!Otwieram kase 2!!!!!!!!!!!!!!!!!!!");
continue;
		}
else if(kasa2.klienci.size()== 0 && kasa2.czynne== true && kasa1.klienci.size()== 0){
kasa2.czynne = false;
System.out.println("!!!!!!!!!!!!Zamykam kase 2!!!!!!!!!!!!!!!!!!!");
continue;
		}
else if(kasa2.klienci.size()>= 5 && kasa2.klienci.size() <10){
kasa3.czynne = true;
System.out.println("!!!!!!!!!!!!Otwieram kase 3!!!!!!!!!!!!!!!!!!!");
continue;
		}

In some moment I see:

!!!!!!!!!!!!Otwieram kase 3!!!!!!!!!!!!!!!!!!!
!!!!!!!!!!!!Otwieram kase 3!!!!!!!!!!!!!!!!!!!
!!!!!!!!!!!!Otwieram kase 3!!!!!!!!!!!!!!!!!!!
!!!!!!!!!!!!Otwieram kase 3!!!!!!!!!!!!!!!!!!!
!!!!!!!!!!!!Otwieram kase 3!!!!!!!!!!!!!!!!!!!
!!!!!!!!!!!!Otwieram kase 3!!!!!!!!!!!!!!!!!!!
!!!!!!!!!!!!Otwieram kase 3!!!!!!!!!!!!!!!!!!!

I dont want stop loop but use every if just once.
I know I can figure it out by myself but thanks for any advices.

[Saletra]

Ok, I've got it, I added new int with number which determine which cashbox should be opened.

[Norm]

they haven't got proper conds for end repeating.

One problem you have with your code is the endless loop waiting for other threads to do something. You need to change your logic to use some other logic for inter thread communications. Look at the java.util.concurrent package. Look at CountDownLatch or Semaphore for example.

Your printout does NOT show the values of any of the variables. It only shows a constant message. There are 4 variables used in the loop.

[Tolls]

Can I recommend you use proper indenting for your code as well?

[Saletra]

Yes, please, couse I'm still having problems with this. Now i'm working with:

	if(Bank.LICZNIK== 5 && kasa2.czynne== false){
			kasa2.czynne = true;
			System.out.println("Open cashbox 2");
			continue;
		}
		else if(Bank.LICZNIK== 15 && kasa3.czynne== false){
			kasa3.czynne = true;
			System.out.println("Open cashbox 3");
			continue;
		}
		else if(Bank.LICZNIK == 40 && kasa4.czynne== false){
			kasa4.czynne = true;
			System.out.println("Open cashbox 4");
			continue;
		}
		else if(kasa2.klienci.size()== 0 && kasa2.czynne== true){
			kasa2.czynne = false;
			System.out.println("Close cashbox 2");
			continue;
		}
		else if(kasa3.klienci.size()== 0 && kasa3.czynne== true){
			kasa3.czynne = false;
			System.out.println("Close cashbox 3");
			continue;
		}
		else if(kasa4.klienci.size()== 0 && kasa4.czynne== true){
			kasa4.czynne = false;
			System.out.println("Close cashbox 4");
			continue;
		}
		}

Bank.LICZNIK - number of active clients. I want to open next cashboxes depending on this number.
When there are no clients at cashbox (klienci.size()== 0) it should be closed. Var klienci.size()== 0 default is 0 :/

[Tolls]

Honestly, indent your code!

[Saletra]

Like this?

[Tolls]

That's better.
Can actually see the flow now, rather than simply a slab of stuff.