Help needed with string manipulation

[stringkilla]

no. sorry but your comments do not seem logical to me.

i am under the influence that my code (posted in comment #15) SHOULD print "ab" IF i type "ab" when prompted to "Enter a sentence"

now, if i run the program (after your suggested code amendment in post #18 is implemented) and type "ab", i get this:

Enter a sentence:
ab
[a]


notice the "[a]" being printed instead of my DESIRED output string of "ab".

as for you responding to my help request as: "If that's not what you want you should change your program code." this is really not helping, as i am asking for help to do just that.

[Norm]

Can you explain what the following statement is supposed to be doing?
if(current == 'a' && current+1 == 'b')
As JosAH says, this makes no logical sense. The second part of the condition will always be true if the first part is. Did you intend to look at the next char in the String: input?

[stringkilla]

yes norm i did intend to look at the next char in the String: input.

i am intending it to do this:

if char at position x is "a", and the next char preceding "a" is "b" then output becomes "" plus "ab" or in other words, output becomes "ab" if the user types "ab" making the if statement true.

[Norm]

if char at position x is "a", and the next char preceding "a" is "b"

I assume you mean: if char at position x is "a", and the next char following "a" is "b"
In your code you get the char at location count by this: 'current = input.charAt(count);'
So using the same method you need to get the char at count+1
Be sure to test if the String: 'input' is long enough that there is a character at count+1

[JosAH]

as for you responding to my help request as: "If that's not what you want you should change your program code." this is really not helping, as i am asking for help to do just that.

I get the impression that you want us to do the code for you because you completely ignored my hint about that silly if-condition. You shouldn't ignore anything at all if you want the help you get to be useful.

kind regards,

Jos

[stringkilla]

this is all i can come up with and am having no luck. any more suggestions?

for (int count = 0; count <length; count++)
{
current = input.charAt(count);
if(current == 'a' && (current+1) == 'b')
{
output = output + current;
System.out.print(output);

[stringkilla]

didnt get the hint either sorry :(

[Norm]

if(current == 'a' && (current+1) == 'b')
That's exactly the same as the previous code with the exception of the added ()s
Where is the character you want to look at next?
How do you get the character that is in the 'current' variable?
Look at the code that gets the value of 'current'.
You want to get another character from the same source(the String 'input'), but one column over.

[stringkilla]

if(current == 'a' && input.charAt(count+1) == 'b') ???
doesnt seem to do it.

[JosAH]

if(current == 'a' && input.charAt(count+1) == 'b') ???
doesnt seem to do it.

Better already but don't start guessing; as Norm already indicated be careful with your loop boundaries.

kind regards,

Jos

[stringkilla]

for (int count = 0; count <length; count++)
{
current = input.charAt(count);
if(current == 'a')
(
output = output + curent;
)

current = input.charAt(count+1);
if(current == 'b')
(
output = output + curent;
System.out.print(output);
)
}

this is not a guess, im just trying to do what you suggest and put something outside the boundaries. again, not what i want.

i only want 'ab' to be printed only if 'b' is the next letter after 'a'.

[JosAH]

for (int count = 0; count <length; count++)
{
current = input.charAt(count);
if(current == 'a')
(
output = output + curent;
)

current = input.charAt(count+1);
if(current == 'b')
(
output = output + curent;
System.out.print(output);
)
}

this is not a guess, im just trying to do what you suggest and put something outside the boundaries. again, not what i want.

i only want 'ab' to be printed only if 'b' is the next letter after 'a'.

For one thing: this doesn't even compile (parentheses instead of curly brackets); think what would happen if count == length-1; you'd get an out of bounds exception when you try to fetch the character at position count+1.

kind regards,

Jos

ps. and please put your code in [code] ... [/code] tags for readability reasons.

[stringkilla]

i can understand this but cannot understand how this helps my code. and im sorry but i dont know how to post code properly.

think what would happen if count == length-1; you'd get an out of bounds exception when
you try to fetch the character at position count+1

for (int count = 0; count <length; count++)
{
current = input.charAt(count);
if(current == 'a' && current+1 == 'b')
{
output = output + current;
System.out.print(output);
}
}

[JosAH]

i can understand this but cannot understand how this helps my code. and im sorry but i dont know how to post code properly.

think what would happen if count == length-1; you'd get an out of bounds exception when
you try to fetch the character at position count+1

for (int count = 0; count <length; count++)
{
current = input.charAt(count);
if(current == 'a' && current+1 == 'b')
{
output = output + current;
System.out.print(output);
}
}

Any particular reason why you changed your code back again to that silly if-condition? You already know that it doesn't work that way.

kind regards,

Jos

ps. before you start typing your code type [code] and after you've finished typing your code type [/code]. There's also a 'Preview Post' button so you can see the result of what you did without posting (yet).

[Norm]

Try debugging your code by using some println() statements. For example you said
if(current == 'a' && input.charAt(count+1) == 'b') ???

doesnt seem to do it.

Add the following before the above if:
System.out.println("current=" + current + ", nextChar=" + input.charAt(count+1) + "<"); // show values

This will show the two characters that you are working with.

[stringkilla]

if (!(curr_char == prev_char || vowels.indexOf(curr_char)>= 0) || (intpunct.indexOf(curr_char)>= 0))
{
	input2 = input1.substring(i,i+1);
	output = output.concat(input2);
}
if ((vowels.indexOf(curr_char)>= 0) && (input1.charAt(i+1)==' '))
{
	input2 = input1.substring(i,i+1);
	output = output.concat(input2);
}

why do i get this? (and its only when i start or end the input string witha vowel.

Please enter a Sentence
like i
Exception in thread "main" java.lang.StringIndexOutOfBoundsException: String ind
ex out of range: 6
at java.lang.String.charAt(Unknown Source)
at assignment4.main(assignment4.java:39)

[JosAH]

if (!(curr_char == prev_char || vowels.indexOf(curr_char)>= 0) || (intpunct.indexOf(curr_char)>= 0))
{
	input2 = input1.substring(i,i+1);
	output = output.concat(input2);
}

why do i get this? (and its only when i start or end the input string witha vowel.

If the character at position i is a vowel and i is the last valid index value in the String I can imagine that looking at position i+1 or further would throw that Exception ...

kind regards,

Jos

[stringkilla]

if ((vowels.indexOf(curr_char)>= 0) && (input1.charAt(i+1)==' '))
	{
		input2 = input1.substring(i,i+1);
		output = output.concat(input2);
	}

it is this that is causing the error and im not sure of what to change it to. im aiming for this; if current char is a vowel and next char is a ' ', add both to output.

and suggestions?

[JosAH]

if ((vowels.indexOf(curr_char)>= 0) && (input1.charAt(i+1)==' '))
	{
		input2 = input1.substring(i,i+1);
		output = output.concat(input2);
	}

it is this that is causing the error and im not sure of what to change it to. im aiming for this; if current char is a vowel and next char is a ' ', add both to output.

and suggestions?

Yep, check if there actually is a next char ...

kind regards,

Jos

[stringkilla]

if ((vowels.indexOf(prev_char)>= 0) && (input1.charAt(i)==' '))
	{
		input2 = input1.substring(i,i+1);
		output = output.concat(input2);
	}

this doesnt work either?