Creating Temporary files using the createTempFile function problem.

[ArmenBaba]

Hello Fellow Coders,
So I'm fairly new to Java but I'm comming from a C# background, however that's not helping much.
Problem:
I create a temporary file, and download content from a URL and save it to that file. I use the createTempFile method to create the temp file in a specific folder called "temp", the file is created inside that directory but another copy is created in the java root directory (without my permission) and the content that is downloaded is placed in that copy! I don't understand why?

I create Temporary file using this statement:

//global variable in class
static File file_buffer; 
static int PdfFileNum = 1;
final String temp_directory = System.getProperty("user.dir").concat("\\temp\\");
...
String tempName = "tempPdf" + Integer.toString(PdfFileNum++);
File newFile = File.createTempFile(tempName, ".pdf", new File(temp_directory) );
file_buffer = newFile;
this.download(in_url,file_buffer);

and this is the download code

     public void download( String fileUrl, File destination ) throws MalformedURLException,IOException
    {
      if (fileUrl != null && destination != null)
      {
         BufferedInputStream bis = null;
         BufferedOutputStream bos = null;
         try
         {
            URL url = new URL( fileUrl );
            URLConnection urlc = url.openConnection();

            bis = new BufferedInputStream( urlc.getInputStream() );
            bos = new BufferedOutputStream( new FileOutputStream(destination.getName()) );

            int i;
            while ((i = bis.read()) != -1)
            {
               bos.write( i );
            }
         }
         finally
         {
            if (bis != null)
               try
               {
                  bis.close();
               }
               catch (IOException ioe)
               {
                  ioe.printStackTrace();
               }
            if (bos != null)
               try
               {
                  bos.close();
               }
               catch (IOException ioe)
               {
                  ioe.printStackTrace();
               }
         }
      }
      else
      {
         System.out.println( "Input not available" );
      }
   }

please help me!
-Armen

[JosAH]

bos = new BufferedOutputStream( new FileOutputStream(destination.getName()) );

Don't do that; do this instead:

bos = new BufferedOutputStream( new FileOutputStream(destination) );

You have created a temp file named, say, /tmp/tempfile1 and its name is tempfile1. Next you create an output file with the name tempfile1 which has nothing to do with the original file.

kind regards,

Jos

[ArmenBaba]

I love you JosAH.
I downloaded that code from somewhere without even checking the details. Let that be a lesson to me.
-Thank you