Object orientated problem

[alacn]

Hi i have two classes.

The first class extends a JFrame and implements various Listeners, i used it has my Gui.

The second class wants to be able to get the first classes x and y coords and height and width.
However when i try to create an object of the Gui class insided of my second class. Its creates another Gui.
How can i go about getting the Gui.getX() Gui.getY() etc without making another Gui appearing?
Is there a way inwhich i can just refence an exisiting objects attributes?

(its important i refence the original Gui object because its location may change, and creating a new Gui object would give me the defualt Gui startup location)

[alacn]

also is it possible to modify a JComponents values from another class?

i tried doing this code gui.scanProgress.setValue(loopC); from another class an no luck. This problem probably links in with the first post.

[JosAH]

Hi i have two classes.

The first class extends a JFrame and implements various Listeners, i used it has my Gui.

The second class wants to be able to get the first classes x and y coords and height and width.
However when i try to create an object of the Gui class insided of my second class. Its creates another Gui.
How can i go about getting the Gui.getX() Gui.getY() etc without making another Gui appearing?
Is there a way inwhich i can just refence an exisiting objects attributes?

(its important i refence the original Gui object because its location may change, and creating a new Gui object would give me the defualt Gui startup location)

Have a factory that can create (and remember) a Gui object for you. Something like this:

public final class GuiFactory {
   private GuiFactory() { } // nobody can create this factory
   private static Gui gui= new Gui(); // the one and only Gui object

   public static Gui getGui() { return gui; }
}

Ask the Gui factory to pass a refernce to the wanted Gui object and never create one yourself. Also read up on the Singleton pattern.

kind regards,

Jos

[alacn]

Hi, thanks for quick reply

I made the constructor private but then i was unable to make an object of the GuiFactory class and call the getGui method, so i made it public and created an object to the gulffactory in my 2nd class. then in the 2nd class i did this lines of code

    
App app = new App();
Gui gui = app.getGui();

but then i got a nullPointer Error when trying to use gui.

was i wrong in creating an object of the app class? i didnt know any other way to call the getGui method.

[alacn]

yeah i used System.out and the getGui method is returning null when it should be returning the gui object, any ideas?

[JosAH]

yeah i used System.out and the getGui method is returning null when it should be returning the gui object, any ideas?

I don't know what you did but I made the GuiFactory() constructor private for a reason: there is no need to create such an object. The getGui() method is static and public so you can simply call it like this:

Gui myGui= GuiFactory.getGui();

The Gui object itself has already been created in the static initialization code of the GuiFactory class.

kind regards,

Jos

[alacn]

still returns null. code below


rgb class

Gui guii = App.getGui();
System.out.println(guii);

app class

public final class App {
    public static Gui gui = new Gui();
    private App(){}

	public static void main(String[] args) {

         
           
           gui.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
	
	}
        public static Gui getGui() { return gui; }

}

[JosAH]

still returns null. code below


rgb class

Gui guii = App.getGui();
System.out.println(guii);

app class

public final class App {
    public static Gui gui = new Gui();
    private App(){}

	public static void main(String[] args) {

         
           
           gui.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
	
	}
        public static Gui getGui() { return gui; }

}

I bet you're calling a method from the rgb class from within the constructor of the Gui class ...

kind regards,

Jos

[alacn]

yeah i got a timer in the gui constructor which calls a method in the rgb class

[JosAH]

yeah i got a timer in the gui constructor which calls a method in the rgb class

That scenario doesn't work because the Gui object is still being constructed and assignment to that variable in your Factory hasn't been done yet. I suggest a 'two phase' construction:

1) the constructor creates the bare object
2) an init() method does all the initialization.

After 1) has finished the object is assigned in the Factory class and everything in phase 2) can call it in order to obtain the single Gui object.

kind regards,

Jos

[alacn]

i think my problem is solved, thanks josAH for your time :).

[JosAH]

i think my problem is solved, thanks josAH for your time :).

Good, you're welcome of course; the following just crossed my mind a couple of minutes ago: you can also move that creation and singleton business to the Gui class itself where the constructor can assign itself to the private static variable; like this:

public class Gui {
   private static Gui gui;
   // create a single Gui object:
   static {
      new Gui();
   }
   public static Gui getGui() { return gui; }
   ...
   private Gui() {
      Gui.gui= this; // assign yourself before doing anything else ...
      ...
   }
}

kind regards,

Jos

[alacn]

some crazy looking syntax tbh :eek:

[JosAH]

some crazy looking syntax tbh :eek:

There's nothing special about it: there's the private static gui variable and a public method to hand it over to something else. The Gui constructor assigns itself to that variiable before anything else happens. The static { } block is just a static initializer and executes just after the class has been loaded.

This scenario also avoids that ugly two phase construction because the gui variable is assigned a Gui object before anything else happens.

kind regards,

Jos