How to make my download class faster

Hi,

Currently I'm working on a small downloadmanager for personal use, it's working fine so far, except that it downloads rather slowly. My downloadmanager averages on about 170~ kb/s when downloading file, but when I download the same file regularly it downloads at 640~ kb/s.

My download function:

Code:

---

        public void Download() {
               
                try {

                        HttpURLConnection huc = this.Gethuc(this.FileLink + "?directstart=1");
                        InputStream is = huc.getInputStream();
                        FileOutputStream fos = new FileOutputStream(this.GetLocalFile());
                        this.SetFileSize(huc.getContentLength());

                        int SingleByte;
                       
                        while ((SingleByte=is.read()) != -1) {
                               
                                fos.write(SingleByte);
                               
                        }
                       
                        is.close();
                        fos.close();
               
                } catch (MalformedURLException e) {
                        System.err.println(e.toString());
                } catch (IOException e) {
                        System.err.println(e.toString());
                }
        }

---

Does anyone know a way to make it faster?

Thanks in advance.

Try reading thousands of bytes at a time vs only 1

Ye I fixed it by reading into a buffer. So basically what you said.

Code:

---

        public void Download() {
               
                try {

                        HttpURLConnection huc = this.Gethuc(this.FileLink + "?directstart=1");
                        InputStream is = huc.getInputStream();
                        FileOutputStream fos = new FileOutputStream(this.GetLocalFile());
                        this.SetFileSize(huc.getContentLength());
                       
                        final int bufferSize = 1024 * 512;
                        byte[] buffer = new byte[bufferSize];
                        int bytesRead;
                        long Time = System.currentTimeMillis();
                       
                        while ((bytesRead = is.read(buffer)) > 0) {
                               
                                fos.write(buffer, 0, bytesRead);
                               
                        }
                        System.out.println((System.currentTimeMillis() - Time)/1000);
                        is.close();
                        fos.close();
               
                } catch (MalformedURLException e) {
                        System.err.println(e.toString());
                } catch (IOException e) {
                        System.err.println(e.toString());
                }
        }

---

Quote:

---

Originally Posted by pietertje

Ye I fixed it by reading into a buffer. So basically what you said.

Code:

---

                        final int bufferSize = 1024 * 512;

---

---

Not that it matters much because any computer can easily handle a buffer size like that but normally the internal buffer size used by disk reads is 4KB or 8KB and is enough to accomplish a high throughput; try it and see for yourself.

kind regards,

Jos