Connection is busy with results for another hstmt

i got Problem in following code..


try {
enteruser = t4.getText();
enterpass = t1.getText();
newpass = t2.getText();
confirm = t3.getText();
PreparedStatement ps3 = con.prepareStatement("select * from sreg where username=?");
ps3.setString(1, enteruser);
ResultSet rs1 = ps3.executeQuery();
rs1.next();
getuser = rs1.getString(4);
getuser=getuser.trim();
getpass = rs1.getString(12);
getpass=getpass.trim();
System.out.println(getuser);
System.out.println(getpass);
System.out.println(enteruser);

if (enteruser.equals(getuser)) {
System.out.println(enterpass);


if (enterpass.equals(getpass)) {

PreparedStatement ps4 = con.prepareStatement("update sreg set choosepassword=?,repeatpassword=? where username=?");

ps4.setString(3, enteruser);
ps4.setString(1, newpass);
ps4.setString(2, confirm);

System.out.println(newpass);
ps4.executeUpdate(); /* I hope this is not working


System.out.println(confirm);
JOptionPane.showMessageDialog(this, "Successfully Updated");
} else {
JOptionPane.showMessageDialog(this, "Please Enter Correct Current Password");
}
} else {
JOptionPane.showMessageDialog(this, "Please Enter Correct Username");
}
} catch (SQLException ex) {
Logger.getLogger(password.class.getName()).log(Lev el.SEVERE, null, ex);
}





Everytime i run it ,it give error connection is busy..and is unable to update a table..
Somebody help please?

Thanks in Advance

Quote:

---

Originally Posted by amritpalpathak

ps4.executeUpdate(); /*This is not working

---

What happens if you close the ResultSet rs1 first?

kind regards,

Jos

After removing the line
ResultSet rs1 = ps3.executeQuery();

It gives error in following code,because its object rs1 is being used in these

rs1.next();
getuser = rs1.getString(4);
getpass = rs1.getString(12);




Thannks

System.out.println(newpass);
ps4.executeUpdate();

/*I hope this line is not working because new pass in coming in output but confirm not there,it means ps4.executeUpdate(); not working ,but why i d ont know reason,everything in the code in write ,i have checked i hundred of times

System.out.println(confirm);


Please Something solve this issue

Quote:

---

Originally Posted by amritpalpathak

After removing the line
ResultSet rs1 = ps3.executeQuery();

It gives error in following code,because its object rs1 is being used in these

rs1.next();
getuser = rs1.getString(4);
getpass = rs1.getString(12);

---

Nonono, that's not what I mean: after you got the data from rs1, close it by doing this:

Code:

---

rs1.close();

---

... and next execute your other PreparedStatement for its update.

kind regards,

Jos

I did exectly as u said ,i add rs1.close() line as following


getpass=getpass.trim();
rs1.close();

but still the same warning is there and table didnt update.

Quote:

---

Originally Posted by amritpalpathak

I did exectly as u said ,i add rs1.close() line as following


getpass=getpass.trim();
rs1.close();

but still the same warning is there and table didnt update.

---

Then also close your PreparedStatement ps3 after you have closed the ResultSet rs1.

kind regards,

Jos

It done successfully
I close both statements as
rs1.close();
ps3.close();

Thank you very much joyAH,You have solved my problem,now its going well

One thing more ,please tell me without closeing these both ,why it was not working and giving the error of "connection is busy"


Regards
Amrit pal pathak

Quote:

---

Originally Posted by amritpalpathak

It done successfully
I close both statements as
rs1.close();
ps3.close();

Thank you very much joyAH,You have solved my problem,now its going well

One thing more ,please tell me without closeing these both ,why it was not working and giving the error of "connection is busy"


Regards
Amrit pal pathak

---

In your second (update) PreparedStatement you alter your table 'sreg' that can potentially change the ResultSet in your first PreparedStatement. I would've expected that by releasing the ResultSet (by closing it) it would've removed that dependency, but apparently you need to close the entire PreparedStatement ... Check the different forms of prepareStatement( ... ) in the Connection interface; it should be possible to create one and have its ResultSet altered by another PreparedStatement ...

kind regards,

Jos