how do i write this code?

[Libertyman]

the goal is to make the program get 10 random numbers and then choose the number which is the biggest. i think i am wrong somewhere. how can i write the code correctly?


class Ex4
{
public static void main(String[] args)
{
int count;
count=0;
while(count<10)
{
Console console=System.console();
System.out.println("put a number");
String number
number=console.readLine();
int n1;
n1=Integer.parseInt(number);

System.out.println("put next number");
String next_number
next_number=console.readLine();
int n2;
n2=Integer.parseInt(next_number);
System.out.println("biggest value"+(n2>n1?n2:n1));
count=count+1;
}

}




}

[Norm]

Can you describe the logic/design of your program?
A good design before writing code, makes for a better solution.

[Libertyman]

the program should give the user 10 questions/options to put any number he wants.

after he put the 10 numbers when asked, the program at the end should choose the highest number

[Norm]

What you've just posted is a statement of the problem. It doesn't sound like the original problem??

Now you need to come up with a design on how to solve that problem.
That means what the steps are to solve the problem.

[Libertyman]

it tells me that i have an error:

Console console = System.console();

Ex:java13 cant find symbol
symbol class console
Location class Ex4


why? how do i correct that?

[Norm]

Please copy and paste the FULL text of the error message. There is info there that you left out.

Do you have an import statement for the package the Console class is in?

[PhHein]

Where did you get that code from in the first place? Read the API doc for System.console() and read the basic IO tutorial.

[Libertyman]

import java.io.*;
class Ex4
{
public static void main(String[] args)
{


int count;
count=0;
while(count<10)
{
System.out.println("put a number");
Console console=System.console();
String number;
number=console.readLine();
int n1;
n1=Integer.parseInt(number);

System.out.println("Your number is "+ " " + n1);

count=count+1;
}
int n2;


System.out.println("Your Biggest number is"+ n2>n1?n2:n1);\\ i need to set this line to give me the biggest value that was displayed

}




}

the program works like that. the user types 10 numbers. and what i need to do is in the last line present the largest number he typed.
i need one command line to make this work, but i dont know what it is

[PhHein]

For starters your code is fragile, but you seem to accept that. Secondly you never remember the numbers being entered, so you have no chance to find the biggest number.

[Libertyman]

please tell me how to do that. i want to get over with that exercise. i am workign on those codes since the morning


what if i write that the user needs to type 10 numbers... - that would be n1

would i be able to make a formala finding the largest number?

[PhHein]

No way, it doesn't work that way. Learn! You've been given the link to the basic tutorials, find out how to use arrays and sorting algorythms, or do it with pen and paper and imagine there could be somebody asking you anytime about the biggest number so far.

[Norm]

How would you do it if you were using a piece of paper and pencil?
A user gives you a number
You write it down on the paper
You get the next number.
Is this number bigger than the last number?
If so, replace the last number written with the new number
Loop back to get the next number

When you are done, the number written down will be the largest.

In a program use variables to save values instead of writing them down

[Norm]

do it with pen and paper

@PhHein Great minds work in ....

[Libertyman]

That would seem to be a long code.

giving a value to each variable.

like this

int 1
int b
int c
int d
int e.

i dont think it would be the answer.

[Norm]

giving a value to each variable.

Can you explain your last post?

There is only one variable to hold the current largest one.
And one variable to hold what the user input.

[Libertyman]

import java.io.*;
import java.io.*;
class Ex4
{
	public static void main(String[] args)
	{       
                       
                       
		int count;
		count=0;
		while(count<10)
		{         
                        System.out.println("put a number");  
                        Console console=System.console(); 
                        String number;
                        number=console.readLine();
                        int n1;
		        n1=Integer.parseInt(number);    
                        int n2;
                        n2=n1       
                        System.out.println("Your number is "+ " " + n1 + "Biggest input" + (n2>n1)?n2:n1);
                        
		        count=count+1;
		}
                  

	}




}

or

import java.io.*;
class Ex4
{
	public static void main(String[] args)
	{       
                       
                       
		int count;
		count=0;
		while(count<10)
		{         
                        System.out.println("put a number");  
                        Console console=System.console(); 
                        String number;
                        number=console.readLine();
                        int n1;
		        n1=Integer.parseInt(number);    
                        int n2;
                        n2=n1>n2?n1:n2;       
                        System.out.println("Your number is "+ " " + n1 + "Biggest input"+ " " + n2);
                        
		        count=count+1;
		}
                  

	}




}

why does he tell me that System.out.println line is wrong?
why cant i use a trillneary expression?



actually the whole think is a mess. i want to put a new statement out of the loop
System.out.println(" your Biggest number" = )

but i wonder how can i make the programme make that calculation

[curmudgeon]

Two problems: your use of = within the expression rather than ==, and your trying to compare a String with an int.

Edit: I see that you modified your post, which I'll post here:

                        int n1;
		        n1=Integer.parseInt(number);    
                        int n2;
                        n2=n1>n2?n1:n2;       
                        System.out.println("Your number is "+ " " + n1 + "Biggest input"+ " " + n2);

but you're still using = to compare one number with the other, not ==. Please understand that = assigns a value to a variable whereas == compares two variables. Also, you are comparing n1 with n2, but never assigned any value to n2 so it's meaningless. What is n2 supposed to represent?

[Libertyman]

i saw that problem with n2. i deleted the whole thing

i want n2 to be the previous number..

but because it is a loop..the whole thing is too confusing and tricky.

i think someone who knows java well, should know..

after i have the values from the loop. how can i make the application list the highest value from the list?

[Norm]

You still haven't come up with a design for how the program should work.
Look at this:
There are two variables: currVal and highestVal.
Set highestVal to the smallest number possible so that any number input will be larger
1) get the next number from user into currVal
2) compare currVal to highestVal
3) if currVal is greater than highestVal then set highestVal to currVal (ie save the new highest value)
4) test if 10 numbers gotten yet (loop test)
5) if < 10 numbers go to step 1)
6) if 10 numbers, then highestVal has the highest value entered

[curmudgeon]

i saw that problem with n2. i deleted the whole thing

i want n2 to be the previous number..

Then declare n2 before the loop even starts:

int n2;  // this is a variable declaration

But you probably want to give it some initial value too, so you'll need to declare and assign it, again before the while loop:

int n2 = Integer.MIN_VALUE;  // this is a variable declaration with an assignment
while (count < 10) {
  .....