How to run the run()?

[niu_niu]

import java.io.*;

public class aBSTtree {
		
			public class BSTNode<T extends Comparable<T>> {
			protected T el; 
			protected BSTNode<T> left, right; 
			
			public BSTNode( ){
				left=right=null;
			}
			
			public BSTNode(T el) {
				this (el, null, null); 
			}
			
			public BSTNode(T el, BSTNode<T> lt, BSTNode<T> rt) {
				this.el =el; left =lt; right =rt; 
			}
			
			}
	
	public class BST<T extends Comparable<T>>{
		protected BSTNode<T> root=null; 
		
		public BST( ){			
		}
		
		protected void visit (BSTNode<T> p) {
			System.out.print(p.el + " "); 
		}
		
		public void TreeInit( ) {
			BSTNode b=new BSTNode(10, null,null); 
			BSTNode c=new BSTNode(25, null, null);		 
			BSTNode root= new BSTNode(13, b, c);
		}
		
		public void run( ) {
			TreeInit(); 
			System.out.println("b is: " + root);
		}
	}
	public static void main(String[] args) {
		(new BST<Integer> ()).run();  
	}

}

Hi:

I am trying to run the run() method, but my program is giving me syntax error messages on "(new BST<Integer> ()).run();"...I tried a couple of some other things, but none worked. What should I put here?

Niu Niu

[r035198x]

What do we need to do so that you can tell us the errors that you got?

[niu_niu]

import java.io.*;

public class BSTNode<T extends Comparable<T>> {
				protected T el; 
				protected BSTNode<T> left, right; 
			
				public BSTNode( ){
				left=right=null;
				}
			
				public BSTNode(T el) {
				this (el, null, null); 
				}
			
				public BSTNode(T el, BSTNode<T> lt, BSTNode<T> rt) {
				this.el =el; left =lt; right =rt; 
				}
			
			}


public class aBSTtree<T extends Comparable<T>>{
				protected BSTNode<T> root=null; 
		
				public aBSTtree( ){			
				}
		
				protected void visit (BSTNode<T> p) {
					System.out.print(p.el + " "); 
				}	
		
				public void TreeInit( ) {
					BSTNode b=new BSTNode(10, null,null); 
					BSTNode c=new BSTNode(25, null, null);		 
					BSTNode root= new BSTNode(13, b, c);
				}
		
				public void run( ) {
					TreeInit(); 
					System.out.println("b is: " + root);
				}
		

	public static void main(String[] args) {
		(new aBSTtree( )).run(); 
	}
}

OK, I realized what was potentially wrong and I re-organized the structure a little. However, I am now getting a different error. It somehow doesn't like the line: "public class BSTNode<T extends Comparable<T>>". And the error is: The public type BSTNode must be defined in its own type. But isn't it obvious that I have already defined it??

public BSTNode( ){ left=right=null;}

What am I missing here?

N.N.

[Tolls]

You can only have one public top level class in a file.
What you wanted was to keep the original code, but move all the stuff in BST<T> up into aBSTtree and get rid of that class.

[JosAH]

import java.io.*;

public class BSTNode<T extends Comparable<T>> {
				protected T el; 
				protected BSTNode<T> left, right; 
			
				public BSTNode( ){
				left=right=null;
				}
			
				public BSTNode(T el) {
				this (el, null, null); 
				}
			
				public BSTNode(T el, BSTNode<T> lt, BSTNode<T> rt) {
				this.el =el; left =lt; right =rt; 
				}
			
			}


public class aBSTtree<T extends Comparable<T>>{
				protected BSTNode<T> root=null; 
		
				public aBSTtree( ){			
				}
		
				protected void visit (BSTNode<T> p) {
					System.out.print(p.el + " "); 
				}	
		
				public void TreeInit( ) {
					BSTNode b=new BSTNode(10, null,null); 
					BSTNode c=new BSTNode(25, null, null);		 
					BSTNode root= new BSTNode(13, b, c);
				}
		
				public void run( ) {
					TreeInit(); 
					System.out.println("b is: " + root);
				}
		

	public static void main(String[] args) {
		(new aBSTtree( )).run(); 
	}
}

OK, I realized what was potentially wrong and I re-organized the structure a little. However, I am now getting a different error. It somehow doesn't like the line: "public class BSTNode<T extends Comparable<T>>". And the error is: The public type BSTNode must be defined in its own type. But isn't it obvious that I have already defined it??

public BSTNode( ){ left=right=null;}

What am I missing here?

N.N.

Change everything back to your original version again (and name your file "BSTNode" and show us the compiler messages verbatim.

kind regards,

Jo

[Tolls]

He's trying to instantiate BST, however it is a non-static inner class and so can only be instantiated in relation to an aBSTtree object. That's the error (cannot instantiate non-static class).

I can't believe I actually cut and pasted that code into IntelliJ...

[JosAH]

He's trying to instantiate BST, however it is a non-static inner class and so can only be instantiated in relation to an aBSTtree object. That's the error (cannot instantiate non-static class).

I can't believe I actually cut and pasted that code into IntelliJ...

If I read the code correctly there is no inner class, just diabolical indentation; there are two public classes (in one file?) and of course the entire code is a genuine mess.

kind regards,

Jos

[Tolls]

The original code in the OP is a class (aBSTtree) that consists solely of a main() and two inner classes (BST and BSTNode).

[JosAH]

The original code in the OP is a class (aBSTtree) that consists solely of a main() and two inner classes (BST and BSTNode).

I see it now; I fell in the diabolical indentation trap, darn; why do people do that? Don't they know they can be defenestrated for that?

kind regards,

Jos

[niu_niu]

import java.io.*;

class BSTNode<T extends Comparable<T>> {
				protected T el; 
				protected BSTNode<T> left, right; 
			
				public BSTNode( ){
				left=right=null;
				}
			
				public BSTNode(T el) {
				this (el, null, null); 
				}
			
				public BSTNode(T el, BSTNode<T> lt, BSTNode<T> rt) {
				this.el =el; left =lt; right =rt; 
				}
			
			}

public class aBSTtree<T extends Comparable<T>>{
				protected BSTNode<T> root=null; 
		
				public aBSTtree( ){			
				}
		
				protected void visit (BSTNode<T> p) {
					System.out.print(p.el + " "); 
				}	
				
				public BSTNode<T> search(T el) {
					BSTNode<T> p = root; 
					while(p != null)
							if (el.equals(p.el))
								return p; 
							else if (el.compareTo(p.el)<0)
								p= p.left; 
							else p = p.right; 
					return null; 
				}
		
				public void TreeInit( ) {
					BSTNode<T> b=new BSTNode(10, null,null); 
					BSTNode<T> c=new BSTNode(25, null, null);		 
					BSTNode<T> root= new BSTNode(13, b, c);
				}
		
				public void run( ) {
					TreeInit(); 
					search(13);  
				}
		
				
	
public static void main(String[] args) {
		(new aBSTtree( )).run(); 
	}
}

***********************************

why is that Eclipse is complaining that search(13) is not valid?

[Norm]

Eclipse is complaining that search(13) is not valid

Was there any error message?
What is the type of args to the search() method? Is it an int? Or Integer if you have autoboxing.

[Tolls]

public BSTNode<T> search(T el) {}

That's not an int is it?