whats wrong

Hello,

can anyone tell me why on earth am i getting only zeros while i'm iterating the array in main method ?

Code:

---

    public static int[] readFile(String fName) {
        try {
            Scanner scanner = new Scanner(new File(fName));
            while (scanner.hasNext()) {
                myNext = new int[scanner.toString().length()];
                int c = 0;
                myNext[c] = scanner.nextInt();
                System.out.print( myNext[c] + " "); //dbg output
                c++;
            }

        } catch (FileNotFoundException e) {
            System.err.println("FileNotFoundException: "
                    + e.getMessage());
        }

        return myNext;
    }

    public static void main(String[] args) {

        System.out.println( System.getProperty("user.dir"));
        int fileArrayLength = readFile("readme.txt").length;
        int[] fileArray = readFile("readme.txt");

      // selectionSort(fileArray);
        System.out.println();
        for (int i = 0; i <= fileArrayLength-1; i++) {
            System.out.print(fileArray[i] + " ");
        }

---

Do you want to create a new myNext array each time the while loop iterates? If myNext is being returned by the readFile method, should it be a static class field (my own opinion here is "no")? What the do you think this code does:

Code:

---

myNext = new int[scanner.toString().length()];

---

?
Have you checked what scanner.toString() returns? And why does the length of this String matter? Finally, what does the input fill look like?

Means about this.

Code:

---

while (scanner.hasNext()) {
                myNext = new int[scanner.toString().length()];
}

---

As Fubarable explains, what happen if the scanner found more than one line of text. Think about that on each line found in the scanner what happen in myNext. Put a print statement to check the length of it and check.

Quote:

---

Originally Posted by Fubarable

Do you want to create a new myNext array each time the while loop iterates? If myNext is being returned by the readFile method, should it be a static class field (my own opinion here is "no")? What the do you think this code does:

Code:

---

myNext = new int[scanner.toString().length()];

---

?
Have you checked what scanner.toString() returns? And why does the length of this String matter? Finally, what does the input fill look like?

---

Since i dont know the length of the file input - i thought i'll have to create every time a new array with its new length.

Code:

---

myNext = new int[scanner.toString().length()];

---

was suppose to read the length of scanner and parse it as an array length for myNext

How else would i get the scanner length ?

Add: the file contains only space separated numbers

Also, in your loop, you always set c to 0. You do increment it at the end of the loop, but in the next iteration it gets set back to 0.

Quote:

---

Originally Posted by m00nchile

Also, in your loop, you always set c to 0. You do increment it at the end of the loop, but in the next iteration it gets set back to 0.

---

aah, true - what a stupid mistake. :(

Quote:

---

Originally Posted by atenv

Since i dont know the length of the file input - i thought i'll have to create every time a new array with its new length.

---

and delete any contents held in the array previously. No I wouldn't do this.

Quote:

---

Code:

---

myNext = new int[scanner.toString().length()];

---

was suppose to read the length of scanner and parse it as an array length for myNext

How else would i get the scanner length ?

---

But if you display what scanner.toString() holds, you'll find that your code does nothing of the kind. To toString method here will only display some information about the scanner object and taking its length is useless to your program. As to getting the length of data, that depends upon how the data is stored. Previously I asked for you to display it, but we've yet to see it. You may have to either use an ArrayList which won't care about the size of the data, or else run through the data file twice, first to get the length and the second time to extract the data itself.