help with not equal to operator !=

[manowar689]

ok so im having a problem im tryin to write a java program that can work out subnets based on user input but cant get this loop to work like assuming the answer to Q2=128 it will do the if part and run readbit but then the loop starts again instead of continuing :eek: lol any help would be appricated

//--------------------------------------------subnet class C address----------------------------------------
class subnet{

	public static void main (String[] args){

	int Q1;
	int Q2;

//----------------------------------------------CLASS C---------------------------------------------
System.out.print ("\nThis is a program that will workout class c addresses for subnetting\n");
System.out.print ("\nplease input the method you wish to workout ip addresses\n");
Q1 = kdr.valgetint("\n1:hosts per subnet\n2:bits borrowed\n3:total subnets\nplease input answer : ");

//--------------------------------------------Q1----------------------------------------------------
if (Q1==1)
{
	do{
// ensures that a valid int is got before trying to check it 
		Q2 = kdr.valgetint("\nplease input number of hosts per subnet: ");
			if(Q2==128 || Q2==64 || Q2==32 || Q2==16 || Q2==8 || Q2==4)
			{
			readbit();
			}
			else{
			System.out.print ("\nThis is the wrong value it needs to be 128,64,32,16,8,4,2,1");
			};
	}while(Q2!=128 || Q2!=64 || Q2!=32 || Q2!=16 || Q2!=8 || Q2!=4);
}
//--------------------------------------------------------------------------------------------------
//--------------------------------------------Q2----------------------------------------------------
if (Q1==2)
{
do{
Q2 = kdr.valgetint("\nplease input number of bits borrowed: ");
if(Q2<=6)
{
readbit();
}
else{
System.out.print ("\nThis is the wrong value it needs to be 1,2,3,4,5,6");
};

}while(Q2<=6);

if(Q2==1)
{
}
if(Q2==2)
{
}
if(Q2==3)
{
}
if(Q2==4)
{
}
if(Q2==5)
{
}
if(Q2==6)
{
}
}
//--------------------------------------------------------------------------------------------------

	}
	static void readbit() {

int count;
count = 0;
double bit[] ;
    bit = new double [count];


do{
do{
System.out.print ("\nplease input the value of octet "+(count+1)+":");
bit[count]= Keyboard.readDouble () ;
if (bit[count]>=256)
{
System.out.print ("\nThis is the wrong size for a bit max is 255\n");
}
}while(bit[count]>=256);
count++;
}while(count>3);

}

}

[Norm]

cant get this loop to work

Is it one of these:

do{
do{
System.out.print ("\nplease input the value of octet "+(count+1)+":");
bit[count]= Keyboard.readDouble () ;
if (bit[count]>=256)
{
System.out.print ("\nThis is the wrong size for a bit max is 255\n");
}
}while(bit[count]>=256);
count++;
}while(count>3);

Try debugging the code by adding enough println() statements to show all the values used.

[Sno]

Why kdr.valgetint

why not scanner, I dont believe valgetint is correct, Shouldn't it be val.getInt()?
what is the value of Q1 and Q2
instead of while, try else if statement. While statement will keep looping until the statement is false.

 System.out.print ("\nThis is a program that will workout class c addresses for subnetting\n");
System.out.print ("\nplease input the method you wish to workout ip addresses\n");
Q1 = kdr.valgetint("\n1:hosts per subnet\n2:bits borrowed\n3:total subnets\nplease input answer : ");

[StormyWaters]

	do{
// ensures that a valid int is got before trying to check it 
		Q2 = kdr.valgetint("\nplease input number of hosts per subnet: ");
			if(Q2==128 || Q2==64 || Q2==32 || Q2==16 || Q2==8 || Q2==4)
			{
			readbit();
			}
			else{
			System.out.print ("\nThis is the wrong value it needs to be 128,64,32,16,8,4,2,1");
			};
	}while(Q2!=128 || Q2!=64 || Q2!=32 || Q2!=16 || Q2!=8 || Q2!=4);
}

Look closely at your while statement. Even if the Q2 value is a correct value, ie 128, it will still not be any of the other values so it will continue the while loop. Instead try using && instead of || as this will correct the logic.

[manowar689]

its just this part here that is giving me the prob everything is working otherwise i just want this do while loop to loop unless the value is 128,64,32,16,8,4 and 2 if it does that then i can continue to the printout of the subnet addresses by making all of the answers refer to a printout if thats right lol but ye its the while line thats the prob

do{
// ensures that a valid int is got before trying to check it 
		Q2 = kdr.valgetint("\nplease input number of hosts per subnet: ");
			if(Q2==128 || Q2==64 || Q2==32 || Q2==16 || Q2==8 || Q2==4)
			{
			readbit();
			}
			else{
			System.out.print ("\nThis is the wrong value it needs to be 128,64,32,16,8,4,2,1");
			};
	}while(Q2!=128 || Q2!=64 || Q2!=32 || Q2!=16 || Q2!=8 || Q2!=4);

[Norm]

while(Q2!=128 || Q2!=64 || Q2!=32 || Q2!=16 || Q2!=8 || Q2!=4)

If Q2 = 128 then Q2 is not equal to 64 etc, so the rest of the tests will always be true.

You want to continue if Q2 != 128 AND Q2!=64 AND the rest of the list of tests
In other words, fall out of the loop for Q2 equal to any of the values shown in the tests

Did you read what StormyWaters posted?

[manowar689]

iif i leave it like this then i cant get it to reask the question if the input is incorrect thats what the loop was for how would i fix this bit to validate that it is 128,64,32 etc etc.....

	Q2 = kdr.valgetint("\nplease input number of hosts per subnet: ");
		if(Q2==128 || Q2==64 || Q2==32 || Q2==16 || Q2==8 || Q2==4)
			{
			readbit();
			}
			else{
			System.out.print ("\nThis is the wrong value it needs to be 128,64,32,16,8,4,2,1");
			};

[Norm]

i cant get it to reask the question if the input is incorrect

have you tried it? What does it do?

[manowar689]

hey stormywaters one worked thanks man your a god :)

[manowar689]

can somebody tell me how to mark this as solved