Cant figure out where went wrong.

Hi, i somehow completed my codes but the codes get mixed up. Sometime it wont switch to next player or the desire result wont come out. Well take a look at part of my codes and hope someone could figure out for me.

Code:

---

                // player 1
                while (playerTurn == true) {
                        System.out.print("Player 1  :");
                        generateRandom();
                        for (int j = 0; j < wordGame.length; j++) {
                                System.out.print(wordGame[j] + " ");
                        }
                        System.out.println();
                        System.out
                                        .println("Enter your World ( or Press  @  to PASS or Press !  To Quit )");
                        inputs = scan.next();
                        playerInput = inputs.toCharArray();


                        // *****************************************************************************************************************
                        // Exiting the game
                        if (inputs.equals("!")) {
                                System.out.println("Player 1 score: " + player1);
                                System.out.println("Player 2 score: " + player2);

                                if (player1 > player2) {
                                        System.out.println("player 1 won the game");
                                } else if (player1 == player2) {
                                        System.out.println("Its a draw");
                                } else
                                        System.out.println("Player 2 won the game");
                                System.exit(0);

                        }
                        // *****************************************************************************************************************
                        // Passing the game
                        else if (inputs.equals("@")) {
                                //System.out.println("Total score for word [Player 1]: 0");
                                //System.out.println("Total score for game: " + player1);
                                player1 += 0;
                                playerTurn = false;
                        }
                        // *****************************************************************************************************************
                        // Inputs for game

                        else if (inRandom(inputs, wordGame)) {
                                if (inDict(inputs, dict)) {
                                        pointAssign();
                                        System.out.println(playerInput);
                                        System.out.println("Total score for word : " + points);
                                        player1 += points;
                                        System.out.println("Total score for game : " + player1);
                                        points = 0;
                                        playerTurn = false;
                                } else {
                                        System.out.println("Error :An invalid word is formed.");
                                        System.out
                                                        .println("Enter your World ( or Press  @  to PASS or Press !  To Quit )");
                                        playerInput = null;
                                        inputs = scan.next();
                                        playerInput = inputs.toCharArray();
                                        System.out.println("");
                                }
                        } else if (inDict(inputs, dict) && !inRandom(inputs, wordGame)) {
                                System.out
                                                .println("Error : A valid word is formed but one or more letter(s) used are not yours  ");
                                System.out
                                                .println("Enter your World ( or Press  @  to PASS or Press !  To Quit )");
                                playerInput = null;
                                inputs = scan.next();
                                playerInput = inputs.toCharArray();
                        } else if (!inDict(inputs, dict) && !inRandom(inputs, wordGame)) {
                                System.out
                                                .println("Error : one or more letter(s) used are not yours  ");
                                System.out
                                                .println("Enter your World ( or Press  @  to PASS or Press !  To Quit )");
                                playerInput = null;
                                inputs = scan.next();
                                playerInput = inputs.toCharArray();
                        }

                        // *****************************************************************************************************************
                        // Player 2 turn

                        while (playerTurn == false) {
                                generateRandom();
                                System.out.print("Player 2  :");
                                for (int k = 0; k < wordGame.length; k++) {
                                        System.out.print(wordGame[k] + " ");
                                }
                                System.out.println();
                                System.out
                                                .println("Enter your World ( or Press  @  to PASS or Press !  To Quit )");
                                inputs = scan.next();
                                playerInput = inputs.toCharArray();

                                // *****************************************************************************************************************
                                // Exiting the game for player2

                                if (inputs.equals("!")) {
                                        System.out.println("Player 1 score: " + player1);
                                        System.out.println("Player 2 score: " + player2);

                                        if (player1 > player2) {
                                                System.out.println("player 1 won the game");
                                        } else if (player1 == player2) {
                                                System.out.println("Its a draw");
                                        } else
                                                System.out.println("Player 2 won the game");
                                        System.exit(0);

                                }
                                // *****************************************************************************************************************
                                // Passing the game for player2
                                else if (inputs.equals("@")) {
                                        //System.out.println("Total score for word[Player 2]: 0");
                                        //System.out.println("Total score for game: " + player2);
                                        player2 += 0;
                                        playerTurn = true;
                                }
                                // *****************************************************************************************************************
                                // Inputs for game for player2

                                else if (inRandom(inputs, wordGame)) {
                                        if (inDict(inputs, dict)) {
                                                pointAssign();
                                                System.out.println(playerInput);
                                                System.out.println("Total score for word : " + points);
                                                player2 += points;
                                                System.out.println("Total score for game : " + player2);
                                                points = 0;
                                                playerTurn = true;
                                        } else {
                                                System.out.println("Error :An invalid word is formed.");
                                                System.out
                                                                .println("Enter your World ( or Press  @  to PASS or Press !  To Quit )");
                                                playerInput = null;
                                                inputs = scan.next();
                                                playerInput = inputs.toCharArray();
                                                System.out.println("");
                                        }
                                } else if (inDict(inputs, dict) && !inRandom(inputs, wordGame)) {
                                        System.out
                                                        .println("Error : A valid word is formed but one or more letter(s) used are not yours  ");
                                        System.out
                                                        .println("Enter your World ( or Press  @  to PASS or Press !  To Quit )");
                                        playerInput = null;
                                        inputs = scan.next();
                                        playerInput = inputs.toCharArray();
                                } else if (!inDict(inputs, dict) && !inRandom(inputs, wordGame)) {
                                        System.out
                                                        .println("Error : one or more letter(s) used are not yours  ");
                                        System.out
                                                        .println("Enter your World ( or Press  @  to PASS or Press !  To Quit )");
                                        playerInput = null;
                                        inputs = scan.next();
                                        playerInput = inputs.toCharArray();
                                }
                        }

---

seriously need these help

Quote:

---

Originally Posted by leviathan

Hi, i somehow completed my codes but the codes get mixed up. Sometime it wont switch to next player or the desire result wont come out. Well take a look at part of my codes and hope someone could figure out for me.

---

We don't know the 'desire results' so the code is fine with us. We don't even know what your code is supposed to do and what it actually does.

kind regards,

Jos

oh ya, forgot to mention...this is those scrabble like games that you see often.

Its suppose to generate 10letters and we have to form a valid word from these letters, when the words form were wrong they will inform what was wrong.

The problem in this code will be, after typing in for error try it will work the first time but however when i try for a second time it will re-generate again the 10letters instead of giving the error statement.

example:

Quote:

---

Find Your Words
Player 1 :m i q i a w e g v m
Enter your World ( or Press @ to PASS or Press ! To Quit )
exit
Error : A valid word is formed but one or more letter(s) used are not yours
Enter your World ( or Press @ to PASS or Press ! To Quit )
we
Player 1 :z u n t m d k j d t
Enter your World ( or Press @ to PASS or Press ! To Quit )

---

Quote:

---

Originally Posted by leviathan

oh ya, forgot to mention...this is those scrabble like games that you see often.

---

There's already a thread running about this very same subject; maybe you can join it.

kind regards,

Jos

ya, im aware that theres multiple threads regrading this topic. However i believe java can have many different ways to reach the same result. There i deciede to open one thread of own, and because my previous thread did not recieve any response.:(

Thanks for understanding.:o

A few comments on the posted code:

Quote:

---

player1 += 0;

---

What is this supposed to do?

Quote:

---

player1

---

Does this represent a player or a players score? Hard to tell from the name.
Should it be: player1Score?

Quote:

---

wont switch to next player

---

where in the code is this supposed to happen? How do you determine whose's turn it is?

player1 is the score im sorry...

to determine the turn, theres this code "While playerTurn = True"

true = player1
false = player2

another problem now is that, it wont run my error statement more than once or just re-generate the 10random letter which is not suppose to.

Where is your main?

Quote:

---

Originally Posted by somanayr

Where is your main?

---

I've got a sneaking suspicion that his program is essentially one huge main method.

that codes follow after main, i didnot copy the full code, cause it will be 300line long.

You need to add some debug code to see what is happening.

Break the compound statements into single statement and display the results

Quote:

---

inDict(inputs, dict) && !inRandom(inputs, wordGame)

---

vs
boolean inDict = inDict(inputs, dict);
System.out.println("inDict(inputs, dict)=" + inDict + ", for inputs=" + inputs ...);

Quote:

---

Originally Posted by leviathan

that codes follow after main, i didnot copy the full code, cause it will be 300line long.

---

What if the problem's in the main? Just copy the whole thing.

the code i post was the main stuff.

the rest were my methods... which is considered done...

Quote:

---

Originally Posted by Fubarable

I've got a sneaking suspicion that his program is essentially one huge main method.

---

That'd be a big nono on my code-metric-o-meter ...

kind regards,

Jos

i figured that theres no technical error, more like logic error around here...

which im currently cant see it :(

You need to add some debug code to see what is happening.