array going out of bounds?

[jabo]

This is a similar question i had earlier,
I am trying to fill in the array of strings with the name of the award winners however i am having trouble with the loop.
here is the set of strings being read

Bob Johnson
Peace Prize, 1989
Purple Heart, 1954
Bryce Webb
Silver Medal, 2009
Heisman, 1963
Grammy Award, 2010
Academy Award, 2008
Casey Hollingsworth
Final Four, 2007
Gold Medal, 2009
Bronze Medal, 2009

String str;
	    String[] counts = new String[3];
	    BufferedReader reader = new BufferedReader(
	              new StringReader(awardWinners.toString()));
	    int y= 0;
	    
			while((str = reader.readLine()) != null){
			  int x = str.indexOf(", ");
			  if(x == -1)
				counts[y] = str;
/*linen157*/		y++;

			}
		System.out.println(Arrays.toString(counts));

the code creates array of 3 integers and im trying to set the line without commas as the value for each array but i get this error.

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 7
at MainDriver.main(MainDriver.java:157)

im not sure why its going out of bounds. thanks!

[gcalvin]

Do you possibly have any blank lines in your String? Try a System.out.println(str) just before you add str to the array.

-Gary-

[jabo]

hmm i dont think so

[pbrockway2]

counts is quite a small array (length is 3). But you increment the y variable every time you read a line. If you hit a line without a comma anywhere from the fourth line onwards y will be >=3 and you will be out of bounds.

[jabo]

haha yea 3 is kinda small, huh? im trying to get it to work with 50 arrays. 3 was just to test it.


edit: ok i increased my array to 50 and heres what i got

[Bob Johnson, null, null, Bryce Webb, null, null, null, null, Casey Hollingsworth, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null]

how would i make it so the next name would occupy the next blank array?

[gcalvin]

Yeah, the problem isn't that the array is too small. Format your code properly and take another good look at it. You already got the answer from pbrockway2, but you are still not seeing it. Fix your indentation, and the answer should reveal itself.

-Gary-

[Fubarable]

You might want to scrap the idea of using arrays and instead create a couple of classes here, one perhaps called Award that holds a String for the award name and an int for the year, another, perhaps called AwardWinner that holds a String for the name of the person and an ArrayList<Award> for the multiple awards they've won, and then create an ArrayList<AwardWinner> to hold a collection of all the award winners.

Next you'll have to figure out a way to tell as you're reading the file when a new person's name begins and read in the input accordingly. Perhaps you can check if the line contains a comma, and if not it's a name (of course you'll have problems if you run into any names like John Smith, Jr).

[jabo]

thank you guys
i fixed it by adding brackets around the loop

[pbrockway2]

Great! Braces are good.

[wangwei]

Maybe u should include the code at [CODE] block, or it wraps unexpectedly.
^_^