constructor question

**mac** · 03-20-2010, 05:47 PM

Class A contains the following line

Java Code:

AssignVariablesDC3 p = new AssignVariablesDC3(12);

Class AssignVariablesDC3
Has a constrtuctor

Java Code:

int length;

public AssignVariablesDC3(int dc3LineLength) {
      this.length = dc3LineLength;
}

Later on in class A

Java Code:

trim = currentLineArray[p.getTRIM_POSITION()].equals("yes") ? true : false;

In class AssignVariablesDC3 there is a method:

Java Code:

public int getTRIM_POSITION() {
return (length * FIELDS_IN_SOURCE_OR_TARGET + FIELDS_IN_SOURCE_OR_TARGET + TOTAL_TAGS + TOTAL_ENVIRONMENTS);
}

Length is always 0. Why not 12?
Object is “new”ed only one time
Sysout in constructor confirms “12” was received

**gcalvin** · 03-20-2010, 07:31 PM

I can only guess there is a bug somewhere else in your code. Use a debugger and set a watch on the length instance variable.

Pardon me for ranting a bit, but AssignVariablesDC3 is a terrible name for a class. Classes are blueprints for creating objects, and should have nouns for names. If the sole purpose of that class is to manage properties or data for some other class or some system, then call it PropertyAssigner or DataManager or something like that. Use verbs for method names, and nouns for class names. You'll be happier and saner for it.

-Gary-

**Fubarable** · 03-20-2010, 07:45 PM

I agree with Gary: you have a bug and the code with the bug in it is not the code you've posted.

**JosAH** · 03-20-2010, 08:17 PM

Originally Posted by Fubarable

I agree with Gary: you have a bug and the code with the bug in it is not the code you've posted.

Any text editor that supports regular expression searches can easily find text that matches the pattern "length *=".

kind regards,

Jos

**Fubarable** · 03-20-2010, 08:22 PM

Originally Posted by JosAH

Any text editor that supports regular expression searches can easily find text that matches the pattern "length *=".

My own thought though was that the object that he's using the length property is not the same object that had the length property set. But I have to admit that I'm not using my regular crystal ball which is in the shop but am making do with a loaner that's one of last year's models.