Bank Account

[HPcompaq256]

Hi I need to create Bank account which would give these values when the tester class is applied:

The tester class is
public class BankAccountTester
{
public static void main(String[] args)
{
BankAccount account = new BankAccount(100);
account.deposit(-100);
System.out.println(account.getBalance());
System.out.println("Expected: 100");
account.withdraw(-50);
System.out.println(account.getBalance());
System.out.println("Expected: 100");
account.withdraw(200);
System.out.println(account.getBalance());
System.out.println("Expected: 100");
}
}


MY CODE IS

/**
A bank account has a balance that can be changed by
deposits and withdrawals.
*/
public class BankAccount
{
private double balance;
private int transaction;
private double minimumBalance;
//define the minimum balance method


/**
Constructs a bank account with a zero balance.
*/
public BankAccount()
{
balance = 0;
}

/**
Constructs a bank account with a given balance.
@param initialBalance the initial balance
*/
public BankAccount(double initialBalance)
{
balance = initialBalance;
}

/**
Deposits money into the bank account.
@param amount the amount to deposit
*/
public void deposit(double amount)
{ if (amount<=0) {
amount=0;
double newbalance= balance +amount*0;
balance=newbalance;
transaction=transaction +1;}
if (amount>=0){
double newBalance = balance + amount;
balance = newBalance;
transaction = transaction +1; }}


/**
Withdraws money from the bank account.
@param amount the amount to withdraw
*/
public void withdraw(double amount)
{ if (amount<=balance){
double newBalance = balance + amount;
balance = newBalance;
transaction = transaction +1;
minimumBalance = Math.min(minimumBalance, balance);
}
if (amount>balance){
double newBalance = balance + amount*0;
balance = newBalance;}}


/**
Gets the current balance of the bank account.
@return the current balance
*/
public double getBalance()
{
return balance;
}

public void endOfMonth(double interestRate)
{
balance= balance - transaction;
double interest = minimumBalance * interestRate / 100 / 12;
transaction= 0;

}
// declare a minimumBlance Method
public double getminimumBalance()
{ return minimumBalance;
}}




My Values comes out to be:
100.0
Expected: 100
50.0
Expected: 100
50.0
Expected: 100


Can anyone inspect my code and tell me whats wrong?

[Fubarable]

Hello.

Please use code tags and also tell us what is wrong: what is your current program doing/not doing that is incorrect? What error messages are you seeing?

Best of luck!

[j2me64]

Can anyone inspect my code and tell me whats wrong?

it quite confusing if you use positive and negative amounts in your transactions/method-calls. my suggestion: always use positive amounts in transactions and then subtract this amount in the withdraw-method and add the amount in the deposit-method to the balace. your problem is quite easy to solve and i hope you're not really working as a developer for a bank ;)

[RamyaSivakanth]

what is this logic? Just put what u are going to do in each of the method above as comments.As per the logic its working....But really very dangerous bank.

Deposited 100 and trying to withdraw 200 .............
hahaha........

[j2me64]

Deposited 100 and trying to withdraw 200

this is ok, because with this test you can see if your app behave right with overdraws.

[HPcompaq256]

what is this logic? Just put what u are going to do in each of the method above as comments.As per the logic its working....But really very dangerous bank.

Deposited 100 and trying to withdraw 200 .............
hahaha........

No the program is suppose to block such a transaction. SO I'm having trouble with the withdraw method. Can someone help me fix my withdraw method. Which is :

THIS METHOD IS SUPPOSE THE CANCEL TRANSACTION with amount more than the current balance. Also withdraw amount can't be negative such as -50, so such a transaction should also be canceled.

/**
Withdraws money from the bank account.
@param amount the amount to withdraw
*/
public void withdraw(double amount)
{ if (amount<=balance){
double newBalance = balance + amount;
balance = newBalance;
transaction = transaction +1;
minimumBalance = Math.min(minimumBalance, balance);
}
if (amount>balance){
double newBalance = balance + amount*0;
balance = newBalance;}}

[JosAH]

No the program is suppose to block such a transaction. SO I'm having trouble with the withdraw method. Can someone help me fix my withdraw method. Which is :

THIS METHOD IS SUPPOSE THE CANCEL TRANSACTION with amount more than the current balance. Also withdraw amount can't be negative such as -50, so such a transaction should also be canceled.

/**
Withdraws money from the bank account.
@param amount the amount to withdraw
*/
public void withdraw(double amount)
{ if (amount<=balance){
double newBalance = balance + amount;
balance = newBalance;
transaction = transaction +1;
minimumBalance = Math.min(minimumBalance, balance);
}
if (amount>balance){
double newBalance = balance + amount*0;
balance = newBalance;}}

There are no two ifs, if you want to withdraw more than is present on your account or if you want to withdraw a negative amount of money the lady at the counter just stares at you and won't listen to you:

if (amount <= balance && amount > 0) { // sensible amount for a withdrawal?
   balance-= amount;
   transactions++;
}

kind regards,

Jos

[HPcompaq256]

There are no two ifs, if you want to withdraw more than is present on your account or if you want to withdraw a negative amount of money the lady at the counter just stares at you and won't listen to you:

if (amount <= balance && amount > 0) { // sensible amount for a withdrawal?
   balance-= amount;
   transactions++;
}

kind regards,

Jos

Jos you work hard to make students pass Java. Thanks man. I actually thought my code will work but it doesn't seem to work idk why. In the book that were are using for java does have two if statements.

[JosAH]

Jos you work hard to make students pass Java. Thanks man. I actually thought my code will work but it doesn't seem to work idk why. In the book that were are using for java does have two if statements.

The mere fact that a book uses two if statements doesn't imply that you have to use two if statements. e.g. what is wrong with my version? Also, what does "doesn't seem to work" mean? Incorrect results? Doesn't compile? Crashes? Daemons flying out of your nose?

kind regards,

Jos

[HPcompaq256]

The mere fact that a book uses two if statements doesn't imply that you have to use two if statements. e.g. what is wrong with my version? Also, what does "doesn't seem to work" mean? Incorrect results? Doesn't compile? Crashes? Daemons flying out of your nose?

kind regards,

Jos

it does work.

[HPcompaq256]

I hope daemons dont fly out of your nose :)

[JosAH]

it does work.

Good; does that mean that you could do it with just one if statement?

kind regards,

Jos