a simple if statement

hey everyone,
I've tried this basic piece of javacode.I use bluej to compile and test this.
The basics are very simple: seconds,minutes and hours that you can fill in yourself. But When you put in a number larger then 60 in the seconds part or smaller then 0,the value should automatically be 0. But when you test this one and for example insert 5000,it doesn't change to 0. I've pasted the code underneath.

public class Tijd{
private int sec;
private int min;
private int uur;

public Tijd(int sec, int min, int uur) {
this.setSec(sec);
this.setMin(min);
this.setUur(uur);
}

public int getSec() {
return sec; }
public int getMin() {
return min; }
public int getUur() {
return uur; }

public void setSec(int sec) {
if(this.sec>60) {
this.setSec(0); }
if(this.sec<0) {
this.setSec(0);}
this.sec=sec;}
public void setMin(int min) {
this.min=min; }
public void setUur(int uur) {
this.uur=uur; }
public void reSet() {
this.uur=0;
this.min=0;
this.sec=0; }


}

Quote:

---

Originally Posted by senca

Code:

---

public void setSec(int sec) {
    if(this.sec>60)  {
            this.setSec(0); }
    if(this.sec<0)  {
            this.setSec(0);}
    this.sec=sec;}

---

---

Carefully check what that method does: if sec > 60 or sec < 0 you call that same method again with a value equal to zero (which is correct) but at the end you still set the sec value of your object to the sec parameter, effectively annihilating what those recursive calls had done. Better change that to:

Code:

---

if (sec < 0 || sec >= 60)
  setSec(0);
else
  this.sec= sec;

---

kind regards,

Jos

Oops...can't believe I overlooked that :s. Thanks for the reply and sorry for the stupid failure from my side :)

Quote:

---

Originally Posted by senca

Oops...can't believe I overlooked that :s. Thanks for the reply and sorry for the stupid failure from my side :)

---

You're welcome of course and there's no need to apologize; I've done far more stupid things and I still do it on a regular basis ;-)

kind regards,

Jos

I just noticed that the value is always 0 :s. Adding an else statement saying :

else(){
this.setSec(sec); }

doesn't seem to solve the problem.

Quote:

---

Originally Posted by senca

I just noticed that the value is always 0 :s. Adding an else statement saying :

else(){
this.setSec(sec); }

doesn't seem to solve the problem.

---

(get rid of those two parentheses) Of course that doesn't solve your problem: suppose sec == 20 so you execute your else statement and call that same method with the same parameter value over and over and over ...

kind regards,

Jos

then I dont know the answer :). I don't seem to have the right knowledge yet :)

Quote:

---

Originally Posted by senca

then I dont know the answer :). I don't seem to have the right knowledge yet :)

---

Did you read (and understand) the code snippet I posted?

kind regards,

Jos

the one with == 20 ? That I don't really understand :)

Quote:

---

Originally Posted by senca

the one with == 20 ? That I don't really understand :)

---

No, I meant the snippet in reply #2. It's a complete answer to your question.

kind regards,

Jos

"stackoverflow rror : null" is what I get with the following code:

public class Tijd{
private int sec;
private int min;
private int uur;

public Tijd(int sec, int min, int uur) {
this.setSec(sec);
this.setMin(min);
this.setUur(uur);
}

public int getSec() {
return sec; }
public int getMin() {
return min; }
public int getUur() {
return uur; }

public void setSec(int sec) {
if(this.sec>=60) {
this.setSec(0); }
if(this.sec<=0) {
this.setSec(0);}

}
public void setMin(int min) {
if(this.min>=60) {
this.setMin(0);}
if(this.min<=0) {
this.setMin(0); }
}
public void setUur(int uur) {
if(this.uur>=24) {
this.setUur(0);}
if(this.uur<=0) {
this.setUur(0);}
}
public void reSet() {
this.uur=0;
this.min=0;
this.sec=0; }


}

Quote:

---

Originally Posted by senca

Code:

---

public void setSec(int sec) {
    if(this.sec>=60)  {
            this.setSec(0); }
    if(this.sec<=0)  {
            this.setSec(0);}
  }

---

---

Cute; see what happens if you call this method with sec == 0. The method will call itself over and over again. The cure is simple, change '<=' to '<'. But what will happen when you call this method with sec == 20? Please reread my reply #2 again. And why are you checking this.sec instead of the parameter sec?

kind regards,

Jos

I get this part(I think):

if (sec < 0 || sec >= 60)
setSec(0);
else
this.sec= sec;

If the sec value is below 0 or above/equal to 60,the parameter sec wil be set to 0. Otherwise the parameter will get the value inserted right? But that doesn't explain to me why it keeps repeating.

it works perfect though :)

Quote:

---

Originally Posted by senca

I get this part(I think):

if (sec < 0 || sec >= 60)
setSec(0);
else
this.sec= sec;

If the sec value is below 0 or above/equal to 60,the parameter sec wil be set to 0. Otherwise the parameter will get the value inserted right? But that doesn't explain to me why it keeps repeating.

---

My version doesn't repeat; if you want to remove that one step recursion you can even write:

Code:

---

if (sec < 0 || sec >= 60)
  this.sec= 0;
else
  this.sec= sec;

---

kind regards,

Jos

oooow I get it now I think. You mean that while I was setting the parameter to 0,it kept changing back to the one that was innitially given? So when it was 500,it changed to 0,then to 500 en then got into a loop?

Quote:

---

Originally Posted by senca

oooow I get it now I think. You mean that while I was setting the parameter to 0,it kept changing back to the one that was innitially given? So when it was 500,it changed to 0,then to 500 en then got into a loop?

---

Yup.

kind regards,

Jos