servlet and JS

[saqib15]

Hey Folks, can anyone tell me whats is wrong in my code, i am trying to get values from checkbox whenever they clicked but when i run my code nothing happen, response will be highly appriciated


1.out.write("<FORM name=\"form1\"method=\"Post\" "+
2. "onSubmit=\"return onFormSubmit();\"");///ws/ws_ext?servlet=GetUsersList&token="+token+"&users= form\">");
3. out.write("<script type=\"text/javascript\">");
4. out.write("function onFormSubmit(){");
5. out.write("if(document.pressed==\"submit\"){");
6. out.write("var queryString=\"/ws/ws_ext?servlet=GetUsersList&token="+token+";");
7. //out.write("var chk=document.getElementByTagName(\"input\");");
8. out.write("for(int i =0;i<document.form1.elements.length;i++){");
9. out.write("if(document.form1.elements[i].type==\"checkbox\"){");
10. out.write("if(document.form1.elements[i].checked==true){");
11. out.write("queryString+=\"&user=\"+document.elemen ts[i].value;");
12. out.write("alert(queryString)");
13. out.write("}");
14. out.write("}");
15. out.write("}");
16. out.write("document.form1.action=queryString;");
17. out.write("document.form1.submit();");
18. out.write("}");
19. out.write("return queryString;");
20. out.write("}");
21. out.write("</script>");
22.
23. out.write("<tr>");
24. for(int h =0; h<human.length; h++){
25. out.write("<td></td><td bgcolor =#669933>"+human[h].getDisplayString()+"</td>");
26. }
27. out.write("</tr>");
28.
29. for (int i = 0; i < user.length; i++) {
30. out.write("<tr>");
31. out.write("<td bgcolor=#cecef6>"+role[i].getName()+"</td>");
32. for(int h =0; h<human.length; h++){
33.
34. out.write("<td>");
35. for (int j = 0; j < user[i].length; j++) {
36. out.write("<input type=\"checkbox\" name=\"name"+user[i][j].getName() +"\""+" value=\""+user[i][j].getName()+"\"/>");
37. out.write(user[i][j].getName());//this data to be with all tabs
38. }
39. out.write("</td><td></td>");
40. }
41.
42. out.write("</tr>");
43. }
44. out.write("<input type=\"button\" value=\"Next &gt;&gt;\" onClick=\'document.pressed=this.value' value=\"submit\">");
45. //out.write("</FORM>");
46. out.write("</table>");
47. //================================================== ======
48.
49. out.write("</FORM>");

[RamyaSivakanth]

Hi,
Why u have to frame the HTML like this? u can directly write as html right using jsp....Don't compicate urself...

[saqib15]

yeah i have restriction i can not use JSp thats the main problem with me...

[RamyaSivakanth]

1.You do one thing...U break as small small methods for simplicity and debugging sake.
ex: form build separate meth,javascript separate method like this...

2.Try to use StringBuffer and convert as String later....

[saqib15]

::Hey , i have created method saperately can anyone check where is my mistake


private StringBuffer addUsers (String token) {
StringBuffer outstring = new StringBuffer("\r\n<script type=\"text/javascript\">");
outstring.append("function onFormSubmit(){");
outstring.append( "if(document.pressed==\"submit\"){");
outstring.append( "var queryString=\"/ws/ws_ext?servlet=GetUsersList&token="+token+";");
outstring.append( "for(int i =0;i<document.form1.elements.length;i++){");
outstring.append( "if(document.form1[i].elements[i].type==\"checkbox\"){");
outstring.append( "if(document.form1[i].elements[i].checked==true){");
outstring.append( "queryString+=\"&user=\"+document.elements[i].value;");
outstring.append( "alert(queryString)");
outstring.append( "}");
outstring.append( "}");
outstring.append( "}");
outstring.append( "document.form1.action=queryString;");
outstring.append( "document.form1.submit();");
outstring.append( "}");
outstring.append( "return queryString;");
outstring.append( "}");
outstring.append("</script>");
return outstring;
}

[RamyaSivakanth]

In the 5th line u have missed double quotes.correct like this below.
outstring.append( "var queryString=\"/ws/ws_ext?servlet=GetUsersList&token="+token+";\"");

[saqib15]

Thank you Yes thats worked and its working now, really appriciate.